[mini-mod] Universal Guncaster Adapter 1.8

[Fureyon]

Found another bug: Whilst using Prism Laser on an custom enemy corpse I get a VM Aborted.
Using Colorful Hell v95

Given the timing, I think it's the same bug as we got in version 1.0 with Corpseblast, but this time it's being caused by Prism Laser.

Code: Select all

VM execution aborted: tried to read from address zero.

Called from GuncastDamageScript.DamageScriptDeploy at Universal_Guncaster_Adapter.pk3: zscript/genericsupportscripts.txt, line 50
Called from GuncastDamageScript.DoEffect at Universal_Guncaster_adapter.pk3: zscript/genericcustommonsters.txt, line 119

[Dinosaur_Nerd]

Updating to 1.2
This brings the adapter in line with the bugfixes and changes made to the Vindicated version

Code: Select all

-Increased gibbing threshold (harder to gib enemies)
-added a safety check for projectile adapter to deal with special cases (such as winters fury)
-increased gib threshold (harder to gib enemies now.)
-fixed ironblast strat glitch with adapter
-fixed archvile glitch with adapter

Found another bug: Whilst using Prism Laser on an custom enemy corpse I get a VM Aborted.
Using Colorful Hell v95

Given the timing, I think it's the same bug as we got in version 1.0 with Corpseblast, but this time it's being caused by Prism Laser.

Code: Select all

VM execution aborted: tried to read from address zero.

Called from GuncastDamageScript.DamageScriptDeploy at Universal_Guncaster_Adapter.pk3: zscript/genericsupportscripts.txt, line 50
Called from GuncastDamageScript.DoEffect at Universal_Guncaster_adapter.pk3: zscript/genericcustommonsters.txt, line 119

Got it fixed, thanks for catching it.

[Rowsol]

I'm playing with Pandemonia (I gutted the non-monster stuff) and I'm occasionally getting an error that says "unknown item class longhornmatriarch to drop from a random spawner".
When guys explode from acid instead of always facing me sometimes they are at different angles.
I set a custom cacodemon monster on fire and he wasn't taking any damage from it, the burning afterwards I mean.
I kicked a guy with midas boot while wearing powersuit then shot him with ironblast to finish him off and he turned into a statue. It happened a few more times afterwards. Powersuit probably isn't required.

Okay, it seems certain unique weapons that drop from the monsters can't find a suitable replacement and get removed. I'll just change their drops.
Also, the field kits that enemies drop aren't being replaced with anything, not sure if intentional or how one would even go about coding a replacement for a random custominventory item.

[Dinosaur_Nerd]

This was a very short lived update...
moving on to version 1.3

Code: Select all

-corrected glitches with gibbing and midas deaths
-added a new functionality where this mod will now check to see if you are using the addon, if you are, it spawns superweapons accordingly, if not, it will only spawn Dreadful, Powersuit, or DraughTome.

I'm playing with Pandemonia (I gutted the non-monster stuff) and I'm occasionally getting an error that says "unknown item class longhornmatriarch to drop from a random spawner".

I kicked a guy with midas boot while wearing powersuit then shot him with ironblast to finish him off and he turned into a statue. It happened a few more times afterwards. Powersuit probably isn't required.

both Fixed

When guys explode from acid instead of always facing me sometimes they are at different angles.

They're not supposed to keep facing you as they die.
I may not be understanding the report correctly, a video/gif and detailed explanation would be helpful.

I set a custom cacodemon monster on fire and he wasn't taking any damage from it, the burning afterwards I mean.

I'm pretty sure they are taking damage unless the cacodemon is immune to fire.
This script behaves exactly the same way "Pain.Fire:" works in Guncaster.
The fire ignition effect is easily the simplest part of this entire script, so long as they appear to be on fire, the damage effect is running.

Okay, it seems certain unique weapons that drop from the monsters can't find a suitable replacement and get removed. I'll just change their drops.
Also, the field kits that enemies drop aren't being replaced with anything, not sure if intentional or how one would even go about coding a replacement for a random custominventory item.

I'm working on a solution to this. It may not be possible to fix it, but if it is, I will find a way.

P.S.
Just wanna say thanks to everyone here for helping bug-test this and for all the reports.
This script is essentially a fork of a small piece of Guncaster Vindicated and I don't have enough time to extensively test it on my own, so any bugs I catch are likely a result of problems occuring in the main mod, and stuff unrelated to GCV may go under my radar.
You folks helping test this is what is gonna make sure it gets to a clean and bug-free state! thanks again!

[Rowsol]

"They're not supposed to keep facing you as they die."
Well then it's working as intended.

Here's a small clip showing the guy not taking burning damage. https://youtu.be/VdbV3BQwEas
Here's the code for the monster

---

Code: Select all

Actor Agathodemon : NewCacodemon
{
  Health 700
  BloodColor "Red"
  Obituary "%o was blasted by an Agathodemon."
  HitObituary "%o was caught in an Agathodemon's jaws."
  Tag "Agathodemon"
  var int user_phased;
  States
  {
  Spawn:
    AGAH A 10 A_Look
    Loop
  See:
    AGAH A 3 A_Chase
	TNT1 A 0 A_Jump(3,"GoPhase")
    Loop
  PhaseSee:
	TNT1 A 0 A_ChangeFlag("NOPAIN",0)
	AGAH AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA 1 A_ExtChase(0,0)
	AGAH A 1 A_Chase
	Goto PhaseSee+33
  GoPhase:
	AGAH A 8
		{
		A_SetUserVar("user_phased",1);
		A_ChangeFlag("NOPAIN",1);
		A_FaceTarget;
		A_PlaySound("PhaseImp/Teleport");
		}
	AGAH AAAAAAAA 1
		{
		A_FaceTarget;
		A_SetRenderStyle(Alpha-0.1,STYLE_Translucent);
		}
	Goto PhaseSee
  UnPhase:
	AGAH A 8
		{
		A_SetUserVar("user_phased",0);
		A_FaceTarget;
		A_PlaySound("PhaseImp/Teleport");
		}
	AGAH AAAAAAAA 1
		{
		A_FaceTarget;
		A_SetRenderStyle(Alpha+0.1,STYLE_Translucent);
		}
	Goto See
  Melee:
	AGAH C 4 A_FaceTarget
	AGAH DC 6 A_FaceTarget
	AGAH B 6 A_CustomMeleeAttack(10*random(1,6),"Cacodemon/Melee")
	Goto See
  Missile:
	TNT1 A 0 A_JumpIf(user_phased == 1,2)
	TNT1 A 0 A_Jump(64,"GoPhase")
	TNT1 A 0 A_Jump(100,"Homing")
	AGAH BC 8 A_FaceTarget
	AGAH D 2 Bright A_CustomMissile("AgathodemonBall",32)
	AGAH D 6 Bright 
		{
		A_CustomMissile("AgathodemonBall",32,0,-6);
		A_CustomMissile("AgathodemonBall",32,0,6);
		}
	TNT1 A 0 A_JumpIf(user_phased == 1,"UnPhase")
	Goto See
  Homing:
    AGAH BC 6 A_FaceTarget
    AGAH D 8 
		{
		A_CustomMissile("AgathodemonHomingBall",22,0,-30,0);
		A_CustomMissile("AgathodemonHomingBall",22,0,30,0);
		}
	TNT1 A 0 A_JumpIf(user_phased == 1,"UnPhase")
	Goto See
  Pain:
    AGAH E 3
    AGAH E 3 A_Pain
    AGAH F 6
    Goto See
  Death:
    AGAH G 8 A_SetRenderStyle(1.0,STYLE_NORMAL)
    AGAH H 8 A_Scream
    AGAH IJ 8
    AGAH K 8 A_NoBlocking
    AGAH L -1 A_SetFloorClip
    Stop
  XDeath:
	TNT1 A 0 A_SpawnItemEx("GibGenerator",0,0,0,0,0,0,0,SXF_USEBLOODCOLOR|SXF_SETMASTER)
	AGAX A 4 
	AGAX B 4 A_XScream
	AGAX C 4
	AGAX D 4 A_NoBlocking
	AGAX EFGHI 4
	AGAX J -1
	Stop		
  Raise:
    AGAH L 8 A_UnSetFloorClip
    AGAH KJIHG 8
    Goto See
	}
}

Actor NewCacodemon : Cacodemon //his inheritance 
{
  BloodColor "Blue"
  +DONTHARMSPECIES
  Species "Caco"
  DamageFactor "Caco", 0
  PainChance "Caco", 0
  Gibhealth 20
  Obituary "%o was zapped by a Cacodemon."
  HitObituary "%o was chomped by a Cacodemon."
  Tag "Cacodemon"
  Mass 800
  Scale 1.1
  DamageFactor "Crush", 5
  States
  {
  Melee:
	HEAD C 4 A_FaceTarget
	HEAD DC 6 A_FaceTarget
	HEAD B 6 A_CustomMeleeAttack(10*random(1,6),"Cacodemon/Melee")
	Goto See
  Missile:
	HEAD BC 5 A_FaceTarget
	HEAD D 5 Bright A_CustomMissile("CacodemonBall2")
	Goto See
  XDeath:
	TNT1 A 0 A_SpawnItemEx("GibGenerator",0,0,0,0,0,0,0,SXF_USEBLOODCOLOR|SXF_SETMASTER)
	CAXD A 4 
	CAXD B 4 A_XScream
	CAXD C 4
	CAXD D 4 A_NoBlocking
	CAXD EFGHI 4
	CAXD J -1
	Stop		
	}
}

I was also using Mikk's Champions and LegenDoomLite during this but he was neither legendary or a champion so I don't know if that played a role.

Oh, and btw, when I said certain weapons weren't being replaced, I was referencing the error I posted and you fixed, so no worries there.

[Dutchygamer]

I was already wondering when someone would come up with this Will definitely check this out later, see how it combines with various mods / map sets.

[Fureyon]

So... I have no idea how this happened or how to reproduce. I was playing Evilution with Colorful Hell and one of the maps had a bunch of those custom pinkies (not the CH ones) and I think an archvile got to one while it was exploding into a fine mist of red and wound up resurrecting it. Thing is, that bugged the sprite so I was being attacked by a perpetually exploding pinkie. Didn't cause lag, don't know if it expelled bits of flesh, but it was hilarious

[Dinosaur_Nerd]

So... I have no idea how this happened or how to reproduce. I was playing Evilution with Colorful Hell and one of the maps had a bunch of those custom pinkies (not the CH ones) and I think an archvile got to one while it was exploding into a fine mist of red and wound up resurrecting it. Thing is, that bugged the sprite so I was being attacked by a perpetually exploding pinkie. Didn't cause lag, don't know if it expelled bits of flesh, but it was hilarious

Is this the current version you're using? that was a bug before I replaced the forced gib animation overrides with an independent actor.
If it's still happening then some other shenanigans are going on. There may be some bad sprite behavior that I failed to account for, I thought the safety check I put in should have dealt with this, but I'll check again.

please also try updating to the current version of the adapter and trying again. If the bug is what I think it is, this bad behavior should occur any time a monster is gibbed and then resurrected by the archvile.

[Fureyon]

Guess I made a mistake when picking my mods this time around and used an old version. Sorry about that.

[Dinosaur_Nerd]

Updating to version 1.4

applying minor bug fixes for chillgrasp, and some gore fixes

[Rowsol]

I'm playing Resurgence and the Afrit isn't dropping any gems or doing anything other than it's stock animations. For some reason the adapter isn't detecting him. He replaces CommanderKeen.

The other custom enemy is the evil marine. He replaces the SS. I manually disabled GC's SS replacement and the evil marine acts appropriately.

Another problem I have deals with archviles resurrecting enemies. They come back as however they died. A guy you blew up will come back as a perpetually exploding corpse. This only happens with monsters that have been "adapted".

[Dinosaur_Nerd]

Updating to 1.5
This includes some bug fixes to archvile raise states

I'm playing Resurgence and the Afrit isn't dropping any gems or doing anything other than it's stock animations. For some reason the adapter isn't detecting him. He replaces CommanderKeen.

The other custom enemy is the evil marine. He replaces the SS. I manually disabled GC's SS replacement and the evil marine acts appropriately.

Some bad news on this one...
Unfortunately this is out of my hands.

The makers of the Resurgence map pack decided to name the monsters incorrectly. The afrit is actually named "Commander Keen" and evil marines are named "WolfensteinSS". The reason why the marines work is because Guncaster has a different naming scheme for the WolfensteinSS (GuncastWolfensteinSS) and can be avoided properly, however, Commander Keen does not, and the base class name has to be blacklisted.

Examples of monsters being renamed correctly using the same version of DeHackEd as is used in Resurgence can be found in Eviternity and Doom2 The way ID Did.

You can also correct this problem manually by going into the DeHackEd file yourself and just giving the WolfensteinSS and Commander Keen monsters new names.

Dehacked-replaced monsters appear to take precedence over any other replacements. The names in the DEH file are solely for viewing in the DeHackEd editor; the game does not actually do anything with that information, only the Thing Number will affect anything.

I hadn't paid attention to the fact that eviternity actually uses decorate in addition to DeHackEd.
Why? I... I guess I don't wanna know.

I really wanted to avoid flagging commander keen as a monster that'd be handed out this script, since commander keen in DOOM2 is basically just a shootable decoration, but still has the +IsMonster flag. I guess I'll have no choice but to remove him from the blacklist.

Thanks for pointing out the error, I'll get it fixed up and post an update soon.

[wildweasel]

Dehacked-replaced monsters appear to take precedence over any other replacements. The names in the DEH file are solely for viewing in the DeHackEd editor; the game does not actually do anything with that information, only the Thing Number will affect anything.

If money drops are to be made fully universal, you'll have to find a way to handle that besides simply replacing the monsters via Decorate. I managed to get a fairly comprehensive system for it in ww-cola3 using KILL scripts (that detect if the script's executor is +ISMONSTER and +COUNTKILL, otherwise they abort the script) that spawn a proportional amount of pickup items depending on the executor's base hit points. I'm sure that can be made to handle other aspects as well.

[mpcomp]

Greetings

Am a huge fan of all pillowblaster doom game mods and am grateful to you for making an adapter for making his guncaster mod compatible with majority of monster mods..

that said I have encountered VM aborts for my gameplay and just like previous errors mentioned here the culprit mod is colourfull hell v097 bbb hotfix.

and the spells that cause this crash are apocolypse and scrougebreath.

all other spells including corpse blast and prism laser work like a charm...

here is the error recorded in my gzdoom logfile

Log started: Sat Apr 27 01:21:10 2019

VM execution aborted: tried to read from address zero.
Called from GuncastDamageScript.DoEffect at Universal_Guncaster_Adapter.pk3:zscript/genericcustommonsters.txt, line 101
]exit

my gzdoom version is 3.7.2

the adapter version in use by me is v1.5

Hope it will be fixed soon...

Peace

[The Nameless Watcher]

I am also getting the error reported by mpcomp.

Using Guncaster and its addon, Colourful Hell 0.97ccc fiiix , and 1.5 of this addon. Playing on Ancient Aliens if that helps at all.
I am using GZdoom 4.0 however. The same spells caused the problems for me, but prism laser caused it as well. Can't verify corpse blast.

I will say that even with this error this is still incredibly awesome.