[Closed] [PULL REQUEST] Export FBoundingBox to ZScript

Moderator: GZDoom Developers

Re: [PULL REQUEST] Export FBoundingBox to ZScript

Postby drfrag » Tue Dec 11, 2018 12:50 pm

Rachael wrote:and it's not known or likely to cause any other issues

That's precisely the point here, oops i've reverted it anyway. :P
I've noticed myself that the previous "solution" was a bit shitty and now i've added a FDrawInfo* parameter to GLPortal::End.
I don't even know what outer_di is but hey if it works it works. :D
https://github.com/drfrag666/gzdoom/com ... 9ac12ce215

I've noticed that LZDoom is also affected by this shit, there was a similar problem in 3.3.2 and seems something i cherry-picked has made it come back.
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: [PULL REQUEST] Export FBoundingBox to ZScript

Postby phantombeta » Tue Dec 18, 2018 5:27 pm

Just to be sure, are there any issues with this PR?
I'd also like to know if this is really the proper way to do this - I feel like FBoundingBox itself should be exported so it's more useful for future scriptification of actors, but I can't simply do it, since everything creates and destructs it manually.
User avatar
phantombeta
In the meadow of sinful thoughts, every flower's a perfect one
 
Joined: 02 May 2013
Location: The United Soviet Socialist Dictatorship of Hueland
Discord: phantombeta#2461
Twitch ID: phantombeta_
Github ID: Doom2fan
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [PULL REQUEST] Export FBoundingBox to ZScript

Postby phantombeta » Wed Dec 26, 2018 6:41 am

I've given up on this PR due to some issues, so this can be closed.
User avatar
phantombeta
In the meadow of sinful thoughts, every flower's a perfect one
 
Joined: 02 May 2013
Location: The United Soviet Socialist Dictatorship of Hueland
Discord: phantombeta#2461
Twitch ID: phantombeta_
Github ID: Doom2fan
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [PULL REQUEST] Export FBoundingBox to ZScript

Postby phantombeta » Sun Oct 20, 2019 9:24 am

It seems this thread was left open. I've closed the PR a while ago, so this should be moved to Closed Feature Suggestions. (Maybe labelled something like just "Closed")
User avatar
phantombeta
In the meadow of sinful thoughts, every flower's a perfect one
 
Joined: 02 May 2013
Location: The United Soviet Socialist Dictatorship of Hueland
Discord: phantombeta#2461
Twitch ID: phantombeta_
Github ID: Doom2fan
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Previous

Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest