Make various methods clearscope, and bump ZScript version

Like feature suggestions, but you've actually written code to make it happen. More likely to make it into the game than some random request in feature suggestions.

Moderator: Developers

Forum rules
Please see Code submission guidelines

GZDoom Status:
Image Image

Link to Legacy Repo

QZDoom Status:
Image Image

Make various methods clearscope, and bump ZScript version

Postby argv » Sun Aug 12, 2018 1:54 am

I've sent two PRs.

PR #532 makes several ZScript methods clearscope and (where applicable) const. Please see the PR for rationale.

PR #533 sets the ZScript version on master to 3.5.0. It was set to that in the 3.5.0 release commit, but was left at 3.4.0 on master.
argv
 
Joined: 30 Aug 2016

Re: Make various methods clearscope, and bump ZScript versio

Postby Graf Zahl » Sun Aug 12, 2018 3:01 am

For the clearscope thing I'll wait for feedback of someone working on the C/S branch. I cannot say if any of it may interfere with that.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Make various methods clearscope, and bump ZScript versio

Postby Rachael » Sun Aug 12, 2018 4:45 am

I don't have a clear answer right now for that, so please bump this thread when the branch has matured a bit more. Right now we don't know exactly how client-side actors are going to be handled so without that it's difficult to say whether it's safe to move ahead with this or not.

(For reference the two clientside implementations being considered are static dummy actors that simply mimic their server counterparts in all available visual aspects, and the second idea was to spawn copies of the server representations and allow the client to execute these actors directly as a means of prediction)

Even if it is, it's a fairly certain bet that clearscoping these won't work as expected on the client side, but we'll have to climb that hill when we get there before we'll really know for sure.
User avatar
Rachael
QZDoom + Webmaster
 
Joined: 13 Jan 2004

Re: Make various methods clearscope, and bump ZScript versio

Postby Graf Zahl » Sun Aug 12, 2018 4:49 am

So we have to be very careful with clearscoping stuff.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Make various methods clearscope, and bump ZScript versio

Postby argv » Sun Aug 12, 2018 8:48 pm

Okay.

Some of the methods I mentioned are, as far as I can tell, completely unaffected by playsim state (they're either pure or access static class information), namely deltaangle, absangle, AngleToVector, RotateVector, Normalize180, FindState, and GetDropItems. What if I send another PR that clearscopes only those? Would that be safe to merge now?

Good luck on the C/S branch, by the way. Modern, Zandronum-like networking with an up-to-date engine would be completely awesome. :biggrin:
argv
 
Joined: 30 Aug 2016

Re: Make various methods clearscope, and bump ZScript versio

Postby Graf Zahl » Mon Aug 13, 2018 1:31 am

argv wrote:Okay.

Some of the methods I mentioned are, as far as I can tell, completely unaffected by playsim state (they're either pure or access static class information), namely deltaangle, absangle, AngleToVector, RotateVector, Normalize180, FindState, and GetDropItems. What if I send another PR that clearscopes only those? Would that be safe to merge now?

Good luck on the C/S branch, by the way. Modern, Zandronum-like networking with an up-to-date engine would be completely awesome. :biggrin:



If it is purely static, clearscope is safe. So yes, please do.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Make various methods clearscope, and bump ZScript versio

Postby argv » Tue Aug 14, 2018 3:23 am

Done. #536 clearscopes only the static and meta methods.
argv
 
Joined: 30 Aug 2016


Return to Code Submissions

Who is online

Users browsing this forum: No registered users and 0 guests