A_SpawParticles (X,Y,Z,XYZSpeeds,Color)

[Edward-san]

This must be updated with the new acs functions and the new actor position code, because it won't merge/compile right now:

Code: Select all

/home/edward-san/zdoom/trunk/src/thingdef/thingdef_codeptr.cpp:2661:32: error: 
      no member named 'x' in 'AActor'
                P_SpawnParticle(xoff + self->x, yoff + self->y, zoff + s...
                                       ~~~~  ^
/home/edward-san/zdoom/trunk/src/thingdef/thingdef_codeptr.cpp:2661:48: error: 
      no member named 'y' in 'AActor'
                P_SpawnParticle(xoff + self->x, yoff + self->y, zoff + s...
                                                       ~~~~  ^
/home/edward-san/zdoom/trunk/src/thingdef/thingdef_codeptr.cpp:2661:64: error: 
      no member named 'z' in 'AActor'
  ...P_SpawnParticle(xoff + self->x, yoff + self->y, zoff + self->z, xvel, yv...
                                                            ~~~~  ^
3 errors generated.

[Major Cooke]

I could fix it for edward850 if he's busy.

[Graf Zahl]

No need to. That self->Vec3Offset(xoff, yoff, zoff) and then passing the 3 components to the function is a one minute issue.

But since my last post everybody still seems to weasel around a decision. So what's up? I think of all the pending submissions this is one of the most useful and least invasive ones so it's a prime candidate for immediate inclusion.

[Major Cooke]

I say it's fine as it is. Edward decided to keep it as it is too.

It kind of melted over the Christmas holidays when I was stuck with my laptop. I was going to try and set everything up with variance variables but it quickly become too bloated as well (which seems to be the problem with most ideas), especially if you only wanted to spawn 1 particle at a time.
The way I see it at the moment, it shouldn't matter as is. As long as it's named A_SpawnParticle (which it is), if a good idea comes in the future, you still have room for a plural A_SpawnParticles.

[Graf Zahl]

Agreed.

[StrikerMan780]

A_SpawnParticles(count, minx, miny, minz, maxx, maxy, maxz, minvelx, minvely, minvelz, maxvelx, maxvely, maxvelz, color, lifetime, fullbright, startalpha, size, fadestep, accelx, accely, accelz)

Makes the number of parameters pretty large, but this is what I propose for spawning multiple particles. Being able to specify min/max offsets and velocities. (If someone already mentioned this, I apologize. In a hurry at the moment.)

[Gez]

IMO the color (or type) should be first, the count second, and all the other params should have workable default. Putting color, as you do, as the 14th parameter is not good.

[D2JK]

minx, miny, minz, maxx, maxy, maxz, minvelx, minvely, minvelz, maxvelx, maxvely, maxvelz

I think there is no need for separate min/max parameters; frandom() should suffice here.

Other than that, I agree with having more options.

[Graf Zahl]

minx, miny, minz, maxx, maxy, maxz, minvelx, minvely, minvelz, maxvelx, maxvely, maxvelz

I think there is no need for separate min/max parameters; frandom() should suffice here.

No, it wouldn't. You do not want one random number for all, you want different numbers, and for those you need the min and max.

[Graf Zahl]

Looking through this, I think I'm going to change the alpha parameter of the DECORATE version from byte to float for consistency. So please no hurry with the docs...

[Hellser]

I can't wait to use this. Oh, this is going to be so deliciously good!

[Major Cooke]

Looking through this, I think I'm going to change the alpha parameter of the DECORATE version from byte to float for consistency. So please no hurry with the docs...

What about a relative flag? Something to make it like A_SpawnItemEx's relativity, or akin to A_ChangeVelocity's RELATIVE flag.

[D2JK]

No, it wouldn't. You do not want one random number for all, you want different numbers, and for those you need the min and max.

Your comment was a bit hard to decipher at first, but I assume you are referring to each random value being randomized only once per function call. If so, I see what you mean.

[edward850]

Looking through this, I think I'm going to change the alpha parameter of the DECORATE version from byte to float for consistency. So please no hurry with the docs...

You didn't want to do this with fadestep as well, which directly relates to the starting alpha?

[Graf Zahl]

Does it? Can you explain what this parameter is there for?