Page 1 of 1
[2.6.0?] snd_reset no longer restarts music after stopmus
Posted: Tue Sep 01, 2015 11:47 am
by zalewa
I've noticed that newest beta Zandronum builds (which are based off ZDoom 2.8) no longer restart level music on snd_reset CCMD when it was first stopped with stopmus CCMD. I've found this commit that seems to introduce the change:
https://github.com/rheit/zdoom/commit/a ... 9ab452d302
Was this side effect intentional? The commit message only states that this was supposed to affect volume changes in the menu.
Re: [2.6.0?] snd_reset no longer restarts music after stopmu
Posted: Wed Nov 25, 2015 5:57 am
by Graf Zahl
Of course this was intentional. That was the whole point of this change. If the music was explicitly stopped it should not automatically resume.
Re: [2.6.0?] snd_reset no longer restarts music after stopmu
Posted: Wed Nov 25, 2015 3:21 pm
by zalewa
One could argue that calling snd_reset CCMD isn't automatic but intentional, but it doesn't matter anymore as music restart can also be achieved with 'changemus *'.
Re: [2.6.0?] snd_reset no longer restarts music after stopmu
Posted: Wed Nov 25, 2015 3:34 pm
by Graf Zahl
The point here is that 'stopmus' must clear the active music. And once it's cleared, even a snd_reset shouldn't restart it - because there was no music playing at the time of reset.
Re: [2.6.0?] snd_reset no longer restarts music after stopmu
Posted: Wed Nov 25, 2015 4:38 pm
by zalewa
That is... logical.