Health regen script runaway

[rollingcrow]

So while the below problem is fixed, I have another problem. When the player has at least 1 Tenacity item, when it dies the HealthRegen script throws up a runaway script error. Any ideas on why this is happening?

Code: Select all

Script "HealthRegen" ENTER
{
	If (CheckInventory("Dead") == 0)
	Delay(1);
	{
		If (CheckInventory("Pained") == 0)
		{
		If (GetActorProperty(0, APROP_HEALTH) < (CheckInventory("BasicArmor")))
			{
			HealThing(1);
			}
		}
  	}
	Delay(6/StaminaReliance/Tenacity1Power);
 	Restart;
}

Code: Select all

Int Tenacity1Power;

Script "Tenacity1Power" ENTER
{
	If (CheckInventory("Tenacity") > 0)
		{Tenacity1Power = 2;}
	Else If (CheckInventory("Tenacity") == 0)
		{Tenacity1Power = 1;}
	Delay(1);
	Restart;
}

Code: Select all

Int StaminaReliance;

Script "HealthRegenStaminaReliance" ENTER 
{
	If (CheckInventory("StaminaX") >= 2625)
		{StaminaReliance = 4;}
	Else If (CheckInventory("StaminaX") >= 1750)
		{StaminaReliance = 3;}  
	Else If (CheckInventory("StaminaX") >= 875)
		{StaminaReliance = 2;}
	Else If (CheckInventory("StaminaX") >= 0)
		{StaminaReliance = 1;}
	Delay(1);
	Restart;
}

---

Right now I have a health regeneration script that is supposed to heal 2 HP when the player has the item Tenacity in their inventory, and 1 HP when the player doesn't. However at the moment it is always healing 1 HP regardless of whether or not the player has the Tenacity item or not. Any ideas on why this is happening?

Code: Select all

Actor Tenacity : Inventory {Inventory.MaxAmount 3}

Code: Select all

Int Tenacity1Power;

Script "Tenacity1Power" ENTER
{
	If (CheckInventory("Tenacity") > 0)
		{Tenacity1Power = 2;}
	Else If (CheckInventory("Tenacity") == 0)
		{Tenacity1Power = 1;}  
}

Code: Select all

Script "HealthRegen" ENTER
{
	If (CheckInventory("Dead") == 0)
	Delay(1);
	{
		If (CheckInventory("Pained") == 0)
		{
		If (GetActorProperty(0, APROP_HEALTH) < (CheckInventory("BasicArmor")))
			{
			HealThing(Tenacity1Power);
			}
		}
  	}
	Delay(RegenRate/14);
 	Restart;
}

[ChronoSeth]

You appear have a stray Delay(1) immediately after the first if in the HealthRegen script. No idea if that's causing the problem.

[disposable_username2]

Right now I have a health regeneration script that is supposed to heal 2 HP when the player has the item Tenacity in their inventory, and 1 HP when the player doesn't. However at the moment it is always healing 1 HP regardless of whether or not the player has the Tenacity item or not. Any ideas on why this is happening?

idea: Tenacity1Power is only updated on map changes, so tenacity change won't take effect until next level.

[rollingcrow]

You appear have a stray Delay(1) immediately after the first if in the HealthRegen script. No idea if that's causing the problem.

Without it, I'll get a runaway script error. Thanks anyway.

idea: Tenacity1Power is only updated on map changes, so tenacity change won't take effect until next level.

Added Restart at the end and it worked.

[rollingcrow]

Sorry to bump this, but there is a runaway script error happening now when the player dies with tenacity (first post updated).

[Blue Shadow]

This line could cause a runaway script, I think:

Code: Select all

Delay(6/StaminaReliance/Tenacity1Power);

If you have a StaminaReliance of 4 and Tenacity1Power of 2, you'll end up with 0.75 as the delay (6/4/2 = 0.75). Now since division in ACS results in an integer, it means that the 0.75 will actually be a 0 (the decimal part is simply truncated). So in that case, you're basically passing 0 as the delay.

Or it could be something else entirely.

[rollingcrow]

The 6 is now an 8 (8/4/2=1) and now there isn't an error, thanks.

[Mánibranðr System]

I think it's better to do the calculation first, pass the result to a newly-declared variable, have a check to see if the result is 0, and if so, change the value to 1, then set the delay to that variable. Or simply do a ceiling division.