PerK's Smooth Weapons Enhanced [v3.1.1]

Projects that alter game functions but do not include new maps belong here.
Forum rules
The Projects forums are ONLY for YOUR PROJECTS! If you are asking questions about a project, either find that project's thread, or start a thread in the General section instead.

Got a cool project idea but nothing else? Put it in the project ideas thread instead!

Projects for any Doom-based engine (especially 3DGE) are perfectly acceptable here too.

Please read the full rules for more details.

Version 1.32 retro upload

Postby NightFright » Sun Nov 17, 2019 3:08 am

I didn't bother trying to search through my archives since I am almost sure I don't have these files any more. But you remind me to store old versions for purposes like this. Time to start with it!

That being said, I used the powerful Wayback Machine and got the old files from Nov 2016 like that. They are attached below. Please note that the mod still used separate files back then, pk_anim1 for normal gloves and pk_anim2 for black gloves. Those were the days!
Attachments
pk_anim1_v132.zip
PK Enhanced v1.32
(225.25 KiB) Downloaded 16 times
pk_anim2_v132.zip
PK Enhanced v1.32 (Black Gloves)
(221.21 KiB) Downloaded 14 times
User avatar
NightFright
Spotlight Team
 
Joined: 02 May 2008
Location: Germany

Re: PerK's Smooth Weapons Enhanced [v3.1.1]

Postby bLUEbYTE » Sun Nov 17, 2019 3:23 am

Amazing, thanks NightFright!
bLUEbYTE
 
Joined: 15 Nov 2019
Location: Australia
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: Intel with Vulkan Support

Re: PerK's Smooth Weapons Enhanced [v3.1.1]

Postby Scuba Steve » Sun Nov 17, 2019 7:26 am

The alignment of the plasma rifle firing is off.
Scuba Steve
 
Joined: 28 Mar 2004

Re: PerK's Smooth Weapons Enhanced [v3.1.1]

Postby Nash » Sun Nov 17, 2019 8:21 am

Scuba Steve wrote:The alignment of the plasma rifle firing is off.


Alignment, as in the sprite offsets? I'll take a look and try to fix it, thanks for the feedback.
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes

Re: PerK's Smooth Weapons Enhanced [v3.1.1]

Postby m8f » Fri Dec 06, 2019 9:03 am

If someone makes a PR with optional Accurate Weapon Firing, will it be accepted?
User avatar
m8f
the dreamer
 
 
 
Joined: 29 Dec 2017
Discord: m8f#0629
Github ID: mmaulwurff

Re: PerK's Smooth Weapons Enhanced [v3.1.1]

Postby Nash » Fri Dec 06, 2019 9:15 am

That seems like it involves rather extensive code-work... feel free to do the PR if you want, but I'll probably have to assess it more carefully than the last one you sent (which was a very simple change :)).
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes

Re: PerK's Smooth Weapons Enhanced [v3.1.1]

Postby m8f » Fri Dec 06, 2019 2:04 pm

https://github.com/NightFright2k19/perk_enhanced/pull/2

I should review it tomorrow myself, too, when I have a clearer state of mind.
User avatar
m8f
the dreamer
 
 
 
Joined: 29 Dec 2017
Discord: m8f#0629
Github ID: mmaulwurff

Re: PerK's Smooth Weapons Enhanced [v3.1.1]

Postby Nash » Fri Dec 06, 2019 8:11 pm

A couple of comments so far from a quick cursory glance:

1) Mixins aren't in the official version yet, so if this gets merged, a new release shouldn't be put out just yet.
2) You named some variables _ ... there is an internal GZDoom struct with the same name, although you don't get any errors now, I think you should use a better name?
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes

Re: PerK's Smooth Weapons Enhanced [v3.1.1]

Postby m8f » Fri Dec 06, 2019 11:33 pm

1. Yes, I understand. Common base is inaccessible for these weapons, so mixins are the only way to prevent code duplication. And I also wanted to finally try them out :)
2. Renamed _ variable.
User avatar
m8f
the dreamer
 
 
 
Joined: 29 Dec 2017
Discord: m8f#0629
Github ID: mmaulwurff

Previous

Return to Gameplay Mods

Who is online

Users browsing this forum: ErrantMasa, Ixcuazl, Metalhead33 and 14 guests