[????-r2343]"Disallow suicide" is inverted

[Edward-san]

You get the opposite effect when you toggle it via the menu. It should be renamed to "Allow Suicide".

It does happen also in latest Zdoom svn.

[edit]Launch zDoom, open menu, then go to: options -> gameplay options, and you will see that "Disallow suicide" is set as "Yes". Load a new game, then type 'kill' in console. You'll die.
Viceversa, set that option to "no", then retry to kill yourself. You won't die.

[ZDG]

Really? It doesn't does that to me.

[Edward-san]

Really? It doesn't does that to me.

When "Disallow suicide" is set to true, it means that you can't kill yourself, but in game you can die by typing "kill" in console.
When instead the option is set to false, it means that you can kill yourself, but in game you can't die by writing "kill" in console.

[Xaser]

Interestingly enough, I just tested this myself and the option does, indeed, seem to be reversed. Wonder how long it's been this way...

[ZDG]

I can kill using the console both times.

[Demolisher]

I can kill using the console both times.

You're doing it wrong.

[ZDG]

Of course, i meant killing myself.

[Edward-san]

Of course, i meant killing myself.

Hmmm.... I'm curious about this:
1)what version are you using?
1)what happens if you use the latest svn beta, if you don't?
3)what happens if you try doing a fresh install of zdoom in a different folder, then retry what I say?

[edit]may help tracking someway the broken revision[/edit]

[InsanityBringer]

And make sure you are in netplay mode

[Demolisher]

Of course, i meant killing myself.

I have latest SVN, this bug is present, AND if I disable suicide, I cannot kill myself using the console. I have NO CLUE what this dude is smoking.

[InsanityBringer]

Hmm, I thought the problem was he wasn't in netgame mode. however the CVAR applies for me even if I'm in SP mode.

[Xaser]

I tested both, for the record. My results mirror Ed's in both cases.

[Edward-san]

Hmm ... I've checked the code, I don't know which code is wrong:
in p_interaction.cpp:

Code: Select all

		// If suiciding is disabled, then don't do it.
		if (dmflags2 & DF2_NOSUICIDE)
			return;

		// Kill the player
		Net_WriteByte (DEM_SUICIDE);

Or in m_options.cpp:

Code: Select all

	{ bitflag,	"Disallow Suicide",		{&dmflags2},	{1}, {0}, {0}, {(value_t *)DF2_NOSUICIDE} },

What about correct this comment in doomdef.h:

Code: Select all

	DF2_NOSUICIDE			= 1 << 22,	// Players are allowed to suicide.

?


[edit]Nah, not needed. It's better to change the following names IMHO:
DF2_NOSUICIDE -> DF2_SUICIDE
"Disallow Suicide" -> "Allow suicide"
sv_disallowsuicide -> sv_allowsuicide

[ZDG]

I have latest SVN,

Oh, i don't. That must be the thing.

[Edward-san]

After days lost to learn how to create patches (Thank you Gez), I've done a patch which seems to fix the problem. I've also changed the sv_ command, but I don't know if the ini changes it after the upgrade. Hope it helps.
BTW in the patch there is a nitpick correction if you like it.

*Waiting for the mancubus site return.

suicidefix&nitpick.zip

(1.09 KiB) Downloaded 31 times