[Bad wads] Music Crash

Sparky · Post by **Sparky** » Wed Dec 03, 2003 2:55 pm

ok then, ill upload them now
the links should be
http://sparky.suhost.com/heremus.zip
http://sparky.suhost.com/heremus3.zip
BTW this music is for heretic

EDIT: im uploading the files now, give it some time im uploading at 35KB a sec so i should be done soon
the sizes arent to bad, ones 39MB the other is 35MB

Sparky · Post by **Sparky** » Wed Dec 03, 2003 3:36 pm

ok, im all done
you can go download them now

Post by **Kappes Buur** » Wed Dec 03, 2003 10:50 pm

.
Well, it appears to be a file size limit.

The original heremus.mp3 wouldn't load at all. Neither did it crash for me.
Then I cut it down from 33:39:24 mins to 15:00:00 mins and it loaded in ok.
.

Post by **Enjay** » Thu Dec 04, 2003 6:00 am

When you cut it down, did you save the cut down version in exactly the same format as the original? The reason I ask is (as I mentioned before) a long time ago I came across an MP3 file that made Zdoom crash, but loading into GoldWave and saving with a slightly different format (I dunno, a different sample rate or something) allowed the file to work.

I don't know if I have ever used a file as long as 33 mins, but I have used some fairly long ones without problems.

Sparky · Post by **Sparky** » Thu Dec 04, 2003 6:40 am

interesting
i really dont want to cut up my music

but im thinking this is a limit in zdoom?

Post by **randi** » Thu Dec 04, 2003 9:36 pm

The problem with both your wads is the same: You have a lump called TITLE that contains music. TITLE is the title picture, not the music. The title music for Heretic is supposed to be in a lump called MUS_TITL.

Post by **Kappes Buur** » Thu Dec 04, 2003 11:32 pm

Kappes Buur wrote: Well, it appears to be a file size limit.

Hmmm, at least that's what I thought. I had renamed both your music files to D_RUNNIN.WAD (one at a time, of course),
stuffed it into the skins folder, started up ZDoom and they would not play. That's when I reduced the size of the mp3 file,
and it would play, following the same method as before.

Now, after Randy's comment I tried it again with the fullsized file and lo and behold, the blasted music starts playing.
Even with the TITLE lump still present. So, it's not a file size limit.

@Enjay

all the mp3 files I work with are 44100 Hz and 16 bits
.

Sparky · Post by **Sparky** » Fri Dec 05, 2003 6:49 am

ok, interesting
but whats the deal with a crash? it shouldnt crash if theres that lump there

Post by **Graf Zahl** » Fri Dec 05, 2003 6:54 am

The problem is most likely that there is no certain way to identify a graphics lump as such. So it will try to display your TITLE MP3 and crash. The only solution to avoid such a crash is to put an exception handler in the patch drawing function.

Sparky · Post by **Sparky** » Fri Dec 05, 2003 6:56 am

in english please

i dont know all these wacky terms

Post by **Graf Zahl** » Fri Dec 05, 2003 8:37 am

The game tries to display your music file as a picture and screws up. That's all!

randomlag · Post by **randomlag** » Fri Dec 05, 2003 11:51 am

Graf Zahl wrote:The problem is most likely that there is no certain way to identify a graphics lump as such. So it will try to display your TITLE MP3 and crash. The only solution to avoid such a crash is to put an exception handler in the patch drawing function.

As I've said many times before, you can identify a graphics lump with high certainty. That's from actually doing it, not an idle guess

So the solution is to put some better checking in there.

Sparky · Post by **Sparky** » Fri Dec 05, 2003 2:35 pm

ok ic, but that still shouldnt make zdoom crash
the music file just wouldnt be a music file
so there, no crash. ill post a bug about this then

Post by **Ty Halderman** » Fri Dec 05, 2003 3:12 pm

It's not a bug, it's an enhancement request. Granted it's nice when things don't crash when you abuse them, but right now it's your fault. Let's let Randy fix bugs for the moment. He has a deadline to meet

Sparky · Post by **Sparky** » Fri Dec 05, 2003 3:15 pm

well, i guess it is
i mean the crash its trying to load a music file as a graphic
that makes sence
but the fact that its crashing is a bug, instead of that it shouldnt do anything at all