No Splash Powerup Help! Causes crash for some reason

[Amuscaria]

I'm trying to make a powerup that stops the layer from taking slash damage and renders him immune to most damaging floors. I got the floor-protection working, but I cant seem to find the ACS equivilent to A_ChangeFlag. I was hoping to do something like this "A_ChangeFlag("NORADIUSDMG",1)" Does that work? Also, if I change the players flag, do the flags reset everytime he goes to a new stage or is it kept?

[Theshooter7]

Why not use GiveInventory() and give the player an item that will use A_ChangeFlag() and change him to be immune to radius damage?

[Amuscaria]

Why not use GiveInventory() and give the player an item that will use A_ChangeFlag() and change him to be immune to radius damage?

I thought about that, but if I change a flag, do I need to change it back so he doesnt have it at the next map?

[Xaser]

Well, you'd probably need a second simple item that removes the flag in the same manner, and give that at map start. It wouldn't be much more trouble than turning it on, though.

Also, if you don't feel like checking and removing at the beginning of each map, a cheap way would be to just use a global script library with something that looks like this:

Code: Select all

script 92939393 enter
{
      giveinventory("RadiusDamageEnabler",1);
}

Syntax hasn't been checked, and the script number is bogus, but it felt necessary.

[HotWax]

Why not use GiveInventory() and give the player an item that will use A_ChangeFlag() and change him to be immune to radius damage?

Erm, something tells me that won't work. Wouldn't the A_ChangeFlag function change the flag of the item itself and not the player?

Also, seeing as how the item will be destroyed when the player picks it up, where would you put the command?

[Amuscaria]

I know someone has gotten it to work before. When I first moved to Zdoom, i suggested that a NORADIUSDMG powerup.type be added, it was refused. But someone got it working through ACS. I forgot who though.

[HotWax]

Hmmm, what you could do is use A_JumpIfInventory to jump to an A_ChangeFlag function within the player's states if they have the item in question.

[Amuscaria]

Ok, something is wrong with my library. I made a *.o file just like i did for the regeneration, but for some reason it wont recognize my script when I run the game.

Here's my library:

#include "zcommon.acs"

bool Hellsphere[8];

---

Code: Select all

Script 700 (VOID) 
{ 
   Hellsphere[PlayerNumber()] = TRUE; 
   ACS_ExecuteAlways(701,0); 
} 

Script 701 (VOID) 
{ 
   while (Hellsphere[PlayerNumber()]) 
   { 
      GiveInventory("Fire",1);
      GiveInventory("BloodAmmo",1);
      GiveInventory("boneAmmo",1);
      GiveInventory("Soul",1);
      delay(35); 
   } 
} 

Script 702 DEATH       
{             
   Hellsphere[PlayerNumber()] = FALSE; 
} 

Whenever I pick it up, I get this 'ACS: I dont know what (a Flat name) is" or it jsut crashes out. Here's the crash report.

Here's the decorate:

---

Code: Select all

actor HellSphere : CustomInventory 5213
{
  inventory.pickupmessage "Hellphere!"
  inventory.pickupsound "misc/p_pkup"
  +COUNTITEM
  +INVENTORY.AUTOACTIVATE
  +INVENTORY.ALWAYSPICKUP
  states
  {
  Spawn:
    HELS ABCD 4 Bright
    loop
  Pickup:
    HELS A 0 A_ChangeFlag("NORADIUSDMG",1)
    HELS A 0 A_GiveInventory("NoEnvironDMG")
    HELS A 0 ACS_ExecuteAlways(700,0,0,0,0)
    stop
  }
}

actor NoEnvironDMG : PowerupGiver //not actually used in map
{
  inventory.pickupmessage "No Floor Damage, YAY!"
  inventory.maxamount 0
  powerup.duration 252000
  powerup.type "IronFeet"
  +INVENTORY.AUTOACTIVATE
  +INVENTORY.ALWAYSPICKUP
  states
  {
  Spawn:
    NULL A 4 Bright
    loop
  }
}

it;s supposed to give the NORADIUSDMG flag and a powerup that lasts for (2 hours, since i dont know how to set a powerup to last forever) that takes away floor and environment damage.

[Grubber]

Erm, something tells me that won't work. Wouldn't the A_ChangeFlag function change the flag of the item itself and not the player?

No, it will change the activator's (player's) flag.

[Anakin S.]

As long as it's in the item's Pickup/Use states.

[Amuscaria]

Ok, I got the powerup working besides the script part. So there is something wrong with what I'm doing with the giveinventory actions. Can someone point how whats wrong? Cuz I get "ACS: I dont know what (then a name of a flat within the map) is."

[Theshooter7]

I can't remember, but aren't you not allowed to have delays inside of while statements? I might be wrong on that though. Maybe I am mistaking it for functions...

[Amuscaria]

I can't remember, but aren't you not allowed to have delays inside of while statements? I might be wrong on that though. Maybe I am mistaking it for functions...

The regeneration thing worked just fine with the delays. o_o I basically copy and pasted the thing and just added the giveinventory commands.

[HotWax]

Erm, something tells me that won't work. Wouldn't the A_ChangeFlag function change the flag of the item itself and not the player?

No, it will change the activator's (player's) flag.

Doh! Been gone... too long! Must.... research.... more!

I can't remember, but aren't you not allowed to have delays inside of while statements? I might be wrong on that though. Maybe I am mistaking it for functions...

Yes you are. ACS doesn't support delays in functions because a function should occur entirely within 1 tic, unlike scripts which can span multiple tics using delays.

This does have the side-effect of making most while loops pointless in functions since whatever the while is waiting on is unlikely to change. Maybe that's where your confusion comes from.