ACS_ExecuteWithResult doesn't support named scripts

[CoderGrizzly]

Hello everyone,

it seems that ACS_Execute supports script numbers as well as named scripts - but ACS_ExecuteWithResult does not.
Not sure if it is a bug or simply an inconsistency, but I want to bring it to everyone's attention.

Code: Select all

#include "zcommon.acs"

script "test1" OPEN {
	int value = ACS_ExecuteWithResult("test2", 1, 2);
	Log(s:"Value : ", d:value);
}

script "test2" (int x, int y) {
	int result = x + y;
	SetResultValue(result);
}

The script above gives me the following message in the GZDoom console:

P_StartScript: Unknown script 2
Value : 0

Interestingly - also it can't call the script, even says it is unknown - it is able to identify that "test2" is actually the 2nd script.
Also the checks of the Script Editor in the Ultimate Doom Editor says that the above script is valid (but maybe it simply due to the fact that it's checks don't cover such a case ).

Any thoughts on this?

[CoderGrizzly]

Okay, I take everything back about ACS_Execute. It also doesn't support named script and gives exactly the same error message.
Somehow I thought it would support it... Anyway, then I extend my report to all execution functions.

[Enjay]

All the ACS_* commands have named execute alternatives. e.g. ACS_NamedExecute, ACS_NamedExecuteWithResult and so on. Does that cover what you need?

https://zdoom.org/wiki/Category:ACS_Script_functions

[CoderGrizzly]

All the ACS_* commands have named execute alternatives. e.g. ACS_NamedExecute, ACS_NamedExecuteWithResult and so on. Does that cover what you need?

https://zdoom.org/wiki/Category:ACS_Script_functions

I'm sorry, I'm so dump.
Yeah, those functions are even one of the first Built-in ACS functions.
Very embarrassing... Guess I was fighting my other problems so much, I somehow didn't see it.

But anyway, thanks @Enjay a lot. Much appreciated.