There have been several pull requests for ACS extensions recently, and they all share the same problem: They only contain the changes needed on ZDoom's side, but nothing on ACC's side.
Please note that I will not add any such request unless it is either accompanied by a corresponding request for the ACC repo or some info what to add - even if it's supposedly trivial and obvious there's still stuff that can be missed and render the submitted feature inoperable.
Regarding pull requests for ACS features
Moderator: GZDoom Developers
-
- Lead GZDoom+Raze Developer
- Posts: 49182
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
-
- Posts: 555
- Joined: Thu Aug 06, 2009 4:00 am
- Location: Finland
Re: Regarding pull requests for ACS features
Hm? My change doesn't need any changes to ACC since it's a change on how a parameter is interpreted.
-
- Lead GZDoom+Raze Developer
- Posts: 49182
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: Regarding pull requests for ACS features
Ok, but please mention such a thing next time, just in case. I thought it required an extension to the function table.