[ZSCRIPT] [SOLVED] My reloadable weapon locks up my PC for no reason.

[yum13241]

The Weapon:

---

Class ZSBattleRifle : ZMonstrousWeapon { Default { Obituary "$OB_BATTLERIFLE"; Tag "$TAG_BATTLERIFLE"; Weapon.SelectionOrder 650; Weapon.SlotNumber 4; Weapon.AmmoUse1 1; Weapon.AmmoGive1 1; Weapon.AmmoType1 "MWBRMag"; Weapon.AmmoType2 "Clip"; } States { Select: UACR A 1 A_Raise; TNT1 A 0 A_Raise; Loop; Deselect: UACR A 1 A_Lower; TNT1 A 0 A_Lower; Loop; Ready: UACR A 1 A_WeaponReady(WRF_ALLOWRELOAD); Loop; Fire: TNT1 A 0 A_FireProjectile(); //SLADE complains about A_CheckReload(); TNT1 A 0 A_StartSound("weapons/battlerifleattack", CHAN_ITEM); TNT1 A 0 A_GunFlash(); UACR Y 1 A_FireBullets(5, 0, 1, 10, "BulletPuff") ; UACR A 1 A_Refire("Hold"); Hold: TNT1 A 0 A_GunFlash(); UACR Z 1 A_FireBullets(5, 0, 1, 10, "BulletPuff") ; UACR A 1 A_Refire("Fire"); Goto Ready; Reload: TNT1 A 0 A_FireProjectile(); UACR N 2; UACR O 2; UACR P 2; TNT1 A 0 A_StartSound("weapons/battlerifleunload", CHAN_ITEM); UACR Q 2; UACR R 8; UACR S 2; UACR T 2; UACR U 2; TNT1 A 0 A_StartSound("weapons/battlerifleload", CHAN_ITEM); UACR K 3; UACR L 5; UACR M 3; UACR A 6; TNT1 A 0 A_StartSound("weapons/battleriflecock", CHAN_ITEM); Goto Ready; Flash: TNT1 A 1 A_Light1; TNT1 A 1 A_Light2; Goto LightDone; Spawn: UACR X -1; Stop; } }

ZMonstrousWeapon:

---

Class ZMonstrousWeapon : Weapon //"reloading" by phantombeta { Default { Weapon.BobStyle "Inverse"; } States { /* Reload: TNT1 A 0 { if (CheckInventory (invoker.ammoType1, 0) || !CheckInventory (invoker.ammoType2, 1)) return ResolveState ("Ready"); int ammoAmount = min (FindInventory (invoker.ammoType1).maxAmount - CountInv (invoker.ammoType1), CountInv (invoker.ammoType2)); if (ammoAmount <= 0) return ResolveState ("Ready"); GiveInventory (invoker.ammoType1, ammoAmount); TakeInventory (invoker.ammoType2, ammoAmount); return ResolveState ("ReloadFinish"); }*/ } }
I commented out the "reloading" code in an effort to squash the bug, but it still happens.

The game just freezes, then ZMusic breaks (it plays the same notes over and over), then I have to hard reset the computer. I don't have any states with 0-duration frames only anywhere! Firing the gun and "reloading" the gun all trigger this bug.

SOLUTION: (replace Stop; with Goto Ready; in NoAmmo:)
ZSBattleRifle:

---

Class ZSBattleRifle : ZMonstrousWeapon { Default { Obituary "$OB_BATTLERIFLE"; Tag "$TAG_BATTLERIFLE"; Weapon.SelectionOrder 650; Weapon.SlotNumber 4; Weapon.AmmoUse1 1; Weapon.AmmoGive1 1; Weapon.AmmoType1 "MWBRMag"; Weapon.AmmoType2 "Clip"; } States { NoAmmo: UACR A 1 A_CheckReload(); Goto Ready; Select: UACR A 1 A_Raise; TNT1 A 0 A_Raise; Loop; Deselect: UACR A 1 A_Lower; TNT1 A 0 A_Lower; Loop; Ready: TNT1 A 0 A_JumpIfNoAmmo("NoAmmo"); UACR A 1 A_WeaponReady(WRF_ALLOWRELOAD); Loop; Fire: TNT1 A 0 A_JumpIfNoAmmo("NoAmmo"); TNT1 A 0 A_StartSound("weapons/battlerifleattack", CHAN_ITEM); TNT1 A 0 A_GunFlash(); UACR Y 1 A_FireBullets(5, 0, 1, 10, "BulletPuff") ; UACR A 1 A_Refire("Hold"); Hold: TNT1 A 0 A_GunFlash(); UACR Z 1 A_FireBullets(5, 0, 1, 10, "BulletPuff") ; UACR A 1 A_Refire("Fire"); Goto Ready; ReloadFinish: TNT1 A 0 A_JumpIfNoAmmo("Ready"); UACR N 2; UACR O 2; UACR P 2; TNT1 A 0 A_StartSound("weapons/battlerifleunload", CHAN_ITEM); UACR Q 2; UACR R 8; UACR S 2; UACR T 2; UACR U 2; TNT1 A 0 A_StartSound("weapons/battlerifleload", CHAN_ITEM); UACR K 3; UACR L 5; UACR M 3; UACR A 6; TNT1 A 0 A_StartSound("weapons/battleriflecock", CHAN_ITEM); Goto Ready; Flash: TNT1 A 1 A_Light1; TNT1 A 1 A_Light2; Goto LightDone; Spawn: UACR X -1; Stop; } }
ZMonstrousWeapon is the same.

---

The problem happened AGAIN! It freezes in the ready state, locking up my PC.

ZSBattleRifle:

---

Class ZSBattleRifle : ZMonstrousWeapon { Default { Obituary "$OB_BATTLERIFLE"; Tag "$TAG_BATTLERIFLE"; Weapon.SelectionOrder 650; Weapon.SlotNumber 4; Weapon.AmmoUse1 1; Weapon.AmmoGive1 1; Weapon.AmmoType1 "BRAmmo"; Weapon.AmmoType2 "Clip"; } States { NoAmmo: UACR A 1 A_CheckReload(); Goto Ready; Select: UACR A 1 A_Raise; TNT1 A 0 A_Raise; Loop; Deselect: UACR A 1 A_Lower; TNT1 A 0 A_Lower; Loop; Ready: UACR A 1 A_WeaponReady(WRF_ALLOWRELOAD); UACR A 1 A_JumpIfNoAmmo("NoAmmo"); Loop; Fire: TNT1 A 0 A_JumpIfNoAmmo("NoAmmo"); TNT1 A 0 A_StartSound("weapons/battlerifleattack", CHAN_ITEM); TNT1 A 0 A_GunFlash(); UACR Y 1 A_FireBullets(5, 0, 1, 10, "BulletPuff") ; UACR A 1 A_Refire("Hold"); Goto Ready; //this is probably the only line that's different. Hold: TNT1 A 0 A_GunFlash(); UACR Z 1 A_FireBullets(5, 0, 1, 10, "BulletPuff") ; UACR A 1 A_Refire("Fire"); Goto Ready; ReloadFinish: TNT1 A 0 A_JumpIfNoAmmo("Ready"); UACR N 2; UACR O 2; UACR P 2; TNT1 A 0 A_StartSound("weapons/battlerifleunload", CHAN_ITEM); UACR Q 2; UACR R 8; UACR S 2; UACR T 2; UACR U 2; TNT1 A 0 A_StartSound("weapons/battlerifleload", CHAN_ITEM); UACR K 3; UACR L 5; UACR M 3; UACR A 6; TNT1 A 0 A_StartSound("weapons/battleriflecock", CHAN_ITEM); Goto Ready; Flash: TNT1 A 1 A_Light1; TNT1 A 1 A_Light2; Goto LightDone; Spawn: UACR X -1; Stop; } }

My guess is that the game goes to Ready, then it goes to NoAmmo and so on, but I HAVE AMMO when it freezes! What's going on!?

[Jarewill]

A_FireProjectile needs the first argument to work, I didn't know ZScript would even compile without it.
That's also not the right way to check for valid ammunition, use A_JumpIfInventory instead.
Also your Reload state in your custom weapon class won't work, because it's being overridden by the weapon that inherits from it.

[yum13241]

I know, I would have renamed it to ReloadFinish had I not commented out the code.
SLADE says the following for A_CheckReload: Deprecated, use A_FireProjectile();

Anyways, I'll try using A_JumpIfNoAmmo and report back.
---
EDIT: Back now, and my PC locked up again.

ZSBattleRifle:

---

Class ZSBattleRifle : ZMonstrousWeapon { Default { Obituary "$OB_BATTLERIFLE"; Tag "$TAG_BATTLERIFLE"; Weapon.SelectionOrder 650; Weapon.SlotNumber 4; Weapon.AmmoUse1 1; Weapon.AmmoGive1 1; Weapon.AmmoType1 "MWBRMag"; Weapon.AmmoType2 "Clip"; } States { NoAmmo: UACR A 0 A_CheckReload(); Stop; Select: UACR A 1 A_Raise; TNT1 A 0 A_Raise; Loop; Deselect: UACR A 1 A_Lower; TNT1 A 0 A_Lower; Loop; Ready: TNT1 A 0 A_JumpIfNoAmmo("NoAmmo"); UACR A 1 A_WeaponReady(WRF_ALLOWRELOAD); Loop; Fire: TNT1 A 0 A_JumpIfNoAmmo("Ready"); TNT1 A 0 A_StartSound("weapons/battlerifleattack", CHAN_ITEM); TNT1 A 0 A_GunFlash(); UACR Y 1 A_FireBullets(5, 0, 1, 10, "BulletPuff") ; UACR A 1 A_Refire("Hold"); Hold: TNT1 A 0 A_GunFlash(); UACR Z 1 A_FireBullets(5, 0, 1, 10, "BulletPuff") ; UACR A 1 A_Refire("Fire"); Goto Ready; ReloadFinish: TNT1 A 0 A_JumpIfNoAmmo("Ready"); UACR N 2; UACR O 2; UACR P 2; TNT1 A 0 A_StartSound("weapons/battlerifleunload", CHAN_ITEM); UACR Q 2; UACR R 8; UACR S 2; UACR T 2; UACR U 2; TNT1 A 0 A_StartSound("weapons/battlerifleload", CHAN_ITEM); UACR K 3; UACR L 5; UACR M 3; UACR A 6; TNT1 A 0 A_StartSound("weapons/battleriflecock", CHAN_ITEM); Goto Ready; Flash: TNT1 A 1 A_Light1; TNT1 A 1 A_Light2; Goto LightDone; Spawn: UACR X -1; Stop; } }

ZMonstrousWeapon is the same but the reload code is uncommented.

And the same thing happens. I fire, which works fire, but then I release fire, which then locks up GZDoom, which proceeds to lock up my PC. (can't even alt + tab, no TTY, nothing)

[wildweasel]

There's some zero-duration stuff going on between the NoAmmo, Ready, and Fire states that seems like it could throw gzdoom into an infinite busy-loop. Just to make sure, try giving the NoAmmo state a duration of 1. Also, I'm not sure you're supposed to end a weapon state with Stop, but I don't know what you should do instead there...

[yum13241]

It'd be nice if GZDoom yelled at me if all the durations in a state are 0. Why there isn't a Runaway State Terminated thing like in ACS is beyond me.

I'll change the NoAmmo state duration to be 1.


EDIT: nope, my PC locks up when I release fire. I changed the line in the NoAmmo State to have a duration of 1, and changed the A_JumpIfNoAmmo calls to jump to NoAmmo directly (gotta cut out the middleman) and I still have it lock up my PC. (I can't even kill it fast enough)

Solution is now in the original post. Why do I feel stupid now?


ZSBattleRifle:

---

Class ZSBattleRifle : ZMonstrousWeapon { Default { Obituary "$OB_BATTLERIFLE"; Tag "$TAG_BATTLERIFLE"; Weapon.SelectionOrder 650; Weapon.SlotNumber 4; Weapon.AmmoUse1 1; Weapon.AmmoGive1 1; Weapon.AmmoType1 "MWBRMag"; Weapon.AmmoType2 "Clip"; } States { NoAmmo: UACR A 1 A_CheckReload(); Stop; Select: UACR A 1 A_Raise; TNT1 A 0 A_Raise; Loop; Deselect: UACR A 1 A_Lower; TNT1 A 0 A_Lower; Loop; Ready: TNT1 A 0 A_JumpIfNoAmmo("NoAmmo"); UACR A 1 A_WeaponReady(WRF_ALLOWRELOAD); Loop; Fire: TNT1 A 0 A_JumpIfNoAmmo("NoAmmo"); TNT1 A 0 A_StartSound("weapons/battlerifleattack", CHAN_ITEM); TNT1 A 0 A_GunFlash(); UACR Y 1 A_FireBullets(5, 0, 1, 10, "BulletPuff") ; UACR A 1 A_Refire("Hold"); Hold: TNT1 A 0 A_GunFlash(); UACR Z 1 A_FireBullets(5, 0, 1, 10, "BulletPuff") ; UACR A 1 A_Refire("Fire"); Goto Ready; ReloadFinish: TNT1 A 0 A_JumpIfNoAmmo("Ready"); UACR N 2; UACR O 2; UACR P 2; TNT1 A 0 A_StartSound("weapons/battlerifleunload", CHAN_ITEM); UACR Q 2; UACR R 8; UACR S 2; UACR T 2; UACR U 2; TNT1 A 0 A_StartSound("weapons/battlerifleload", CHAN_ITEM); UACR K 3; UACR L 5; UACR M 3; UACR A 6; TNT1 A 0 A_StartSound("weapons/battleriflecock", CHAN_ITEM); Goto Ready; Flash: TNT1 A 1 A_Light1; TNT1 A 1 A_Light2; Goto LightDone; Spawn: UACR X -1; Stop; } }
ZMonstrousWeapon is the same.

How to annoy a person:

---

1. make a mod with a zero duration state
2. set GZDoom to autostart to load that mod and warp to map01.
3. enjoy!
4. DONT DO THIS!11!!!eleven

ZScript is hard sometimes. EDIT: AHA! I was using Stop; in NoAmmo:! Why GZDoom locks up instead of just bombing out is beyond me. Anyways I replaced it with Goto Ready;and it works like a charm! Now to balance the thing... And the weirdest part is I thought of that when I was playing Geometry Dash of all things.

EDIT 2: It broke again, Goto OP;

[Blue Shadow]

SLADE says the following for A_CheckReload:
Deprecated, use A_FireProjectile();

That's a problem with SLADE and deprecation notes, which I just reported.

Obviously, A_CheckReload and A_FireProjectile have totally different functionalities. You can't substitute one for the other.

[yum13241]

Hate to bump, but it was an issue in a powerup I made. I used if (!null) instead of if (toucher). My bad.