[SOLVED] My powerup isn't going into the inventory when a player already has one.

[yum13241]

PowerGunsAkimbo

---

ACTOR PowerGunsAkimbo : PowerWeaponLevel2 { Powerup.Duration 0x7FFFFFFD //~2 years of guns akimbo. Inventory.MaxAmount 3 Tag "$TAG_GUNSAKIMBO" //Inventory.Icon "AKIMA0" }

GunsAkimbo

---

ACTOR GunsAkimbo : CustomInventory { +COUNTITEM +INVENTORY.AUTOACTIVATE +INVENTORY.BIGPOWERUP +INVENTORY.ALWAYSPICKUP +DONTGIB +IGNORESKILL Inventory.MaxAmount 3 Inventory.PickupSound "misc/p_pkup" Inventory.PickupMessage "$TXT_GUNSAKIMBO" Tag "$TAG_GUNSAKIMBO" States { Spawn: AKIM A -1 Stop Pickup: TNT1 A 0 A_GiveInventory("Clip", 50) TNT1 A 0 A_GiveInventory("PowerGunsAkimbo") Stop Use: TNT1 A 0 A_GiveInventory("PowerGunsAkimbo") Stop } }

I want the CustomInventory item to be used instantly if the player hasn't picked up one on the map they are playing (the powerup lasts forever [OK, 2 years]) but I want the player to have it in their inventory for later use. (w/o giving clips) The problem is that it always gets activated. Since this is an addon for a mod I'm making, ZScript should be fine, since I'm not modifying an existing DECORATE actor. Maybe using the bFLAGNAME feature of ZScript?


SOLUTION: See Ac!d's post.

[Ac!d]

I remade your powerup in Zscript. Two lines are commented in order to prevent an automatic activation and the risk of waste.

Code: Select all

// ZScript
version "4.6.1"

Class PowerGunsAkimbo : PowerupGiver
{
	Default
	{
		Inventory.Amount 1;
		Inventory.MaxAmount 3;
		Inventory.InterHubAmount 3;
		Inventory.PickupSound "misc/p_pkup";
		Inventory.PickupMessage "$TXT_GUNSAKIMBO";
		Tag "$TAG_GUNSAKIMBO";
		
		+INVENTORY.INVBAR
		+INVENTORY.COUNTITEM
		//+INVENTORY.AUTOACTIVATE
		+INVENTORY.BIGPOWERUP
		//+INVENTORY.ALWAYSPICKUP

		Powerup.Type "PowerWeaponLevel2";
		Powerup.Duration 0x7FFFFFFD;
	}
	Override Bool TryPickup(In Out Actor toucher)
	{
		If(toucher && toucher.CountInv(self.GetClass()) < 3) // Prevent to pick it up if we have 3 times this item
		{
			toucher.A_GiveInventory("Clip", 50);
			Return Super.TryPickup(toucher);
		}
		Return False;
	}
        States
	{
        Spawn:
		AKIM A -1;
		Stop;
	}
}

[Jarewill]

Your CustomInventory actor isn't being added to the inventory because you have the +AUTOACTIVATE flag set.
This means that it will run its Use state the moment it's added.
To fix this, you can try adding a conditional check in your Use state, like so:

Code: Select all

Use:
 TNT1 A 0 A_JumpIfInventory("PowerGunsAkimbo",1,"UseFail")
 TNT1 A 0 A_GiveInventory("PowerGunsAkimbo")
 Stop
UseFail:
 TNT1 A 0
 Fail

You might also need to remove giving the powerup in the Pickup state.

[yum13241]

I remade your powerup in Zscript. Two lines are commented in order to prevent an automatic activation and the risk of waste.

Code: Select all

// ZScript
version "4.6.1"

Class PowerGunsAkimbo : PowerupGiver
{
	Default
	{
		Inventory.Amount 1;
		Inventory.MaxAmount 3;
		Inventory.InterHubAmount 3;
		Inventory.PickupSound "misc/p_pkup";
		Inventory.PickupMessage "$TXT_GUNSAKIMBO";
		Tag "$TAG_GUNSAKIMBO";
		
		+INVENTORY.INVBAR
		+INVENTORY.COUNTITEM
		//+INVENTORY.AUTOACTIVATE
		+INVENTORY.BIGPOWERUP
		//+INVENTORY.ALWAYSPICKUP

		Powerup.Type "PowerWeaponLevel2";
		Powerup.Duration 0x7FFFFFFD;
	}
	Override Bool TryPickup(In Out Actor toucher)
	{
		If(toucher && toucher.CountInv(self.GetClass()) < 3) // Prevent to pick it up if we have 3 times this item
		{
			toucher.A_GiveInventory("Clip", 50);
			Return Super.TryPickup(toucher);
		}
		Return False;
	}
        States
	{
        Spawn:
		AKIM A -1;
		Stop;
	}
}

Why does GZDoom error out saying +INVENTORY.COUNTITEM doesn't exist?

[Jarewill]

That's because +COUNTITEM is a general flag, so it should be used without a prefix.
So it should be just +COUNTITEM.

[yum13241]

Thanks!