Clearscope For Actor.ApplyDamageFactor

[RaveYard]

I kinda need this and I've looked into the source and I don't see any reason why this function in Actor can't be clearscope.

Code: Select all

native int ApplyDamageFactor(Name damagetype, int damage);

[Rachael]

Why do you need it to be clearscope? What exactly is it you are trying to do?

[Gez]

Clearscope functions are functions that do not have an impact on the gameplay. They're math operations and simple information getters. From the wiki description of [wiki]ApplyDamageFactors[/wiki], it seems it'd be safe, since all it does is compute a value, i.e. it applies damage factors to a damage value, but it does not apply damage to the actor. If it has no undocumented side effects, it'd be fine. Could be used for things such as VATS-like previewing how much damage an attack would inflict on a target, for example.

[RaveYard]

That's what I'm trying to do. I want to do an indicator of how much damage you'll deal with specific damage type.

[Graf Zahl]

It's marked 'const' so yes, it will be safe.

[Rachael]

Done

[Blue Shadow]

Note that there is ApplyDamageFactor (singular) and ApplyDamageFactors (plural). The change was made to the latter (plural), while the OP is requesting to change the former (singular).

[RaveYard]

Yes, I happen to be using the former. Should I ask again?

[Rachael]

No I will simply reopen this. But I don't have time to do this right now. I'll get to it later if someone doesn't beat me to it.