[0.7.1-0.7.2] [SW] Mounting vehicles locks player direction

[Esrael]

When mounting vehicles in Shadow Warrior, there's a chance the game will lock your facing to the direction the vehicle was facing when you mounted the vehicle.

You can try to pan your view and turn the vehicle, but the view and the vehicle are forced back to the direction the vehicle was originally facing at the time of mounting. Tilting the camera still works at this state.

When you unmount the vehicle, the player's direction still remains locked. The only way I know of how to free the camera is to mount the vehicle again.

E1L2 (Zilla's Construction) is a good map for demonstrating the bug. You can increase your chances of producing the bug by moving and looking around inside the stationary rocket launcher vehicle and then mounting the vehicle while looking at the right inner wall of the vehicle.

The bug also occurs with the forklight, but it's less noticeable because you can still rotate the vehicle. The bug becomes apparent, however, when you unmount the vehicle and try to rotate yourself.

[sinisterseed]

Ugh, this was supposed to be fixed in 7.2. The vehicles in SW are quite a fiddly thing to mess with.

This time around though, I've not been able to reproduce the broken behavior. All is fine from my testing just now. So I must ask, did you keep the files from 7.1 and just tossed 7.2 over them, keeping the old config in the process? That would be a sure fire method to break it again, and if so, I suggest starting fresh.

[Esrael]

I just installed 0.7.2 in a completely fresh folder, and the bug still persists at least partially. I figured out a reliable way to reproduce it. I'll share a video on how I did it: https://www.dropbox.com/s/dlywo6bfl6hcj ... 7.mp4?dl=0

Reproduction instructions:
- Your vehicle needs to be facing the courtyard
- You have to be looking at the right wall of the vehicle, the right half of the back wall or the right half of the floor
- Your mouse needs to be in motion while pressing the use key. (In the video you can see, how during my second mounting the bug didn't occur, because I was standing still while pressing the use key.)

Granted, quite a few prerequisites need to be fulfilled for the bug to be reproduced, so I guess you could consider the current fix good enough. At least the direction lock doesn't persist anymore, when the player unmounts the vehicle.

[mjr4077au]

On the initial setup of sector objects or ladders, there's an adjustment method on the player's angle object to set target to the required angle. On ladders, this ensures the angle becomes what it should but for items we the user can look left/right and fight the targeting, it can cause issues.

The original behaviour just forced the player's angle to be what it needed to be, so for sector objects this is what I've just pushed to master. What was there was meant to be better but corner cases like this mean something else needs to be done.

Thanks again for all of your excellent bug reports, they're all going towards making the games better and better with each coming version