[SOLVED FR] I want to change how the expire sound is played

[yum13241]

PowerDamage4

---

Class PowerDamage4 : PowerDamage { Default { Powerup.Color "Purple", 0.25; DamageFactor "Normal", 4; Inventory.Icon "QUADA0"; DeathSound "powerups/4expire"; SeeSound "powerups/4equip"; Powerup.Duration -35; //negative numbers mean seconds, positive mean ticks! +INVENTORY.ADDITIVETIME } }

Damage4

---

Class Damage4 : PowerUpGiver { Default { Inventory.Amount 1; Inventory.MaxAmount 1; Inventory.InterHubAmount 1; Inventory.PickupSound "powerups/4equip"; Inventory.PickupMessage "$TXT_GOTQUAD"; +COUNTITEM +INVENTORY.AUTOACTIVATE +INVENTORY.BIGPOWERUP +INVENTORY.ALWAYSPICKUP +INVENTORY.ADDITIVETIME Powerup.Type "PowerDamage4"; Powerup.Duration -35; } Override Bool TryPickup(In Out Actor toucher) { If(toucher && toucher.CountInv(self.GetClass()) < 999) // Prevent to pick it up if we have 999 times this item { toucher.GiveBody(100,0); Return Super.TryPickup(toucher); } Return False; } States { Spawn: QUAD ABCDEFEDCBA 4; Loop; } }

Right now the Powerup.Expire sound plays AFTER the powerup finishes blinking. (it actually expires)

I want it to play WHILE it's blinking. Is this possible?

SOLUTION: See BlueShadows''s post.

[Blue Shadow]

viewtopic.php?p=1222796#p1222796

[yum13241]

This just errors out with Unexpected Character: ? (ASCII -62)

---

Class PowerDamage4 : PowerDamage { Default { Powerup.Color "Purple", 0.25; DamageFactor "Normal", 4; Inventory.Icon "QUADA0"; DeathSound "powerups/4expire"; SeeSound "powerups/4equip"; Powerup.Duration -35; //negative numbers mean seconds, positive mean ticks! +INVENTORY.ADDITIVETIME } override void DoEffect ()     {         Super.DoEffect();         if (Owner && EffectTics > 0 && EffectTics <= BLINKTHRESHOLD)         {             Owner.A_StartSound("misc/powerups/4expire", CHAN_5, CHANF_NOSTOP, 1.0, ATTN_NONE);         } } }

Where's my problem?

[Jarewill]

I have honestly no idea what caused this problem, but when I rewrote your code from scratch it worked fine:

---

Code: Select all

Class PowerDamage4 : PowerDamage
{
	Default
	{
		Powerup.Color "Purple", 0.25;
		DamageFactor "Normal", 4;
		Inventory.Icon "QUADA0";
		DeathSound "powerups/4expire";
		SeeSound "powerups/4equip";
		Powerup.Duration -35;
		+INVENTORY.ADDITIVETIME;
	}
	Override void DoEffect()
	{
		Super.DoEffect();
		If(owner && EffectTics > 0 && EffectTics <= BLINKTHRESHOLD)
		{
			owner.A_StartSound("misc/powerups/4expire",CHAN_5,CHANF_NOSTOP,1.0,ATTN_NONE);
		}
	}
}

Maybe some invisible character somewhere messed with the compiler?

[yum13241]

Thanks! For future readers: Make sure to comment out the DeathSound.

HOLD UP! Even though I set the DeathSound to "dsempty" the expire sound now plays twice; once while it's blinking, and another time when it's actually gone.

PowerDamage4

---

Class PowerDamage4 : PowerDamage { Default { Powerup.Color "Purple", 0.25; DamageFactor "Normal", 4; Inventory.Icon "QUADA0"; SeeSound "powerups/4equip"; Powerup.Duration -35; DeathSound "dsempty"; +INVENTORY.ADDITIVETIME; } Override void DoEffect() { Super.DoEffect(); If(owner && EffectTics > 0 && EffectTics <= BLINKTHRESHOLD) { owner.A_StartSound("powerups/4expire",CHAN_5,CHANF_NOSTOP,1.0,ATTN_NONE); } } }

Damage4

---

Class Damage4 : PowerUpGiver { Default { Inventory.Amount 1; Inventory.MaxAmount 1; Inventory.InterHubAmount 1; Inventory.PickupSound "powerups/4equip"; Inventory.PickupMessage "$TXT_GOTQUAD"; +COUNTITEM +INVENTORY.AUTOACTIVATE +INVENTORY.BIGPOWERUP +INVENTORY.ALWAYSPICKUP +INVENTORY.ADDITIVETIME Powerup.Type "PowerDamage4"; Powerup.Duration -35; } Override Bool TryPickup(In Out Actor toucher) { If(!null) { toucher.GiveBody(100,0); Return Super.TryPickup(toucher); } Return False; } States { Spawn: QUAD ABCDEFEDCBA 4; Loop; } }

[Blue Shadow]

HOLD UP! Even though I set the DeathSound to "dsempty" the expire sound now plays twice; once while it's blinking, and another time when it's actually gone.

The code was written so that the sound plays repeatedly through out the expiration period, not just once. So if your sound is shorter than 4 seconds or so, then it'll play more than once.

[yum13241]

Is it possible to change that?

[Blue Shadow]

This should do it.

Code: Select all

Class PowerDamage4 : PowerDamage
{
	private bool soundplayed;

	Default
	{
		Powerup.Color "Purple", 0.25;
		DamageFactor "Normal", 4;
		Inventory.Icon "QUADA0";
		SeeSound "powerups/4equip";
		Powerup.Duration -35;
		DeathSound "dsempty";
		+INVENTORY.ADDITIVETIME;
	}

	override bool HandlePickup (Inventory item)
	{
		int savedEffectTics = EffectTics; // Save the powerup's current duration before handling the pickup.
		bool res = Super.HandlePickup(item);

		// Only allow the sound to be replayed if the powerup's duration changed to be greater than before,
		// while at the same time, the new duration is greater than the blinking threshold (we don't want
		// the sound to be replayed if the powerup is still expiring with the new duration).
		if (res && EffectTics > savedEffectTics && EffectTics > BLINKTHRESHOLD)
		{
			soundplayed = false;
		}

		return res;
	}

	Override void DoEffect()
	{
		Super.DoEffect();
		If(!soundplayed && owner && EffectTics > 0 && EffectTics <= BLINKTHRESHOLD)
		{
			owner.A_StartSound("powerups/4expire",CHAN_5,CHANF_NOSTOP,1.0,ATTN_NONE);
			soundplayed = true;
		}
	}
}

[yum13241]

One blink passes by w/o any sound but this is all I can do. Btw the sound is the Quad Damage expiration sound. Oh well.