VM Abort: Address Zero in gzdoom.pk3

[stainedofmind]

Ran into a VM Abort: Tried to read from address zero while testing some mods, and while I'm certain it was one of the mods that caused the issue, it only opened the door to allow this error to happen, specifically, on line 256, "target" is not being check for existence before being used.

Screenshot of error:

[Marisa the Magician]

I think I've tracked down the potential source of the problem:

Code: Select all

AActor *P_SpawnSubMissile(AActor *source, PClassActor *type, AActor *target)
{
	AActor *other = Spawn(source->Level, type, source->Pos(), ALLOW_REPLACE);

	if (source == nullptr || type == nullptr)
	{
		return nullptr;
	}

	other->target = target;
	other->Angles.Yaw = source->Angles.Yaw;
	other->VelFromAngle();

	if (other->flags4 & MF4_SPECTRAL)
	{
		if (source->flags & MF_MISSILE && source->flags4 & MF4_SPECTRAL)
		{
			other->FriendPlayer = source->FriendPlayer;
		}
		else
		{
			other->SetFriendPlayer(target->player);
		}
	}

	if (P_CheckMissileSpawn(other, source->radius))
	{
		DAngle pitch = P_AimLineAttack(source, source->Angles.Yaw, 1024.);
		other->Vel.Z = -other->Speed * pitch.Sin();
		return other;
	}
	return NULL;
}

P_SpawnSubMissile doesn't seem to have a null check for target before that call to SetFriendPlayer

[Graf Zahl]

fixed