writeini clears binds from currently loaded mods

[Marisa the Magician]

Using the writeini command (and by extension "Save current settings" in the options menu) appears to clear the bindings of any loaded mod that uses addkeysection in KEYCONF.

[Marisa the Magician]

Updating this, because "Browse Game Config" causes the same issue as well.

[phantombeta]

One important detail to note is that the binds are only cleared in-game- They are indeed saved correctly to the INI, they just get wiped from the game in the process. (Then consequently get wiped from the INI too once you close the game)
The "Browse Game Config" option causes this because it also saves the game.
Some quick investigation points to ArchiveBindings as the likely culprit for this bug. The comment right before it also kinda points to that being the case:

Code: Select all

//=============================================================================
//
// This function is first called for functions in custom key sections.
// In this case, matchcmd is non-null, and only keys bound to that command
// are stored. If a match is found, its binding is set to "\1".
// After all custom key sections are saved, it is called one more for the
// normal Bindings and DoubleBindings sections for this game. In this case
// matchcmd is null and all keys will be stored. The config section was not
// previously cleared, so all old bindings are still in place. If the binding
// for a key is empty, the corresponding key in the config is removed as well.
// If a binding is "\1", then the binding itself is cleared, but nothing
// happens to the entry in the config.
//
//=============================================================================

The origin of this code is this commit from... 2009.
How has this bug never been reported and/or fixed during those 13+ years? O_o

[Graf Zahl]

My head hurts. I'm sorry but someone else needs to have a look here.

[Casualfan]

Saw this while playing Aliens Eradication yesterday. GZDoom wasn't saving my resolution settings, but I noticed a Save Settings button in the main menu. I hit it and it saved all my GZDoom settings, but for some reason it cleared all my keybinds set for Aliens Eradication. Not a catastrophic event, but it got me real confused for a bit. Please let me know if I need to provide more info, I'm new to this whole bug reporting thing haha.

[Player701]

Looks like a duplicate of this report.

[Rachael]

I've gone ahead and merged it.