Request to deprecate/remove EventHandlers in GameInfo

Moderator: GZDoom Developers

User avatar
Marisa the Magician
 
 
Posts: 3802
Joined: Fri Feb 08, 2008 9:15 am
Discord: Marisa the Magician#1666
Twitch ID: MarisaDOOM
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia

Request to deprecate/remove EventHandlers in GameInfo

Post by Marisa the Magician »

The use of this property in the GameInfo block instead of AddEventHandlers has caused me enough frustration with hard to debug issues that people report when loading multiple mods. I don't think a footnote in the wiki about the dangers of its misuse is helping much in this case.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 47976
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Request to deprecate/remove EventHandlers in GameInfo

Post by Graf Zahl »

I'd silently change it to act the same as addEventHandlers, so that the old mods continue to work but don't remove previous handlers.
User avatar
Marisa the Magician
 
 
Posts: 3802
Joined: Fri Feb 08, 2008 9:15 am
Discord: Marisa the Magician#1666
Twitch ID: MarisaDOOM
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia

Re: Request to deprecate/remove EventHandlers in GameInfo

Post by Marisa the Magician »

That is a reasonable change as well, thank you.
User avatar
m8f
 
 
Posts: 1392
Joined: Fri Dec 29, 2017 4:15 am
Discord: m8f#0629
Github ID: mmaulwurff
Operating System: Other Linux 64-bit
Location: Siberia (UTC+7)

Re: Request to deprecate/remove EventHandlers in GameInfo

Post by m8f »

Oddly enough, this was No'ed before: viewtopic.php?f=18&t=71426

Anyway, great to have it finally done. Thanks!

Return to “Closed Feature Suggestions”