ACS: APROP_SoundClass

Tue Mar 09, 2021 11:37 am

https://github.com/coelckers/gzdoom/pull/1333

Hey all, this is my first new feature I have created for GZDoom/Zandronum. I'm very new to C++, but I needed a feature for my mod, so I've developed this extension to SetActorProperty, GetActorProperty, and CheckActorProperty for both ports. So, what is this?

APROP_SoundClass is an extension to SetActorProperty, GetActorProperty, and CheckActorProperty which will allow manipulation of a player class's sound class. The use I have for this is for changing the sound class of a player under conditions where additional player pawns or skins are simply not viable. Could also be used to player aliases under very specific instances that otherwise can't be modified.

I added APROP_SoundClass at index 47 in zdefs.acs. I would attach it, but that's not allowed here.

Re: ACS: APROP_SoundClass

Tue Mar 09, 2021 12:12 pm

Please check my review in the PR.

Re: ACS: APROP_SoundClass

Tue Mar 09, 2021 12:52 pm

Applied the suggested changes to the PR.

Re: ACS: APROP_SoundClass

Thu Apr 15, 2021 3:43 pm

Hey, it's been awhile since any review. I went ahead and submitted a new pull request which fixes a lot of issues that I tested with various scenarios. Ultimately the code is more refined than it was before. Please check it when you have the chance.

Thanks.

Re: ACS: APROP_SoundClass

Fri May 28, 2021 11:46 am

Still waiting over a month for feedback on my latest changes, so gonna post here again.

Re: ACS: APROP_SoundClass

Fri May 28, 2021 12:22 pm

Sorry, I must have missed it.