[4.14] "Change Texture & Effect" dosn't transfer secret effect

[Blue Phoenix]

In other Boom ports having a voodoo doll cross a 153:W1 Change Texture and Effect copies secret effect to the tagged sector (without increasing total secrets).
I use this effect to make pulling a switch count as a secret.

[Rachael]

The actual transfer is done by 'void TransferSpecial' in p_sectors.cpp

Code: Select all

void TransferSpecial(sector_t *sector, sector_t *model)
{
	sector->special = model->special;
	sector->damageamount = model->damageamount;
	sector->damagetype = model->damagetype;
	sector->damageinterval = model->damageinterval;
	sector->leakydamage = model->leakydamage;
	sector->Flags = (sector->Flags&~SECF_SPECIALFLAGS) | (model->Flags & SECF_SPECIALFLAGS);
}

The offending code is in r_defs.h -

Code: Select all

gamedata/r_defs.h:      SECF_SPECIALFLAGS = SECF_DAMAGEFLAGS|SECF_FRICTION|SECF_PUSH|SECF_EXIT1|SECF_EXIT2|SECF_KILLMONSTERS,

I am not sure if it was intentional to omit the secret flag from this or not. I would need to know from either Marisa H or Graf what the most desired outcome for handling this would be.

[Graf Zahl]

This was intentional because one of Heretic's original maps has 2 sectors where this creates bad secrets. The change is also quite old so reverting it now will likely cause similar problems in some more recent maps.

[Rachael]

In that case there isn't really anything to do here then.