ACS_Terminate isn't terminating.

[Ceeb]

I have a script here that causes rapid, constant damage, and the only way I found to cancel it is fairly hacky. But it should still work. Here, it's easier to show what I'm talking about...

Code: Select all

script 98 (void) //Rapid lava damage
{
thing_damage2(1000,1,"Fire");
delay(2);
restart;
}

Using the Actor Hits Floor sector actions, this script it activated. As you can see, it damages the player (who I gave a TID of 1000 to in another script) with fire based damage incessantly. How do you stop this? Simple! Get back on non-magma ground.

Code: Select all

script 99 (void) //Script 98 terminator
{
acs_terminate(98,34);
}

...Where another Actor Hits Floor activates this script, which should kill script 98. It doesn't kill script 98. I've even tried puking script 99, and it doesn't work! I looked at the ACS_Terminate article, I double-checked everything, but nothing is wrong!

[dennisj1]

Is the second argument (34) the correct map number? Try passing zero (0), instead.

[Zhs2]

Is script 98 called by [wiki]ACS_ExecuteAlways[/wiki]? Scripts called by said command can NEVER be terminated with terminate or ACS_Terminate.

Try [wiki]ACS_Suspend[/wiki], perhaps?

[Pedro vc]

Probably the map number is wrong. Check it.

[Ceeb]

No, it was map 34. That was right. But changing that number to 0 made it work exactly as I intended!

[Zhs2]

Ah, yes... A good point to remember with the "map" argument of ACS_Execute and its variants is that 0 refers to the "activator" (or, activating map) of the script, much like 0 in an ActivatorTID arg refers to the actor that activated the script.

[Apothem]

Is script 98 called by [wiki]ACS_ExecuteAlways[/wiki]? Scripts called by said command can NEVER be terminated with terminate or ACS_Terminate.

Try [wiki]ACS_Suspend[/wiki], perhaps?

To compensate for that, add a statement that terminates the script internally via a flag. This also maintains MP compatibility...

[Ceeb]

Don't care about multi player, my WAD is strictly a single player adventure.