[4.9.0] Lullaby crashing in Win x64

[supinnah]

Hello friends

It was brought up over on Doomworld (https://www.doomworld.com/forum/topic/1 ... or-gzdoom/) that Lullaby is crashing the latest GZDoom. I can duplicate it pretty easily and wanted to submit a report.

To test:
- load up GZDoom 4.9.0 with doom2.wad and lullaby.pk3 from the link above
- start a new game, any difficulty
- leave the starting room and run around outside for a bit

It seems to happen when looking at the structure to the north, but not always. It should only take a few seconds. Most often for me, it's when I'm looking to the northeast.

It's not a clean GZDoom crash, so no report is generated. Windows Event Viewer indicates a crash with SYSTEM32\riched20.dll:

---

Faulting application name: gzdoom.exe, version: 4.9.0.0, time stamp: 0x6366aac8
Faulting module name: riched20.dll, version: 5.31.23.1231, time stamp: 0xc4b0f03c
Exception code: 0xc0000005
Fault offset: 0x0000000000051d62
Faulting process id: 0x56f0
Faulting application start time: 0x01d8f4fb91c66ccd
Faulting application path: D:\Program Files\Doom\GZDoom\gzdoom.exe
Faulting module path: C:\WINDOWS\SYSTEM32\riched20.dll
Report Id: 651b41c7-5ae1-4d0e-b907-6a1edc08c862
Faulting package full name:
Faulting package-relative application ID:

From testing the dev builds I've narrowed it down to g4.9pre-327 where it starts. The previous build seems to work fine.

specs:
Win11 21H2
i5-9600K CPU
24GB RAM
RTX 3070

Thanks!

[Graf Zahl]

There's something wrong with the portal setup, but I cannot exactly see what. It runs into an endless portal recursion and terminates with a stack overflow.

[KynikossDragonn]

Portals don't have a failsafe recursion limit? I saw a setting somewhere to determine how many recursions are allowed for mirrors, but I guess for portals that's something completely different.

[Rachael]

They do, I am guessing somehow the recurse counter is not being set? - or, checked?

[Graf Zahl]

The assumption was that stacked sectors would not cause recursion. It would be easier if it was trivially reproducable, but it only happens in very limited circumstances and the stack trace gets so long that analyzing where things go wrong is not that easy anymore.

[Dynamo]

Just wanted to report that, while the crash is fixed in 4.10.0, people are saying there are issues with the map on the 4.10.0 as well, namely the fact that the FPS is much lower than it was on 4.8.0.

[Graf Zahl]

That's most likely because I limited the portal recursions so that it cannot crash anymore. The underlying cause has not been fixed so it isn't really surprising.