GZDoom Builder 2.3

[NeuralStunner]

Implementing this correctly would require replicating ZDoom's behavior when moving things with +FIXMAPTHINGPOS flag out of the walls, then checking the resulting position.

I suppose so, since the fixed position could result in it being stuck somewhere else.

I'd be content if I could simply switch off actors-in-lines checking once I know errors found are not problematic. (Sometimes this kind of action is necessary, for example blank textures being used for rendering "cheats". The cell bars in Map31 are an example.)

Also I see you added poly checking code, unfortunately:

---

The given key was not present in the dictionary.
at System.ThrowHelper.ThrowKeyNotFoundException()
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at CodeImp.DoomBuilder.BuilderModes.CheckPolyobjects.Run() in x:\Source\Plugins\BuilderModes\ErrorChecks\CheckPolyobjects.cs:line 116
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()

This happened with a Doom format map. I'm not sure whether this had anything to do with it, but it seems worth a mention. (Would a good idea to disable this checking option for unsupported map format.)

[XCVG]

What about the Flip Linedef action bug I mentioned in the same post?

Works as expected. This action flips lines sector-wise, trying to match selected lines direction with overall sector direction.

Is this a new feature?

[NeuralStunner]

No, that's been in map editors for years.

[XCVG]

Ah, okay. The way the original bug report and the response was worded made it sound like something just added to me.

[MaxED]

Also I see you added poly checking code, unfortunately:...

Fixed.

[ZZYZX]

No, that's been in map editors for years.

eh, original DB1 and DB2 didn't try to match all sector's linedefs, they were just flipped independently based solely on their current direction.

[Kappes Buur]

eh, original DB1 and DB2 didn't try to match all sector's linedefs, they were just flipped independently based solely on their current direction.

You are quite correct. But then this is not DB1 or DB2.
MaxED introduced the current behaviour of flipping sidedefs with r1968 in July of 2014

---

Code: Select all

[r1968] by m-x-d   2014-07-07 14:17:49 
	Linedefs Mode:
		"Flip Sidedefs" action will no longer flip one-sided lines.
	Linedefs Mode:
		"Flip Linedefs" action now tries to align linedefs, so their front (or back) point towards
		the same sector.
	Sectors Mode:
		"Flip Linedefs" action is now available form this mode, and it will also try to align
		linedefs, so their front (or back) point towards the same sector.

[GooberMan]

Then perhaps it should be renamed "Align Linedefs"? Flip Linedefs has meant exactly flip the selected linedefs' direction since DEU.

[Kappes Buur]

To be fair, it does flip the sidedefs when a single linedef is selected.

Making different routines for flip and align, well that's up to MaxED.

[Sandro]

MaxED introduced the current behaviour of flipping sidedefs with r1968 in July of 2014
To be fair, it does flip the sidedefs when a single linedef is selected.

Making different routines for flip and align, well that's up to MaxED.

Thanks for the information, I didn't notice when the change had occured before.

Well, as I asked just before, I'd rather like to have the choice to select between "flip selected linedef according to sector direction" and simply "flip selected linedef" actions, if possible? That would be great!

[Kappes Buur]

When a map is loaded from the File > file list, would it be possible to have the edited map
saved in the home folder rather then the folder of the last saved map.

For example:

• I load DH.wad
  

  ---

  

  and after some editing I want to save the changed map.
  But, instead of opening the DH.wad home folder, the folder of the previously saved map opens
  

  ---

  

  which now forces me to change to the correct folder.

[Chl]

I have a small request for something that I would find very useful.

When in lindef mode, in the bottom left where it displays how many you have selected, I would find it very convenient in addition to displaying how many lines you have selected it would also display the total length of the selected lines. This could be great when you make stuff to match textures.

[ZZYZX]

I got an error on map load which says "(null): Invalid ACS module", if I try to save my UDMF map with empty BEHAVIOR (24 bytes, the source is either empty or contains just the #include "zcommon.acs" line).
When I add at least one script, the error goes away. Is that a flaw of how GZDB generates empty BEHAVIOR or GZDoom bug?

[Nash]

^ has nothing to do with GZDB; my pipeline involves using an external command line tool to compile scripts and insert them into the WAD, which means that I completely don't even use GZDB's built in script editor (I use Notepad++ to edit my map scripts)... (G)ZDoom complains the same error for me if I don't add at least one empty script.

[Gez]

If you make a scriptless Hexen map, does ZDoom complain as well?