[0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

[Supat97]

Look like gunbonsai version 0.9.2 having a problem with reelism 2 and their add-on crash on titlemap (VM_Abort) the gunbonsai version 0.8.5 with reelism 2 and their add-on work fine no problem.
Here a screenshot i captrued.

And Also my custom gun level up sound didn't play properly what ever i put the files sound on user string bonsai_levelup_sound of the CVRINFO what did i miss and how what i suppose to do next?

[Gourry]

Not sure if it's my game mods or it's a bug for this to happen because it was working fine for a bit. For the level up numbers, it went in the negatives and the elemental beam was attacking me instead of of the enemy. Don't know it started doing this now.

[imgur]https://imgur.com/a/1DpjlS4[/imgur]

[Carrotear]

I get this error when I load this with Ashes Weapons pack "R_InstallSpriteLump: Bad frame characters in lump PENTAHUD"

EDIT: Never mind, it was an error while trying to run ashes weapons with Pandemonia Monsters.

[ToxicFrog]

"Bad frame characters in lump PENTAHUD" is a warning resulting from some extraneous data getting included in the pk3 that I should probably clean up; it doesn't actually affect the game.

I'll look into the Reelism crash, and I'm still trying to track down the overflow issue -- the number it "overflows" to is exactly 0x80000000 expressed as an int32_t, so it really looks like at some point it takes the XP double, does integer math on it, and then casts it back to a double, with tragic results.

As for the custom levelup sound -- what did you put in the cvar? Bear in mind that it needs to be the name of a SNDINFO entry, not like a sound filename -- it has to be a sound the engine has already loaded.

I also just realized that I have some bugfixes that I thought I'd already released but hadn't, so I'll try to get those reported issues fixed and roll it all into a release.

[ToxicFrog]

I can't reproduce the Reelism 2 crash, but if you downloaded GB 0.9.2 very soon after it was released there was a TITLEMAP crash in that version -- if you re-download it and the crash still happens, please post your full modlist and load order.

[Supat97]

I can't reproduce the Reelism 2 crash, but if you downloaded GB 0.9.2 very soon after it was released there was a TITLEMAP crash in that version -- if you re-download it and the crash still happens, please post your full modlist and load order.

Looklike the gunbonsai 0.9.2 got working on reelism 2 without geting VM_abort crash on the TITLEMAP again however if i actived half monsater spawn on the game menu then i start the game i got VM_abort crash



here my mod loadlist of gunbonsai that i use with reelism 2

- reelism2_v1.21.pk3
- plyco_reelism2_v2.0.pk3
- slot1_magnetism.pk3
- EASEv.1.0.0_reelism2.pk3
- pacghost_reelism2_v1.1.pk3
- slotboss_korax.pk3
- Reelism 2 - Piter's Reel Fudge Pack.pk3
- Beta-MP-BDGTaunt.pk3
- lk_ucminimap.pk3
- precise-crosshair-v1.4.1.pk3
- gearbox-v0.7.2.pk3
- bullet-time-x.pk3
- libtooltipmenu-0.2.1.pk3
- GunBonsai-0.9.2.pk3
- crosshairs.wad
- laser-sight-v0.6.pk3
- damnums_1.0.1.pk3

[ToxicFrog]

I'll investigate, thanks for the detailed report.

E: that crash implies that sometimes WorldThingSpawned can be called with a null thing. why is this possible

[Keldian]

When playing with the mod Corruption Cards game crashes with the following error message:

---

VM execution aborted: tried to read from address zero.
Called from CCards_Actor_ThornsTotemBuff.ModifyDamage at CorruptionCards-v4.0.pk3:zscript/corruptioncards/cards/totems.zscript, line 311
Called from TFLV_Upgrade_Thorns_Aux.Retaliate at GunBonsai-0.9.2.pk3:ca.ancilla.bonsai/upgrades/thorns.zsc, line 40
Called from TFLV_Upgrade_Thorns.OnDamageReceived at GunBonsai-0.9.2.pk3:ca.ancilla.bonsai/upgrades/thorns.zsc, line 11
Called from TFLV_Upgrade_UpgradeBag.OnDamageReceived at GunBonsai-0.9.2.pk3:ca.ancilla.bonsai/upgrades/upgradebag.zsc, line 117
Called from TFLV_PerPlayerStats.OnDamageReceived at GunBonsai-0.9.2.pk3:ca.ancilla.bonsai/perplayerstats.zsc, line 315
Called from TFLV_EventHandler.WorldThingDamaged at GunBonsai-0.9.2.pk3:ca.ancilla.bonsai/eventhandler.zsc, line 220
Called from CCards_Actor_ThornsTotemBuff.ModifyDamage at CorruptionCards-v4.0.pk3:zscript/corruptioncards/cards/totems.zscript, line 311
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from weapon state Pistol.4 in Pistol
Called from PSprite.SetState [Native]

Also when playing with this combination on some mappaсks like Ramp when you return to the hub, the game either crashes or freezes.

[Ryuhi]

When playing with the mod Corruption Cards game crashes with the following error message:

---

VM execution aborted: tried to read from address zero.
Called from CCards_Actor_ThornsTotemBuff.ModifyDamage at CorruptionCards-v4.0.pk3:zscript/corruptioncards/cards/totems.zscript, line 311
Called from TFLV_Upgrade_Thorns_Aux.Retaliate at GunBonsai-0.9.2.pk3:ca.ancilla.bonsai/upgrades/thorns.zsc, line 40
Called from TFLV_Upgrade_Thorns.OnDamageReceived at GunBonsai-0.9.2.pk3:ca.ancilla.bonsai/upgrades/thorns.zsc, line 11
Called from TFLV_Upgrade_UpgradeBag.OnDamageReceived at GunBonsai-0.9.2.pk3:ca.ancilla.bonsai/upgrades/upgradebag.zsc, line 117
Called from TFLV_PerPlayerStats.OnDamageReceived at GunBonsai-0.9.2.pk3:ca.ancilla.bonsai/perplayerstats.zsc, line 315
Called from TFLV_EventHandler.WorldThingDamaged at GunBonsai-0.9.2.pk3:ca.ancilla.bonsai/eventhandler.zsc, line 220
Called from CCards_Actor_ThornsTotemBuff.ModifyDamage at CorruptionCards-v4.0.pk3:zscript/corruptioncards/cards/totems.zscript, line 311
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from Actor.DamageMobj [Native]
Called from Actor.A_SpawnProjectile [Native]
Called from weapon state Pistol.4 in Pistol
Called from PSprite.SetState [Native]

Also when playing with this combination on some mappaсks like Ramp when you return to the hub, the game either crashes or freezes.

That last part has been an issue with corruption cards for a bit iirc, usually has to do with permanent cards having affects on stages where they are impossible to fulfill, i remember getting it with the BTSX 1 tram transitions in the past. I'd mention it there just to be sure it's not related to that instead and/or as well just in case.

[ToxicFrog]

Looking at that stack trace, it looks like:
- player shoots monster
- CC thorns totem effect fires and damages player
- GB thorns upgrade effect fires and bounces damage back at something
- CC thorns totem effect fires again and crashes because something is null that it wasn't expecting to be
I don't think this is a bug in my code. Looking at the CC code, it looks like the totem's owner field is null somehow when it fires?

[ToxicFrog]

This is a bugfix release. You can download it here. Some of the suggested changes to melee and wimpy weapons have been implemented; an issue with LegenDoom compatibility is fixed; and it runs in lzDoom again.

[Netheritor]

Oh, so that's what thorns vs thorns looks like. I have CC 4.0 but rarely played it. Quite difficult for me to test thing with GB if the cards I got is quite random.

[r&r]

Old Maps That I recommend and this mod helps and fits for them.

The Inquisitor "1" and 2
and
Abysm "1"
for Doom 2,
and
Encrypter for Heretic

All of them got rpg like elements, with out a RPG upgrade system,
so this mod helps and fits for it.

[MsrSgtShooterPerson]

Hey ToxicFrog, just wanted to report that I seem to be getting an issue where upon using Revivification, I sometimes occasionally get killed alongside ghosts that are revived - this unusual interaction is likely caused by different mods I have that perhaps spreads a revivification effect token back to the player.

I unfortunately don't have a stack trace since it's technically not a crash

[openroadracer]

Hey ToxicFrog, just wanted to report that I seem to be getting an issue where upon using Revivification, I sometimes occasionally get killed alongside ghosts that are revived - this unusual interaction is likely caused by different mods I have that perhaps spreads a revivification effect token back to the player.

I unfortunately don't have a stack trace since it's technically not a crash

Do you have a load order, at least?