[0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

[generic name guy]

Hm, must have been this commit, not sure why it's printing that stuff to the console though, might be an option in GZDoom itself.

Just tested it: yeah, it does that for me too, even though i didn't even touch any GZDoom settings, weird.

[ToxicFrog]

Whoops, I accidentally released it with debugging enabled. Hang on and I'll push a hotfix.

E: hotfix pushed, please re-download.

Fixes:
- debug messages turned off
- Intuition name and description added to LANGUAGE lump

[Carrotear]

I'm sorry to bother again. But now LegenDoom doesn't work it now.

[Netheritor]

I found a bug;
I played with all upgrade available, some weapons that's not melee has shield upgrade. Tested it with vanilla doom 2. Rocket is alright, but ssg, plasma, chaingun (maybe bfg) has shield upgrade.

Also, how can I forget about all map? Your new upgrade is inspired by allmap, right?

So here's my idea inspired by infrared;
Enemy detection: Enemy will have (a bit transparent) silhouette color in certain range. As you know, infrared will make enemy actor has hazy green color. Do that but without the night vision thing, only the enemy detection. Color is up to you.

[ToxicFrog]

I'm sorry to bother again. But now LegenDoom doesn't work it now.

"doesn't work" how? Game doesn't start up if they're both loaded? Can't get LD effects by leveling up? Switching LD effects doesn't work? Other?

E: ok, on testing I've found a problem, although I don't know if it's the same problem -- weapons gain LD effects at the wrong levels relative to how the "gun levels per LD effect" setting is configured. Should be an easy fix.

I found a bug;
I played with all upgrade available, some weapons that's not melee has shield upgrade. Tested it with vanilla doom 2. Rocket is alright, but ssg, plasma, chaingun (maybe bfg) has shield upgrade.

The new melee weapon detection probably needs (even more) tweaking -- it's now on its third iteration and is "weapons where more than 75% of the attacks are within the AVOIDMELEE radius of 192 are considered melee weapons". If you're routinely using those weapons in close quarters it probably guessed that they're melee based on that. :sigh:

Reliably differentiating melee from non-melee weapons turns out to be really hard! Maybe I should just go back to trusting the +MELEEWEAPON flag by default and adding overrides to BONSAIRC as needed. Or like, trust it by default but if it's really egregiously skewed towards short or long range attacks that takes precedence.

Also, how can I forget about all map? Your new upgrade is inspired by allmap, right?

So here's my idea inspired by infrared;
Enemy detection: Enemy will have (a bit transparent) silhouette color in certain range. As you know, infrared will make enemy actor has hazy green color. Do that but without the night vision thing, only the enemy detection. Color is up to you.

New upgrade is based on allmap, yeah -- it actually sets the allmap level flag when activated, same as picking up a computer map, and at level 2 it also gives you an infinite-duration Scanner power.

Outlining/glowing enemies like that will need some investigation, I think. The actual nightvision works by setting the fixedlightlevel field on the player, and then the gzDoom rendering code checks that field and if it's enabled, looks at the player's inventory for a torch or nightvision item and uses that to decide how to render enemies. I'll probably have to take a completely different approach and mess with enemy render flags (or attach some other object to them that provides the glow) whenever they get close. Could be a neat upgrade if I can get it working, though.

[Carrotear]

I get a vm abort message as soon as it launches.

[wildweasel]

I get a vm abort message as soon as it launches.

Please post the text of the error.

[Carrotear]

Right, my bad. Sorry for the delay.

[generic name guy]

Right, my bad. Sorry for the delay.

Oh, i see, it does not like TITLEMAPS, i got the same crash with Project Brutality

It looks like the error occours because you don't have a weapon/player actor

[generic name guy]

Ok, i fixed it
https://github.com/generic-name-guy/gun ... .2-Fix.pk7

[SaucepanSF]

Been away a bit and just seeing this one. Wow is all I can say. Going straight into load order.

Only thing I'd change if I could, would be to disable the pausing of the game to choose an upgrade. In the options, I changed the number of upgrades to just one (from the default 4), and this seems to be a personal fix, as it just chooses it for me and I can keep the action going in game without disruption.

Anyway whatever, thank you for this!

[ToxicFrog]

Whoops. I have a tendency to test using command line options that skip the titlemap entirely, so I didn't catch this. Thanks to generic name guy for getting a fix out so quickly!

The official release has been hotfixed (again) and re-uploaded.

[ToxicFrog]

Been away a bit and just seeing this one. Wow is all I can say. Going straight into load order.

Only thing I'd change if I could, would be to disable the pausing of the game to choose an upgrade. In the options, I changed the number of upgrades to just one (from the default 4), and this seems to be a personal fix, as it just chooses it for me and I can keep the action going in game without disruption.

Anyway whatever, thank you for this!

Glad you like it!

I don't think disabling pausing when choosing an upgrade is on the table, because (as I understand it) opening an OptionMenu is hardcoded to pause the playsim; doing it while keeping the playsim running would require me to write my own UI code, which I 1000% do not want to do.

[DarkkOne]

Been away a bit and just seeing this one. Wow is all I can say. Going straight into load order.

Only thing I'd change if I could, would be to disable the pausing of the game to choose an upgrade. In the options, I changed the number of upgrades to just one (from the default 4), and this seems to be a personal fix, as it just chooses it for me and I can keep the action going in game without disruption.

Anyway whatever, thank you for this!

Glad you like it!

I don't think disabling pausing when choosing an upgrade is on the table, because (as I understand it) opening an OptionMenu is hardcoded to pause the playsim; doing it while keeping the playsim running would require me to write my own UI code, which I 1000% do not want to do.

Not to mention that not pausing it wouldn't exactly "keep the action going" since you'd still have to navigate it and make a choice, it'd just keep the action happening *to* you, while you're not engaging with it.

[ToxicFrog]

This is true, but there are also some people who are into that -- Dark Souls and System Shock both work that way, and Diablo made it an explicit marketing point that "the action never stops" even when you're rummaging through your inventory or assigning level-up stat points.

In my experience this mostly means that you just wait until you're out of combat to do character management, which you can always simulate in this by not pressing the level-up button when you're in combat.