The whole point of the mod is that your flow through the level is different than if you were playing it vanilla, and that the existing color key system is irrelevant. On some maps you can walk right up to the exit very early in, but it doesn't do you any good until you find the keymaster.Cryomundus wrote:Can I ask why? Having all the keys just seems to to really break the flow of a level, and I don't know why you would do that. Wouldn't it be better to have it as an option?
Hmm, I can't reproduce that... which map / WADs are you loading?Someone64 wrote:With the latest version I'm just getting VM execution failed tried to read from address zero from hud.txt.
Okay, so I've fixed the crash and updated the build, but now something weird happens. Keymaster stops working entirely based on which order you load Tilt++ vs KM with. If I runSomeone64 wrote:Ah, found out that it's Tilt++ that was doing it. It wasn't happening before you added the settings for giving keys.
Code: Select all
gzdoom Tilt++.pk3 keymaster.pk3Code: Select all
gzdoom keymaster.pk3 Tilt++.pk3KM compiles a list of "monsters in the level" on start based on the bIsMonster actor flag. If PB is giving barrels the bIsMonster flag for some strange reason, then yeah they might get chosen as the keymaster. Same with the "damage bonus", which is setting the DamageFactor property on all monsters under the hood... if PB is setting that on its own (seems likely?) without respecting the existing values, it'll stomp whatever KM did. Not sure how to fix that.New bug report: Damage bonuses don't work in Project Brutality 3.0 test. Have not tried it on the old Project Brutality or just Brutal Doom yet.
EDIT: Another one. Due to PB's unique spawning system the barrels will consistently be picked to be the keymaster instead of monsters. Other mods with special spawning systems probably also have this issue.
Code: Select all
GameInfo
{
EventHandlers = "TiltPlusPlusHandler"
}Code: Select all
GameInfo
{
AddEventHandlers = "KeyMasterHandler"
StatusBarClass = "KeymasterStatusBar"
}
No worries! You got the fix out.Nash wrote:Sorry about that.
Speaking of status bars - from what I see of the ZScript for the HUD, it looks to override SBARINFO completely and they can't coexist, correct? My knowledge on ZScript is extremely limited currently. You aren't aware of a way to integrate your arrow radar into a current HUD made in SBARINFO is there? I have aspirations of changing Ultimate DoomVisor to ZScript eventually (at which point I think it might be possible), but right now it's in old school SBARINFO and if I load Keymaster up with it, it either overrides it or vice versa.JPL wrote:Updated the build with Heretic support, thanks to @m0rb from twitter.
All the changes were very simple and coexist nicely with the Doom support, except for the HUD, which I had to separate into filter/game-doomchex/ and filter/game-heretic/ folders because the former derives from DoomStatusbar and the latter from HereticStatusBar. They're identical in every other respect though, so the code duplication there is a real bummer. Can anyone figure out a clever way around that?
Correct, I'm not aware of any way to "add on to" the existing HUD. Which is a bummer in Keymaster's case because it doesn't add its own SBARINFO data, all it really does is draw that one visual element of the icon fading in and out; it could coexist with a huge variety of other HUDs.saegiru wrote:Speaking of status bars - from what I see of the ZScript for the HUD, it looks to override SBARINFO completely and they can't coexist, correct? My knowledge on ZScript is extremely limited currently. You aren't aware of a way to integrate your arrow radar into a current HUD made in SBARINFO is there? I have aspirations of changing Ultimate DoomVisor to ZScript eventually (at which point I think it might be possible), but right now it's in old school SBARINFO and if I load Keymaster up with it, it either overrides it or vice versa.JPL wrote:Updated the build with Heretic support, thanks to @m0rb from twitter.
All the changes were very simple and coexist nicely with the Doom support, except for the HUD, which I had to separate into filter/game-doomchex/ and filter/game-heretic/ folders because the former derives from DoomStatusbar and the latter from HereticStatusBar. They're identical in every other respect though, so the code duplication there is a real bummer. Can anyone figure out a clever way around that?
This totally works, thanks so much! Very very easy to move the old status bar code over to a handler. This also removes the need for the separate Doom vs Heretic HUDs.Nash wrote:JPL: You might be able to utilize the RenderOverlay EventHandler to draw 2D stuff without overwriting status bar classes. I remember messing around with it in a test WAD once and it worked.