ThrustFactor

[Major Cooke]

Yeah, NOIMPACTDMG is meant to work one way. An actor with this flag can still receive -- but cannot give -- impact damage, as long as this flag is not present on the actor being thrust around.

[Major Cooke]

Now with Graf's refactoring complete, I have updated ThrustFactor to follow suit.
New vs old for quick comparison if you'd like.
The only important thing changed from the old pull request to this new one was the save version bump.

[Blzut3]

Still looks fine to me. Graf the ball's back in your court to glance over the corrected version and merge.

[Graf Zahl]

This will have to wait for Randi's approval since it introduces a dynamic structure into AActor and I have no idea what the impact on the scripting branch will be.

[Major Cooke]

I'll take waiting over turning it static any day.

[Graf Zahl]

I'll be honest here:

While I see the appeal with this feature, it's far too widespread throughout the code for something so specialized.
Does this really need this kind of ultimate flexibility that makes it a major drag?

[Major Cooke]

There are times where I would want a monster that takes no damage from a certain damagefactor to always be thrust around, and then sometimes I would want it to change.

If there are better ways to go about handling this, I'm more than willing to try them out.

Also, in Doomscript, it would become modular at any rate wouldn't it?

[Gez]

If you want Doomscript modularity, you'll have to wait for Doomscript.

[Graf Zahl]

As a matter of fact, this feature injects itself so deep into the engine that DoomScript is hardly an issue.

[Major Cooke]

Well, alright. I'll look into rebuilding the thrustfactors as static then. Or is that not what you meant?

[Graf Zahl]

Please put this on hold for now.

[Major Cooke]

Agreed. I'm not even sure where to go with this.

[Blzut3]

So between Graf not liking the feature and me seeing ever more flaws as I re-review the change, I think it's best to WFDS this thread.

[Major Cooke]

Considering it probably isn't that far off anymore, I'm not overly concerned.