0000641: Crash when changing true color mode

[Enjay]

https://mantis.zdoom.org/view.php?id=641

Code: Select all

Summary	0000641: Crash when changing true color mode
Description	I can reliably get a crash in 3.0.0 64 bit when changing to software output and switching true color mode off.
Steps To Reproduce	Start game in OpenGL mode (you can start an actual game or just do it from the title screen)
Go to the change rendering output menu
Change hardware acceleration to Doom software
Change Software true color to off
Crash

https://mantis.zdoom.org/file_download. ... 5&type=bug

[Rachael]

Figures someone would find this bug, and of all people you would be the one.

[Rachael]

Fixed

[Chris]

The crash still occurs even with this commit. There's problems when you go the other way too, BTW. If you start with software rendering, change to opengl, then toggle the truecolor option, the window seems to reinitialize using opengl rendering, but if you try to start a game it's all messed up with only the HUD being drawn.

gzdoom-crash.7z (7,341 bytes)

[Enjay]

Figures someone would find this bug, and of all people you would be the one.

Every day, Federal scientists are looking for new ways to kill bugs.

I'm doing my part!

[leodoom85]

Also, that bug works in the 32-bit version but probably it was fixed too

[Rachael]

Reopened this one, then - I will address it when I have some extra time. Ultimately, maybe it might be better to compare "vid_renderer" and "currentrenderer" and latch vid_renderer before changing the mode.

[Graf Zahl]

Once this is fixed I'll do a new release.

[Rachael]

I would advise against that. This fix definitely needs to be tested.

I basically took out any reference to "vid_renderer" that was not directly in the hardware code. So far it seems to be working.

Addressed in this commit.

[leodoom85]

You can check this one better...at the end of the video, the crash happens. This one's the 32-bit version

[Enjay]

I would advise against that. This fix definitely needs to be tested.

For what it's worth, I've just made myself a build with the fix and changed the options a dozen or more times: no crash for me.

[Rachael]

Technically, this bug is actually very old, it's just that having a menu on the vid_renderer and an option that forces a video reset right next to it just brought it to light. You could reproduce it in ancient versions of GZDoom simply by changing vid_renderer in the console and then selecting a new video mode.

For what it's worth, I've just made myself a build with the fix and changed the options a dozen or more times: no crash for me.

Thank you! - I suppose if no one else reports any problems with this, you should be clear to do a release, Graf. I'd wait for the CI's to finish building, first, though, just to be sure.