Rail Puff Support for Floors and Ceilings

Moderator: GZDoom Developers

Post Reply
User avatar
Major Cooke
Posts: 8170
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Rail Puff Support for Floors and Ceilings

Post by Major Cooke »

Pull Request

A simple change, this adds the ability for puffs to spawn on floors and ceilings if the puffs have ALWAYSPUFF specified. In a way, this is technically a bugfix and a feature.

I went this route and added support for the flag because it was either this, or expanding bullet attack functionalities with the abilities to provide offsets from the shooter which no one can really see without a beam. This I feel was much simpler.
User avatar
Nash
 
 
Posts: 17434
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: Rail Puff Support for Floors and Ceilings

Post by Nash »

This broke my line traces (spawned with LineAttack) that rely on the puffs automatically disappearing when it hits sky ceilings and floors (and also required +ALWAYSPUFF so that they collide with live actors). Please revert or add an option for your new behavior.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Rail Puff Support for Floors and Ceilings

Post by Graf Zahl »

How can this affect your traces spawned with P_LineAttack, when the change is in P_RailAttack?

That said, it should definitely have a sky check added.
User avatar
Major Cooke
Posts: 8170
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Rail Puff Support for Floors and Ceilings

Post by Major Cooke »

Better yet, a flag to allow the +ALWAYSPUFF flag. Not just skies.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Rail Puff Support for Floors and Ceilings

Post by Graf Zahl »

Skies should be off by default, unless the SKYEXPLODE flag is specified. No more needless options.
User avatar
Major Cooke
Posts: 8170
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Rail Puff Support for Floors and Ceilings

Post by Major Cooke »

Post Reply

Return to “Closed Feature Suggestions [GZDoom]”