[2.8pre-1675-g7be6041] RGF_CORPSES does nothing.

[Yholl]

The RGF_CORPSES flag in A_RadiusGive doesn't appear to work at all right now. I need it to be able to recreate the skull items from DoomRL properly.

[Major Cooke]

Pre-dead corpses or monsters that were actually killed?

Pre-dead monsters don't have the +CORPSE flag (see Skip_Super).

[Yholl]

Pre-dead corpses or monsters that were actually killed?

Pre-dead monsters don't have the +CORPSE flag (see Skip_Super).

Killed, I know about how the pre-dead ones are. I spawn imps, kill imps, and the RadiusGive has no effect on them. Changing the flag from the corpse flag to the monster flag, and using it on living monsters works fine, using the corpse flag on dead ones doesn't work at all.

[edward850]

Lacking an example, I can't actually test this, but I have noticed a potential logical hole. While all monsters can have MF_CORPSE, so can anything that dies with a raise state (thanks Batman Doom), and players.
More over, RGF_CORPSES on its own wont actually include anything, so you still need to check for another flag type. RGF_MONSTERS is required to check for all corpses of monsters, but the kicker here is it also means that normal monsters are also inclusive. Something tells me this isn't what you want, and the flag check logic here is rather poorly designed.

... Almost as if it was never actually tested.

[Graf Zahl]

Poorly designed indeed. The fact that all checks are for exclusion, not inclusion means that there's basically no way to change this.

[Major Cooke]

Would remaking the function as another work better, or would that just be a waste of time? I.e. A_RadiusGive2 or A_RadiusGiveEx... It's something I'd very much like to fix but it appears that would be the only course of action if we want to avoid breaking anything.

[NeuralStunner]

I'm all for an improved remake, especially if it actually does work just like A_Explode.

[Major Cooke]

Agreed, but couple things. First, I'm going to ensure I don't waste time if Graf doesn't approve, or Randi. Second, even if approved, don't expect the pull request to be merged anytime soon.

[phantombeta]

I'm all for an improved remake, especially if it actually does work just like A_Explode.

I asked Edward850 to take a look at that bug.

Code: Select all

[...] [02:51.32 AM] <@Edward850> The bounding box iteration is just a blockmap. Distance checks are still needed, and explosions do actually check the radius. [...]
[...] [02:55.18 AM] <@Edward850> I think what I might do if I get the chance to look at this tonight, is actually just make common functions between these two... uhm... functions. [...]

[edit]I think a new function should not be made...
A_RadiusGive is completely broken and the current implementation should be deleted and replaced with a rewritten version of the function. Compatibility doesn't even matter, the function doesn't even work like it's supposed to so it should be completely rewritten.[/edit]

[Beed28]

I'm up for it being rewritten. If the new one can be made to actually work with a mad-wide radius, I wouldn't need to use such a hacky method in Doom: Megabounce. Also, if it's going to be completely rewritten, would it be possible to make it work with RGF_ITEMS, or would that still be impossible?

[NeuralStunner]

I asked Edward850 to take a look at that bug.

Ah, cool. I was going to mention it to him myself but never got around to it. (Been taking a break from ZDoom for the most part, lately.)

[edward850]

Well if it's being rewritten there really isn't much for me to do anymore.

[Edward-san]

While all monsters can have MF_CORPSE, so can anything that dies with a raise state (thanks Batman Doom), and players.
More over [...]

Uh, I miss the meaning of that sentence, as there isn't the grammatical main clause.

[Major Cooke]

Here we go!