Multiplayer pickup bug (keys + sv_unlimited_pickup)

[cocka]

When you play in multiplayer and dmflag "keep keys" is ON, the keys can be picked up repeatedly by the same player even if (s)he has already grabbed that specific key.

After touching the key, you'll hear many pickup sounds and there will be a lot of log messages showing "you picked up some key".

[edward850]

Please don't post bug reports from 1170. 1181 is released with all of ZzZombo's changes reverted. Notably, this bug appears to have been related to his changes, as it cannot be reproduced now.

[Enjay]

Are the 1170 builds the ones with the ZzZombo sanitation changes? If so, I'll remove them from the DRD site. The equivalent GZDoom build has already gone.

[edward850]

Yup. It also has a broken network buffer, so it's also rather unstable to use.

[Enjay]

OK, they're gone. I left the map files in place for the unlikely event that they might be useful. They'll go after a month or so.

[cocka]

Please don't post bug reports from 1170.

It occurs in 1181 as well.

Look:

kulcs.wad

(1.61 KiB) Downloaded 54 times

And start with these command line options:

Code: Select all

zdoom.exe -file kulcs.wad -iwad doom2.wad -host 1 -warp 1 -skill 3 -nomusic +sv_noweaponspawn 1 +sv_itemrespawn 1 +sv_weapondrop 1 +sv_fallingdamage 1 +sv_respawnsuper 1 +sv_dontcheckammo 1 +sv_respawnprotect 1 +sv_unlimited_pickup 1

The last one sv_unlimited_pickup causes the problem because the keys shouldn't be affected at all. (as it was in the past)

Of course it's completely illogical if the player can grab the very same key more times.

Ammo and inventory items can be picked up infinitely because their amount can also decrease. But even if some acs function takes your key away, the key (of course in coop) stays there on the floor but if you've got it, it doesn't make sense to enable the player to grab it again.

[edward850]

See, you didn't mention sv_unlimited_pickup originally.
At all.

Please don't assume we are psychic. We aren't.

[Enjay]

However this is solved, in certain game modes it needs to be possible to pick up multiple keys of the same type (picking up the same one over and over in a coop game is a different issue I guess). There are mods that depend on the ability to collect multiple keys of the same type. In fact, I think there may have been an epic thread about this some years ago.

[edward850]

I can't think of a single mod that actually requires sv_unlimited_pickup, so I'm not sure what you're on about, Enjay.

[cocka]

Please don't assume we are psychic. We aren't.

Because I've just realized that the problem occurs only with keys and sv_unlimited_pickup.
I'm sorry for not mentioning that.

to collect multiple keys of the same type.

That's right but this is not about the same type but about the same key i.e. the same instance on the same place with same coordinates on a map.

[Enjay]

I can't think of a single mod that actually requires sv_unlimited_pickup, so I'm not sure what you're on about, Enjay.

No no, I meant that there are mods that use the keys as collectible items and so on and (ab?)use the ability to collect the same key type over and over. I don't remember the details because I've never done this myself but I'm sure I remember a looooong time ago that it became impossible to collect a second key of any particular type in ZDoom. As a result, there was a protracted thread about the need to do so and why it might be useful. Following on from that, the ability to collect a key type multiple times was restored. It was a very long time ago though.

That's right but this is not about the same type but about the same key i.e. the same instance on the same place with same coordinates on a map.

Yeah, I know (I basically said that in my post). I was just noting that the ability I was talking about (picking up multiple copies of a key type) needs to be preserved in any fix that might be implemented for this problem, just in case the two things overlap somehow.

[cocka]

I added the keys and unlimited pickup to the topic title so it's not a duplicate any more and I don't think that it should be here, because it hasn't been solved so far. (as far as I know)

[edward850]

Yeah, I know (I basically said that in my post). I was just noting that the ability I was talking about (picking up multiple copies of a key type) needs to be preserved in any fix that might be implemented for this problem, just in case the two things overlap somehow.

Nope, this is just the multiplayer handling of key pickups which seems to get handed off the the global inventory handler, which then decides that yes, the player can pickup more (because sv_unlimited_pickup is on). Somehow, this method never gets called on the first pickup.

[Enjay]

OK, cool, separate issue. Thanks for explaining.

[cocka]

Though, I don't know why is this considered to be a closed bug..