[GZDoom] 544 tall skies still wrapping

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Kate
... in rememberance ...
Posts: 2975
Joined: Tue Jul 15, 2003 8:06 pm

[GZDoom] 544 tall skies still wrapping

Post by Kate »

Spoiler:
If a sky is exactly 544px tall it's big enough to fill in all of ZDoom's freelook space and lever wrap (Edit: and never wrap). However GZDoom still insists on making it wrap once, which makes it look like a mess.
User avatar
ChronoSeth
Posts: 1631
Joined: Mon Jul 05, 2010 2:04 pm
Location: British Columbia

Re: [GZDoom] 544 tall skies still wrapping

Post by ChronoSeth »

I've noticed this too. AFAIK, the height of the texture is not taken into account at all, and the sky texture is always tiled downward once.
User avatar
randi
Site Admin
Posts: 7746
Joined: Wed Jul 09, 2003 10:30 pm
Contact:

Re: [GZDoom] 544 tall skies still wrapping

Post by randi »

Closing because GZDoom has its own bugs forum. (And bumping so it might get noticed by somebody who might do something with it.)
Gez
 
 
Posts: 17833
Joined: Fri Jul 06, 2007 3:22 pm

Re: [GZDoom] 544 tall skies still wrapping

Post by Gez »

Looking into gl_skydome.cpp, this appears to be by design. The RenderDome() function calls another function called RenderSkyHemisphere() twice, once for the upper hemisphere and the second time for the lower hemisphere.

So it's not so much that it wraps or tiles the texture, it's just that it draws it twice, independently of texture size.

I'm not going to change anything about how it works.
User avatar
NeuralStunner
 
 
Posts: 12325
Joined: Tue Jul 21, 2009 12:04 pm
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support
Location: capital N, capital S, no space
Contact:

Re: [GZDoom] 544 tall skies still wrapping

Post by NeuralStunner »

What about a new MapInfo key (GZDoom specific, ZDoom ignored) to enable single-image sky?
Gez
 
 
Posts: 17833
Joined: Fri Jul 06, 2007 3:22 pm

Re: [GZDoom] 544 tall skies still wrapping

Post by Gez »

Unless Graf does it, it won't happen.
User avatar
NeuralStunner
 
 
Posts: 12325
Joined: Tue Jul 21, 2009 12:04 pm
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support
Location: capital N, capital S, no space
Contact:

Re: [GZDoom] 544 tall skies still wrapping

Post by NeuralStunner »

Would you recommend an official suggestion on yon GZDoom forum, then?
Gez
 
 
Posts: 17833
Joined: Fri Jul 06, 2007 3:22 pm

Re: [GZDoom] 544 tall skies still wrapping

Post by Gez »

You can try.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [GZDoom] 544 tall skies still wrapping

Post by Graf Zahl »

Well, such tall skies were never considered when the function was written
User avatar
printz
Posts: 2648
Joined: Thu Oct 26, 2006 12:08 pm
Location: Bucharest, Romania
Contact:

Re: [GZDoom] 544 tall skies still wrapping

Post by printz »

What is the equivalent skybox for how GZDoom renders the skies natively? How large should that cylinder be, where is the camera placed? I know this post would be better for the drdteam forum, but I don't want to destroy the equivalent thread there.
Gez
 
 
Posts: 17833
Joined: Fri Jul 06, 2007 3:22 pm

Re: [GZDoom] 544 tall skies still wrapping

Post by Gez »

It's a sphere, not a cylinder. It's made of triangles like a geodesic dome. The shape is a bit weird in that the upper hemisphere covers about everything, the lower hemisphere only plugs a tiny hole at the bottom (as shown on the OP's pic).
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [GZDoom] 544 tall skies still wrapping

Post by Graf Zahl »

Should be better now. I reworked the coordinate calculations for oversized skies (larger than 240 pixels. The old code wasn't meant to work for anything taller than 256 pixels.
Gez
 
 
Posts: 17833
Joined: Fri Jul 06, 2007 3:22 pm

Re: [GZDoom] 544 tall skies still wrapping

Post by Gez »

Indeed, much better. I got a strange variant of halls of mirrors with r1332 and a 1024x1024 sky texture (it seemed like some triangles were HOMing, others not), now it looks normal.
Post Reply

Return to “Closed Bugs [GZDoom]”