[r2210+]A_DamageMaster not functioning properly

[DBThanatos]

More testing done. I tried the following lines:

Code: Select all

	DamageFactor "Normal", 0.01
	DamageFactor "Bullet", 100

So, setting "Bullet" damage to 100 should more or less counteract the 1% from "Normal", right? No, actually hitting the Imp with a single bullet results in an instagib.

No, it should not counteract.

You first are telling the game that all damage will be considered x0.01
Then you're telling the game that bullet damage will be multiplied by 100. Right there you're saying that the game will consider 2 types of damage separately: "normal" and "bullet". So, "normal" (all damage except "bullet") will deal x0.01. Bullet (not considered inside "normal") will deal x100
Resume: all damage, except "bullet" will deal x0.01; and "bullet" will be dealt x100

This had the same result:

Code: Select all

	DamageFactor "Normal", 0.0
	DamageFactor "Bullet", 100

Exact same case
Telling the game that all damage will be ignored ("normal" 0.0)
then that bulled will be dealt x100.
All damage but "Bullet" will be ignored. "Bullet" will be dealt x100

But! This works as expected:

Code: Select all

	DamageFactor "Normal", 0.0
	DamageFactor "Bullet", 1.0001

Then, you're telling the game that all damage ("all damage" = "normal" = all unespecified damage) will be ignored and that bullet will deal 0.0001 more than the regular damage it would deal regularly (not counting at all the previous "damagefactor "normal", 0.0).

If you put "normal" you're talking about all damage, then if you specify another damage, it's considered separately and overrides the damage factor applied by "normal"

So, another way to say it, both damage calculations are being done parallel, instead of being done consecutively.

Check this

---

Anyway, one monster, should be immune to everything except one type of custom damage. I have made large tests and I have succesfully reduced all possible damage in Zdoom to 0, that is:

Code: Select all

	DamageFactor "normal" , 0.0		//any non custom damage 
	DamageFactor "Fire" , 0.0		//lots of hexen projectiles
	DamageFactor "Ice" , 0.0		//more hexen projectiles
	DamageFactor "Electric" , 0.0		//I believe is the arc of death. This one was mentioned in the maulotaur's code
	DamageFactor "Explosion" , 0.0		//Not sure, please correct me if Im wrong or if it doesnt exist
	DamageFactor "Disintegrate", 0.0		//strife
	DamageFactor "Extreme", 0.0		//I believe that's how is called please correct me if wrong
	DamageFactor "Poison", 0.0		//hexen
	DamageFactor "Railgun", 0.0		//I didnt know why my railgun was killing the mosnter, so i tried this and worked :D
	DamageFactor "Melee", 0.0		//I didnt know it was considered apart, but it is
	DamageFactor "BFGSplash", 0.0		//self explanatory

And I think those are all. Except that the "HolyMissile" (from the cleric's wraith verge, the main shot which fires the 4 ghosts) is still killing it. I checked the decorate of it, and it doesnt seems to have any custom damage type, at least not visible; I assume it is hardcoded or something. Anyone knows how is called or how to cancel it?

After seeing this thread I realized that there's a serious bug in the damage type system. DamageFactor "Normal" is supposed to protect against all types of damage that don't have a specific factor assigned. Otherwise it will never properly work.

So in your case, the proper method would have been to specify

DamageFactors "Normal", 0
DamageFactors "AllowedDamageTypeForThisMonster", 1.0 or whatever

[NeuralStunner]

I understood all that. I was testing the possibility that "Normal" was adjusting all incoming damage beforehand. I obviously found that was not the case. (Sorry for my wording implying that I was assuming that behavior.) I did find that it was something else entirely...

BTW, I've found no recent changes to DamageFactor handling in the changelog, either.

[Graf Zahl]

The problem here is actually that damage factors of 1.0 are not put into the damage factors list because it's the default. Obviously that's not a good idea when there's a setting for 'normal' damage in there as well.

[Major Cooke]

So what do you recommend we use to fix this?

[DBThanatos]

The problem here is actually that damage factors of 1.0 are not put into the damage factors list because it's the default. Obviously that's not a good idea when there's a setting for 'normal' damage in there as well.

So, putting "damagefactor "Weakness", 1.2" should do the trick?

[Graf Zahl]

1.0001 should also work. To fix this I have 2 choices: Leave 1.0 entries in the damage factors table or clean the table in actor postprocessing off all unnecessary entries.

[Major Cooke]

Yeah, I tested it yesterday and it worked just great. Thanks guys.

[NeuralStunner]

1.0001 should also work. To fix this I have 2 choices: Leave 1.0 entries in the damage factors table or clean the table in actor postprocessing off all unnecessary entries.

If you go looking around in that code, hopefully you can find out where this problem is coming from.

[randi]

Leave 1.0 entries in the damage factors table

I can't see anything wrong with just doing that.

[Graf Zahl]

Except that it's less efficient.

[randi]

Maybe so, but not by much, and in the case of a heavily-loaded table, I suspect it may even be more efficient to have it in there than to leave it out.