[r1794-1891] Saves going into C:\Windows?!

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Project Shadowcat
Posts: 9369
Joined: Thu Jul 14, 2005 8:33 pm
Preferred Pronouns: They/Them
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support
Location: Blacksburg, SC USA
Contact:

[r1794-1891] Saves going into C:\Windows?!

Post by Project Shadowcat »

Pray tell, when I open a zip file, why does it sometimes save into the godsdamn root of my Windows directory?

]save_dir
"save_dir" is ""

Running Windows Vista. When running under XP, it simply saved to where ZDoom is running (in this case, C:\Doom\Doom2).

EDIT: While ZDoom says the files are there, Explorer doesn't. I'm trying to find the save for a different bug that so occurred (the lighting issue).
User avatar
edward850
Posts: 5902
Joined: Tue Jul 19, 2005 9:06 pm
Location: New Zealand
Contact:

Re: [r1794-1891] Saves going into C:\Windows?!

Post by edward850 »

Look in your user folder (read: user folder, eg 'C:\Documents and Settings\Owner\'). They sometimes wind up there for some absurd reason.
User avatar
Project Shadowcat
Posts: 9369
Joined: Thu Jul 14, 2005 8:33 pm
Preferred Pronouns: They/Them
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support
Location: Blacksburg, SC USA
Contact:

Re: [r1794-1891] Saves going into C:\Windows?!

Post by Project Shadowcat »

I ran a search for save0.zds on my computer. Nothing from October 2009 is showing up at all.

And nothing in /Users or /Users/Project Dark Fox came up anyway.
User avatar
edward850
Posts: 5902
Joined: Tue Jul 19, 2005 9:06 pm
Location: New Zealand
Contact:

Re: [r1794-1891] Saves going into C:\Windows?!

Post by edward850 »

That's why I said Documents and settings... unless that's another thing Vista pointlessly changed.
User avatar
Project Shadowcat
Posts: 9369
Joined: Thu Jul 14, 2005 8:33 pm
Preferred Pronouns: They/Them
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support
Location: Blacksburg, SC USA
Contact:

Re: [r1794-1891] Saves going into C:\Windows?!

Post by Project Shadowcat »

Documents and Settings is just called "Users" on Vista. PITA to keep typing out, so that's a change I was more than welcome to accept... :P
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49252
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [r1794-1891] Saves going into C:\Windows?!

Post by Graf Zahl »

No problem here. Please note that an empty save_dir means the current working directory, not the one the EXE is in. Apparently you started ZDoom from somewhere else.
User avatar
Project Shadowcat
Posts: 9369
Joined: Thu Jul 14, 2005 8:33 pm
Preferred Pronouns: They/Them
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support
Location: Blacksburg, SC USA
Contact:

Re: [r1794-1891] Saves going into C:\Windows?!

Post by Project Shadowcat »

Which is what I'm trying to understand, WHERE is the current directory when I open a ZIP in the godsdamn Desktop.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49252
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [r1794-1891] Saves going into C:\Windows?!

Post by Graf Zahl »

Only Windows knows.
User avatar
Project Shadowcat
Posts: 9369
Joined: Thu Jul 14, 2005 8:33 pm
Preferred Pronouns: They/Them
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support
Location: Blacksburg, SC USA
Contact:

Re: [r1794-1891] Saves going into C:\Windows?!

Post by Project Shadowcat »

Well, I certainly didn't expect anything to be fixed (just maybe possibly addressed). But in either case, it still pisses me off. I've since changed my save_dir to where zdoom.exe is run.
User avatar
AFADoomer
Posts: 1344
Joined: Tue Jul 15, 2003 4:18 pm
Contact:

Re: [r1794-1891] Saves going into C:\Windows?!

Post by AFADoomer »

I just opened a zip on my desktop (Action Doom), and double-clicked the .wad to run... Saved the game, and the save file showed up on my Desktop. This is all in Vista. My save_dir cvar is blank.

The .zip file's contents are temporarily unzipped to a subfolder under C:\Users\username\AppData\Local\Temp. The subfolder is supposed to be deleted when you close the .zip file, though, so that won't help you find savegames if they're saved there for some reason.
User avatar
HotWax
Posts: 10002
Joined: Fri Jul 18, 2003 6:18 pm
Location: Idaho Falls, ID

Re: [r1794-1891] Saves going into C:\Windows?!

Post by HotWax »

Project Dark Fox wrote:Pray tell, when I open a zip file...
Clarify. Are you running a WAD directly out of its zip file? In that case, only WinZip (or whatever application you're using to view the ZIP file) knows.

Also you should not be doing that. :P
User avatar
bagheadspidey
Posts: 1490
Joined: Sat Oct 20, 2007 10:31 pm
Contact:

Re: [r1794-1891] Saves going into C:\Windows?!

Post by bagheadspidey »

Project Dark Fox wrote:Which is what I'm trying to understand, WHERE is the current directory when I open a ZIP in the godsdamn Desktop.
Put something like this in a batch file, put it in the same dir as zdoom, and drag a wad or other file onto it, it will tell you what the working directory is...

Code: Select all

@echo off
echo Current working directory is %CD%
pause
User avatar
Project Shadowcat
Posts: 9369
Joined: Thu Jul 14, 2005 8:33 pm
Preferred Pronouns: They/Them
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support
Location: Blacksburg, SC USA
Contact:

Re: [r1794-1891] Saves going into C:\Windows?!

Post by Project Shadowcat »

HotWax wrote:
Project Dark Fox wrote:Pray tell, when I open a zip file...
Clarify. Are you running a WAD directly out of its zip file? In that case, only WinZip (or whatever application you're using to view the ZIP file) knows.
Windows Explorer. I open the ZIP and double-click the WAD file from within the ZIP file. ZDoom opens it without any qualms.
Also you should not be doing that. :P
..... Thanks. I think. If a bit late. :P After pistol-starting a couple maps in Whispers of Satan... well, I suppose that wasn't too bad.

Anywho, setting a default path manually has definitely "fixed" everything (now all the saves go into one spot, just the way it should have been IMO), but a little warning would certainly be nice. Somehow. I dunno.

Thanks for trying to help, everyone. :)
User avatar
HotWax
Posts: 10002
Joined: Fri Jul 18, 2003 6:18 pm
Location: Idaho Falls, ID

Re: [r1794-1891] Saves going into C:\Windows?!

Post by HotWax »

Project Dark Fox wrote:Windows Explorer. I open the ZIP and double-click the WAD file from within the ZIP file. ZDoom opens it without any qualms.
...a little warning would certainly be nice. Somehow. I dunno.
This is a case of the OS being "too" helpful, methinks. And it's damned-if-you-do-damned-if-you-don't as far as how they could have coded it to "fix" such "mistakes".

As you can tell by my unabashed overuse of quotations, I don't think Windows or ZDoom is doing anything wrong here.

For convenience, Explorer displays the ZIP file like any other folder, without bothering you with the messy details like how it's actually only reading the contents and then extracting the files to a temporary folder on demand. Since the file you ran had ZDoom associated with it, it then ran ZDoom passing the temporary file in as an argument. And as is standard practice when running arbitrary files through the executable associated with them, it uses the current (temporary) folder as the working directory. ZDoom is coded to put saves in the working directory by default. Put all that in a nice big kettle and stir well, and you have your current conundrum.

There's a deeper problem here, though. What if the file you ran relied on other files within the ZIP? For example, if it was a batch file that ran ZDoom with two WADs and a DEH patch included in the ZIP, it wouldn't get very far. You really should just extract the contents of the ZIP and then run it from its permanent resting place on your hard drive. What you're doing is like trying to run a game directly off the CD without bothering to install it first. Chaos will naturally ensue.
User avatar
Project Shadowcat
Posts: 9369
Joined: Thu Jul 14, 2005 8:33 pm
Preferred Pronouns: They/Them
Operating System Version (Optional): Windows 11
Graphics Processor: nVidia with Vulkan support
Location: Blacksburg, SC USA
Contact:

Re: [r1794-1891] Saves going into C:\Windows?!

Post by Project Shadowcat »

If multiple files were in the ZIP, then I'd right-click the ZIP file and Run With... > ZDoom. With all of my IWADs in one spot and the IWAD picker dialogue always coming up, this hasn't failed (until the moment a certain order is specifically required, then I unzip and set up a shortcut).


Now, here's the funny part. When I ran before setting a default save directory, I could resume these saves from this temp location. Most puzzling, so that's probably why the searches weren't finding anything whatsoever (but ZDoom could).
Post Reply

Return to “Closed Bugs [GZDoom]”