GS Elemental Armor system

[Ryan Cordell]

Again, I need you guys to try and help me out with a little issue.

I have most of a custom armor system done, and there is only a small nitpick that I have to do:

Picking up an armor results in it giving the player an item, the player is triggering a script all the time. The script checks for the item and acts accordingly. However, for certain conditions (IE - you have three great armors and find one weak armor), you're still able to pick up the weak armor, even if it gives you nothing, practically wasting it. What I intend instead is that, somehow, the weak armor is left alone and you retain your greater armors. However, one of the methods I thought about solving is practically like an infinite loop - you keep collecting the inferior armor and it drops said armor again.

Is there any way I could have the inferior armor stay where it is and not be wasted, besides storing it in the player's inventory?

[skadoomer]

I think this needs to take advantage of the pickup state return value, where if the credentials are not met (meaning the script executed with pickup can return a value of false), it drops through to the drop state and leaves the armor where it lies. All the script has to do is use SetResultValue. The specifics of it are all going to depend on how your internal system is built. However, I'd start by looking in this direction.

[Ryan Cordell]

Actually, I do have ACS_ExecuteWithResult (It's however executed in the player actor.) and SetResultValue is set in the ACS script itself. I actually have it set that within the script, if the value is NOT met, SetResultValue sets out a FALSE value. However, I'm not sure how the actor itself would check for that value. Does DECORATE have such a method?

[skadoomer]

From the wiki:

All code pointers in the Pickup state sequence are called when the item is being picked up. The sequence is successful when either a function is called which doesn't return success or a function which is capable returns successful execution is called (you can also use ACS_ExecuteWithResult to set the result from ACS). Success can be overridden by terminating the state sequence with fail instead of stop.

It looks like if you put ACS_Executewithresult in the pickup state and have the SetResultvalue return 0, the pickup state will be marked as unsuccessful. However, I;m a little unsure of how to handle thing from there. I recommend an a_JumpIf statement where you can evaluate the result and make state modifications accordingly.

[Ryan Cordell]

Okay, I have the items use ACS_Execute, and I can have GiveActorInventory be used instead of GiveInventory. However, now with A_JumpIf(ACS_Execute(265,0) == 0, "Spawn") being used in the Pickup state, eh.. I dunno. Kind of frustrating, but still fun.

[Ryan Cordell]

Okay, an update..

I got the script working almost 100%, except for one detail:

If you pick up, say, the Fire Armor before you pick up the Super Armor, then you can't pickup the Super Armor and are stuck with the Fire Armor until you deplete it. (And making all those armors act like ZDoom's? Well, that's another challenge. ;P)

Elemental armors code -

---

Code: Select all

ACTOR FireArmor : Inventory
{
   Game Doom
   Inventory.Icon "FARMB0"
   Inventory.MaxAmount 200
   DamageFactor "Fire", 0.5
}

ACTOR NormalArmor : Inventory
{
   Game Doom
   Inventory.Icon "NARMB0"
   Inventory.MaxAmount 200
   DamageFactor "Normal", 0.5
}

ACTOR SpiritArmor : Inventory
{
   Game Doom
   Inventory.Icon "PARMB0"
   Inventory.MaxAmount 200
   DamageFactor "Spirit", 0.5
}

ACTOR GotFireArmor : Inventory {}
ACTOR GotNormalArmor : Inventory {}
ACTOR GotSpiritArmor : Inventory {}
ACTOR GotBasicArmor : Inventory {}
ACTOR GotSuperArmor : Inventory {}


//Seperate Elemental-Armor items.

ACTOR FireArmor_Pickup : CustomInventory
{
   Inventory.PickupMessage "Acquired the Fire Armor."
   Inventory.PickupSound "object/elementalarmor"
   Inventory.MaxAmount 1
    Radius 20
    Height 16
   States
   {
   Spawn:
      FARM B 6
      Loop
   Pickup:
	TNT1 A 0 ACS_ExecuteWithResult(265,0)
	TNT1 A 0 A_JumpIf(ACS_ExecuteWithResult(265,0) == 0, "Spawn")
	TNT1 A 0 A_GiveInventory("GotFireArmor",1)
      Stop
   }
}

ACTOR NormalArmor_Pickup : CustomInventory
{
   Inventory.PickupMessage "Found some Normal Armor."
   Inventory.PickupSound "object/elementalarmor"
   Inventory.MaxAmount 1
    Radius 20
    Height 16
   States
   {
   Spawn:
      NARM B 6
      Loop
   Pickup:
	TNT1 A 0 ACS_ExecuteWithResult(265,0)
	TNT1 A 0 A_JumpIf(ACS_ExecuteWithResult(265,0) == 0, "Spawn")
	TNT1 A 0 A_GiveInventory("GotNormalArmor",1)
      Stop
   }
}

ACTOR SpiritArmor_Pickup : CustomInventory
{
   Inventory.PickupMessage "You put on the Spirit Armor."
   Inventory.PickupSound "object/elementalarmor"
   Inventory.MaxAmount 1
    Radius 20
    Height 16
   States
   {
   Spawn:
      PARM B 6
      Loop
   Pickup:
	TNT1 A 0 ACS_ExecuteWithResult(265,0)
	TNT1 A 0 A_JumpIf(ACS_ExecuteWithResult(265,0) == 0, "Spawn")
	TNT1 A 0 A_GiveInventory("GotSpiritArmor",1)
      Stop
   }
}

//These are the All-Armor items.

ACTOR StandardArmor : CustomInventory replaces GreenArmor
{
   Game Doom
   Inventory.PickupMessage "Picked up some basic armor."
   Inventory.PickupSound "object/elementalarmor"
    SpawnID 68
    Radius 20
    Height 16
   States
   {
   Spawn:
      ARMT A 6
      Loop
   Pickup:
	TNT1 A 0 ACS_ExecuteWithResult(265,0)
	TNT1 A 0 A_JumpIf(ACS_ExecuteWithResult(265,0) == 0, "Spawn")
	TNT1 A 0 A_GiveInventory("GotBasicArmor",1)
      Stop
   }
}

ACTOR SuperArmor : CustomInventory replaces BlueArmor
{
   Game Doom
   Inventory.PickupMessage "Found the Super Armor!"
   Inventory.PickupSound "object/elementalarmor"
    SpawnID 69
    Radius 20
    Height 16
   States
   {
   Spawn:
      ARM2 A 6
      Loop
   Pickup:
	TNT1 A 0 ACS_ExecuteWithResult(265,0)
	TNT1 A 0 A_JumpIf(ACS_ExecuteWithResult(265,0) == 0, "Spawn")
	TNT1 A 0 A_GiveInventory("GotSuperArmor",1)
      Stop
   }
}

Armor system ACS code -

---

Code: Select all

//The Aperature Science Player Preservation Armor System

SCRIPT 265 (void)
{
   //1 = Already has Armor Type - intends to pick up greater armor. Do pick up.
   //0 = Already has Armor Type - intends to pick up inferior armor. Do not pick up.

   While(TRUE)
   {
   if(CheckInventory("GotSuperArmor") == 1)
   {
      if((CheckInventory("FireArmor") > 200) && (CheckInventory("NormalArmor") > 200) && (CheckInventory("SpiritArmor") > 200))
      {
	 SetResultValue( 0 );
	 delay(1);
	 Restart;
      }
      else
      {
         TakeActorInventory(334,"FireArmor",999);
         GiveActorInventory(334,"FireArmor",200);
         TakeActorInventory(334,"NormalArmor",999);
         GiveActorInventory(334,"NormalArmor",200);
         TakeActorInventory(334,"SpiritArmor",999);
         GiveActorInventory(334,"SpiritArmor",200);
         SetResultValue( 1 );
	 delay(1);
	 Restart;
      }
   }
   if(CheckInventory("GotBasicArmor") == 1)
   {
      if((CheckInventory("FireArmor") >= 50) && (CheckInventory("NormalArmor") >= 50) && (CheckInventory("SpiritArmor") >= 50))
      {
	 SetResultValue( 0 );
	 delay(1);
	 Restart;
      }
      else
      {
         TakeActorInventory(334,"FireArmor",999);
         GiveActorInventory(334,"FireArmor",50);
         TakeActorInventory(334,"NormalArmor",999);
         GiveActorInventory(334,"NormalArmor",50);
         TakeActorInventory(334,"SpiritArmor",999);
         GiveActorInventory(334,"SpiritArmor",50);
         SetResultValue( 1 );
	 delay(1);
	 Restart;
      }
   }
   if(CheckInventory("GotFireArmor") == 1)
   {
      if(CheckInventory("FireArmor") > 100)
      {
	 SetResultValue( 0 );
	 delay(1);
	 Restart;
      }
      else
      {
         TakeActorInventory(334,"FireArmor",999);
         GiveActorInventory(334,"FireArmor",100);
         SetResultValue( 1 );
	 delay(1);
	 Restart;
      }
   }
   if(CheckInventory("GotNormalArmor") == 1)
   {
      if(CheckInventory("NormalArmor") >= 100)
      {
	 SetResultValue( 0 );
	 delay(1);
	 Restart;
      }
      else
      {
         TakeActorInventory(334,"NormalArmor",999);
         GiveActorInventory(334,"NormalArmor",100);
         SetResultValue( 1 );
	 delay(1);
	 Restart;
      }
   }
   if(CheckInventory("GotSpiritArmor") == 1)
   {
      if(CheckInventory("SpiritArmor") >= 100)
      {
	 SetResultValue( 0 );
	 delay(1);
	 Restart;
      }
      else
      {
         TakeActorInventory(334,"SpiritArmor",999);
         GiveActorInventory(334,"SpiritArmor",100);
         SetResultValue( 1 );
      }
   }
   SetResultValue( 1 );
   delay(1);
   Restart;
   }
}