IDKFA gives all weapons twice

[Michi]

If you type IDKFA the alternative Hud will show all weapons twice. printinv lists all Chex Quest weapons in addition to Doom's. It looks like weapons are only added by looking at the existing sprites.

[Blzut3]

They are added if the sprites exists. This more than likely won't be changed since being able to use weapons from other games is intended behavior. Though it not really needed anymore, I see no reason to brake old mods because cheating in chex quest doesn't look right.

[Enjay]

However, if you cheat in Doom, you also get a row of weapons up the side of the screen with Alt_HUD that are, presumably, Chex weapons although, obviously, they use Doom graphics.

[Graf Zahl]

How about only giving weapons that are in a weapon slot? I know that in a few cases that may not give something that is expected to be given but it for sure eliminates the possibility of weapon duplicates being given. Is that an acceptable compromise?

[Enjay]

Doing so might make quick texting of certain items a little more complex (eg the mounted chaingun in Burghead isn't in a slot) but provided that "give whatevergun" and "use whatevergun" would still work then, yes, I think it would be much neater than a row of unselectable weapons appearing down the side of the screen.

[Rachael]

Also, I think all +POWERED_UP weapons should not be "given", as their sister counterparts should be the ones that use them. You can't even use them without the powerup, anyway.

I noticed this when I tested my weapons powerup mod on the old 1.1.04 version of GZDoom.

[Graf Zahl]

They need to be given because otherwise you can't use them at all!

[Rachael]

Hmm, then just hidden on the alt hud screen?

[Cutmanmike]

How about only giving weapons that are in a weapon slot? I know that in a few cases that may not give something that is expected to be given but it for sure eliminates the possibility of weapon duplicates being given. Is that an acceptable compromise?

Yes please, I hate getting doom weapons while I'm playing around with classes that aren't supposed to see or get them. This will apply to "give all" too right?

[Graf Zahl]

Hmm, then just hidden on the alt hud screen?

Powered up weapons are never listed.

[Graf Zahl]

Fixed. I did it a little differently:

A weapon is given if it either has no game filter, is set for the current game or is in a weapon slot. However, since weapon slots are not communicated across a network this check is only done in single player games. In multiplayer there is no safe way to detect the uselessness of such weapons.

[Macil]

Do demo recordings save weaponslot information? That could be a problem too.

I think leaving it at checking the game filter should be enough. That is the expected behavior; if I type "give all" in doom, I expect to be given doom's items, and checking the game filter is the closest to that.

[Graf Zahl]

Right. To be safe the cheat must be processed locally and each weapon be sent separately over the network. But now is not the time to fix it. It's 2:18 am here right now and I'm off to bed in a few minutes.

I think leaving it at checking the game filter should be enough.

No, it's not! Some WADs actually use weapons of other games without creating inherited versions. (e.g. Massmouth 2, The Chosen or TNT3)

[Gez]

Another fix could have been to add massive amount of Chex sprite renaming.

[Matt]

EDIT: Nevermind, it turned out to be this which given the problem in multiplayer I suspect isn't a bug.

---

I can't get the weapon cheat to recognize my weapons but I'm not sure what I'm missing.

Here's my weaponslot definitions:

Code: Select all

weaponsection HideousDestructor
addslotdefault 1 Lumberjack
addslotdefault 1 Ring
addslotdefault 2 ZM66GrenadeRifle
addslotdefault 2 ZM66Rifle
addslotdefault 3 Hunter
addslotdefault 3 Slayer
addslotdefault 4 Vulcanette
addslotdefault 5 RocquetteLauncher
addslotdefault 5 HDFragGrenades
addslotdefault 6 PlazmaGun
addslotdefault 7 BFG9K

They all inherit from "Weapon" or a Doom weapon equivalent (e.g., the Lumberjack inherits from the Chainsaw):

Code: Select all

actor Lumberjack : Chainsaw replaces Chainsaw
{
	weapon.selectionorder 802
	weapon.upsound ""
	weapon.readysound ""
	decal "BulletScratch"
	+weapon.noalert
	+inventory.undroppable
	states
	...

EDIT: I've tried adding the standard Doom weapons to the keyconf and the only thing that gets added with IDFA is the pistol. The slots work otherwise and I can select anything I do have just fine.

EDIT2: All my weapon definitions are in #includes in a file that itself is added in an #include in DECORATE. If I define a new actor that inherits everything from one of the weapons in the main DECORATE file or the first-tier #include, then add that actor to the keyconf, that cloned weapon is given. I don't understand why the other non-pistol vanilla Doom weapons refuse to appear when added to the keyconf though.