having a spawned monster lower a platform when killed ???

[mikenet2007]

Can anyone tell me what is wrong with this code?? How this works is a switch hit by the player lowers a platform enough for a cyberdemon to be released but not enough for the player to leave the area, then when the cyberdemon dies the same platform lowers again allowing the player to move on, the first part works fine but the platform doesn't lower the second time when the Cyberdemon is killed.

This is the code in ACS and the mapspot has a tid of 112

script 79 (void) //this script works as far as lowering the platform and spawning the cyberdemon, perhaps I didnt assign the new tid correctly I dont know.
{

Floor_LowerByValue (55,7,260);
Floor_LowerByValue (5,7,260);

SpawnSpot ("CYBERDEMON",112,113,0); // I believe 113 here assigns a new tid to the spawned monster.
}


script 81 (void) {
if (ThingCount(T_CYBERDEMON,113) == 0){
Floor_LowerByValue (55,7,100);
Floor_LowerByValue (5,7,100);
}
}

// This script doesn't work and I cant figure out why, it worked before on a set of monsters that didn't have to be spawned in another area of the map, but this time I cant get it to further lower the platform that is lowered in script 79. Its almost as if the function for that script is terminated and wont work again. I dont know whats going on, any ideas?

[Doomguy0505]

Code: Select all

script 79 (void)
{
	Floor_LowerByValue (55,7,260);
	Floor_LowerByValue (5,7,260);
	SpawnSpot ("CYBERDEMON",112,113,0);
	ACS_Execute(81, 0, 0, 0, 0);
}
script 81 (void)
{
	do
	{
		Floor_LowerByValue (55,7,100);
		Floor_LowerByValue (5,7,100);
		delay(1);
	} while(ThingCount(T_CYBERDEMON,113));
}

[Zippy]

Even better,

Code: Select all

script 79 (void)
{
  Floor_LowerByValue (55,7,260);
  Floor_LowerByValue (5,7,260);
  SpawnSpot ("CYBERDEMON",112,113,0);
  SetThingSpecial(113, ACS_Execute, 81 ); // When the CyberDemon dies, do this
}

script 81 (void)
{
  Floor_LowerByValue (55,7,100);
  Floor_LowerByValue (5,7,100);
}

[mikenet2007]

Well I almost got the first one to work, only problem is it didn't stop working, for some reason or another after the first script was executed the platform continued to lower nonstop until I killed the Cyberdemon then it lowered the additional 100 units and stopped. I'm sure there is a quick fix for that script maybe by adding acs_terminate somewhere, but I tried the second one and it seemed to work out good, thanks to both of you for the help.

[HotWax]

The first solution was just plain wrong, because it looped on the condition that the Cyberdemon had NOT been killed, rather than the other way around.

[Isle]

nah, you'd want it to loop while the cyb was alive. you just need to move the actions after the loop so it dosent do anything untill after the cyb is dead.

Code: Select all

script 81 (void) 
{ 
   do //nothing! lol
   { 
      delay(1); 
   } while(ThingCount(T_CYBERDEMON,113)); 
   Floor_LowerByValue (55,7,100); 
   Floor_LowerByValue (5,7,100); 
}

[Doomguy0505]

The first solution was just plain wrong, because it looped on the condition that the Cyberdemon had NOT been killed, rather than the other way around.

I forgot to test that script

[Ryan Cordell]

Since when the hell was 'do' in ACS?

[Doomguy0505]

Is it documented?

[Isle]

Since when the hell was 'do' in ACS?

for as long as 'while' has been I should hope.

[Niya]

There is no do in ACS.

[Isle]

dude you fail, hard.

[Niya]

Oh shit yeah.......You're right.