[CP] ZPack - Bugfix Release! (p1)

Nuke em · Post by **Nuke em** » Sun Jun 03, 2007 7:42 am

Nash wrote:Just a friendly note... I don't really see the point in you editing the combination out of your code by replacing them with ?'s when the code is clearly visible in your screenshot... =P

Oops...

Yeah, the multiplicative property of zero. Anything multiplied by zero becomes zero. Thus, it would (as you said) be the same as declaring them zero.

Nuke em · Post by **Nuke em** » Sun Jun 03, 2007 4:56 pm

CRAP.

This is almost working, but now the hudmessages won't work right. Every time you hit a switch the hudmessage that the variable is assigned to doesn't show up, can someone read over this and locate my mistake?

Spoiler:

Code: Select all

#Define Puzzle 10 
#Define SwitchA 11 
#Define SwitchAa 12 
#Define SwitchB 13 
#Define SwitchBb 14 
#Define SwitchC 15 
#Define SwitchCc 16 
#Define SwitchMesA 17
#Define SwitchMesB 18
#Define SwitchMesC 19
#Define PuzzleOpener 20


int A = 0; 
int B = 0; 
int C = 0; 

Script Puzzle Open 
{ 
If(A == 0 && B == 2 && C == 1){ 
Ceiling_Raisetonearest(29, 5); 
A = 0; 
B = 0; 
C = 0; 
} 

If(A == 1 && B == 0 && C == 2){ 
Ceiling_Raisetonearest(30, 5); 
A = 0; 
B = 0; 
C = 0; 
} 

If(A == 2 && B == 1 && C == 0){ 
Ceiling_Raisetonearest(31, 5); 
A = 0; 
B = 0; 
C = 0; 
} 
A++; 
B++; 
C++; 
} 

Script SwitchA (void) 
{ 
A += 1; 
}

Script SwitchAa Open
{
While(A < 3){ 
	Delay(1);
	}
A = 0;
Delay(1);
Restart;  
} 

Script SwitchB (Void) 
{ 
B += 1; 
}

Script SwitchBb Open
{
While(B < 3){
	Delay(1);
	} 
B = 0;
Delay(1);
Restart; 
} 

Script SwitchC (Void) 
{ 
C += 1;
}

Script SwitchCc Open 
{
While(C < 3){
	Delay(1);
	}
C = 0; 
Delay(1);
Restart; 
}

Script SwitchMesA (void)
{
While(A == 0){
	Hudmessage(s:"Switch A now set to 0"; Hudmsg_Typeon | HUDMSG_LOG, 1, CR_Blue, 0.5, 0.0, 6, 0.5, 10.0);
	}
While(A == 1){
	Hudmessage(s:"Switch A now set to 1"; Hudmsg_Typeon | HUDMSG_LOG, 1, CR_Blue, 0.5, 0.0, 6, 0.5, 10.0);
	}
While(A == 2){
	Hudmessage(s:"Switch A now set to 2"; Hudmsg_Typeon | HUDMSG_LOG, 1, CR_Blue, 0.5, 0.0, 6, 0.5, 10.0);
	}
Delay(35*3);
Restart;
}

Script SwitchMesB (void)
{
While(B == 0){
	Hudmessage(s:"Switch B now set to 0"; Hudmsg_Typeon | HUDMSG_LOG, 2, CR_Red, 0.5, 0.1, 6, 0.5, 10.0);
	}
While(B == 1){
	Hudmessage(s:"Switch B now set to 1"; Hudmsg_Typeon | HUDMSG_LOG, 2, CR_red, 0.5, 0.1, 6, 0.5, 10.0);
	}
While(B == 2){
	Hudmessage(s:"Switch B now set to 2"; Hudmsg_Typeon | HUDMSG_LOG, 2, CR_red, 0.5, 0.1, 6, 0.5, 10.0);	
	}
Delay(35*3);
Restart;
}

Script SwitchMesC (void)
{
While(C == 0){
	Hudmessage(s:"Switch C now set to 0"; Hudmsg_Typeon | HUDMSG_LOG, 3, CR_Yellow, 0.5, 0.2, 6, 0.5, 10.0);
	}
While(C == 1){
	Hudmessage(s:"Switch C now set to 1"; Hudmsg_Typeon | HUDMSG_LOG, 3, CR_Yellow, 0.5, 0.2, 6, 0.5, 10.0);
	}
While(C == 2){
	Hudmessage(s:"Switch C now set to 2"; Hudmsg_Typeon | HUDMSG_LOG, 3, CR_Yellow, 0.5, 0.2, 6, 0.5, 10.0);	
	}
Delay(35*3);
Restart;
}

Script PuzzleOpener (void)
{
Setfont("bigfont");
hudmessage(s:"Switch Puzzle";HUDMSG_TYPEON, 0, CR_Red, 0.25, 0.50, 6, 0.05, 10.0);
delay(35*10);
SetFont("ConFont");
hudmessage(s: "Hint: Don't cheat, play around with the \n switches for a bit, and get \n used to the way the puzzle works. \n Press the switch on the wall for more \n hints."; HUDMSG_TYPEON, 0, CR_WHITE, 0.24, 0.52, 6, 0.05, 5.0);
Delay(35*5);
Acs_execute(17, 0, 0, 0, 0);
Acs_execute(18, 0, 0, 0, 0);
Acs_execute(19, 0, 0, 0, 0);
}

Ten friggin' scripts for this sucka', I need solar's help.

Phobus · Post by **Phobus** » Mon Jun 04, 2007 3:20 am

Well, my figuring for this would be that, as you're using ACS_Execute from within the script, the world is the thing considered activatingthe SwitchMes* scripts. Try making the HudMessage parts of the SwitchMes* scripts HudMessageBold instead... or failing that, make it all one script. I can assure you from personal experience that scripts can be a lot bigger than that and still work just fine.

Risen · Post by **Risen** » Mon Jun 04, 2007 8:10 am

17, 18, and 19 use while loops. Since nothing inside the loop modifies the condition, the scripts are probably self-terminating with runaway script errors. Change those to IF. You're using Restart to keep them looping anyway. You don't need both.

You'll probably have to adjust the HUDmessage parameters as well. I don't recall what they all mean, but the values look to be too high for your restart delay and you're probably overwriting the message before it gets fully displayed.

What's the point of DEFINE-ing script names if you're just going to put ACS_Execute(17, ...) anyway?

Also, I hope you're not expecting multiplayer compatability.

And with only 25 possible values, the whole puzzle will be pretty easy to hack.

Nuke em · Post by **Nuke em** » Tue Jun 05, 2007 7:42 am

Actually in multiplayer, it would be easier to sovle the puzzle because the switches can all change at once. I could see complications if each player was in a different part of the map, but if the players have good commuinication it wouldn't matter. I'm sure there is a way for the messages to display for all players. I'll research the wiki a bit.

The script is working now, but I can't get the messages to leave the screen after the player(s) have solved it and pressed onward. I was DEFINE-ing them for it to be easily understood, but I guess I forgot about putting the names in the Execute and Terminate commands.

How would it be easy to hack?

HotWax · Post by **HotWax** » Tue Jun 05, 2007 9:14 am

Nuke em wrote:I'm sure there is a way for the messages to display for all players.

[wiki]HudMessageBold[/wiki]

The script is working now, but I can't get the messages to leave the screen after the player(s) have solved it and pressed onward.

Make sure there's a non-0 delay in the hud message, or give it a unique ID and print a blank string with the same ID to manually clear it.

How would it be easy to hack?

With only 25 possibilities, they could just try every one until it works.

Risen · Post by **Risen** » Tue Jun 05, 2007 9:25 am

Of course, I should have mentioned this before: Even better than swapping 'while' for 'if' in this situation would be to just print the variable in the HUDmessage and take out the conditional structures completely. They are not at all necessary.

And yes, it wouldn't take much time to just input all of them. So little time, in fact, that it probably will be quicker to solve the map that way unless all the codes are located very close by.

HotWax · Post by **HotWax** » Tue Jun 05, 2007 9:54 am

Oi e vey, I just opened that spoiler block and saw the script.

Remember the golden rule: Redundant code == BAD

Try this on for size:

Spoiler:

Post by **Kirby** » Tue Jun 05, 2007 12:36 pm

Ahh, the wonderful world of arrays

Phobus · Post by **Phobus** » Tue Jun 05, 2007 1:21 pm

I've been a little delayed by these last exams, but tomorrow is my last exams for the rest of this school year, so I'll be good to finish up my map either tomorrow afternoon or Thursday. Got together a couple of screenies demonstrating the texture issue I mentioned earlier, but I'll show them when I join the offsite forum, as I shall my map.

Nuke em · Post by **Nuke em** » Tue Jun 05, 2007 2:50 pm

Thanks HotWax.

As you can obviously see, I'm not a very good scripter.

I really appreciate the help you've just given me. I see how what you made works, but I would be hard pressed to do something like that by myself. So, like I said, I really thank you for the help. Now, let me take your brain and transfer your knowledge of ACS to me!

Oddly, when I wrote that post to risen, I'd already used HudMessageBold for the very reason of multiplayer display. But thanks anyways.

I'll read into your script more and improve my skillz even more.

EDIT:: 25 possibilities is enough to annoy people without pissing them off so much that they cheat, or skip the level. It's a switch combo puzzle anyway, so it wouldn't matter if they tried all the combos (they're supposed to).

EDIT 2:: The HudMessages didn't change position for each switch, and if you hit a switch before the other hudmessage is complete it starts writing over it.

HotWax · Post by **HotWax** » Tue Jun 05, 2007 3:40 pm

Nuke em wrote:EDIT 2:: The HudMessages didn't change position for each switch, and if you hit a switch before the other hudmessage is complete it starts writing over it.

The first argument of the revised script is the switch number the player is hitting. On the switch line, make sure arg3 is equal to the switch number (0 = A, 1 = B, 2 = C), or they'll all act like switch 0 (A).

Basically, instead of calling ACS_Execute(11, 0, 0, 0, 0) you need them to call ACS_Execute(11, 0, X, 0, 0), where X is the switch number.

Post by **TheDarkArchon** » Tue Jun 05, 2007 4:11 pm

On another note, I'm sure you could condense "Switches" and "SwitchColors" into a single 2-dimensional array.

HotWax · Post by **HotWax** » Tue Jun 05, 2007 4:28 pm

TheDarkArchon wrote:On another note, I'm sure you could condense "Switches" and "SwitchColors" into a single 2-dimensional array.

I don't see how that'd make any sense, TBH.
The only reason I'd do that is if each switch (A, B, C) had to have multiple colors assigned to it. Then you could have A-Blue, A-Green, A-Yellow, B-Blue, B-Green, ...

Nuke em · Post by **Nuke em** » Tue Jun 05, 2007 6:02 pm

Ok, I'm over the hill, thanks to HotWax. But now, every time the ResetSwitches function activates, it messes up the hudmessages. The values reset, but the hudmessages don't. Thus, the wrong information is displayed on screen until you hit that switch again. I'm still working on it, but I though I'd inform you so that you can quickly fix the problem if you can.

I thought that maybe you could place:

Code: Select all

HudMessage(s:"Switch ", s:SwitchNames[number], s:" now set to ", i:Switches[number]; Hudmsg_Plain | HUDMSG_LOG, number+1, SwitchColors[number], 0.5, 0.02*number, 6, 0.5, 10.0);

After a ResetSwitches and a Delay(1);, but because you have to place int number inside the parameters of the HitSwitch script it won't work.

Here's the further modified script:

Spoiler:

Code: Select all



			#Define PuzzleOpener 11
			#Define HitSwitch 12
			#Define Solution 13
			#Define PuzzleExit 14
	
	int Switches[3] = {0, 0, 0}; 
	str SwitchNames[3] = { "A", "B", "C" }; 
	int SwitchColors[3] = { CR_BLUE, CR_RED, CR_YELLOW }; 

function void ResetSwitches (void) { 
     for (int i=0; i<3; i++) Switches[i] = 0; 
} 


Script PuzzleOpener (void) {
	 Setmusic("D_Evil", 0, 35); 
     Setfont("bigfont"); 
     hudmessage(s:"Switch Puzzle";HUDMSG_TYPEON, 0, CR_Red, 0.25, 0.50, 6, 0.05, 10.0); 
     delay(35*10); 
     SetFont("ConFont"); 
     hudmessage(s: "Hint: Don't cheat, play around with the \n
      switches for a bit, and get \n 
      used to the way the puzzle works. \n 
      Press the switch on the wall for more \n 
      hints."; HUDMSG_TYPEON, 0, CR_WHITE, 0.24, 0.52, 6, 0.05, 5.0); 
} 


Script HitSwitch (int number){ 
Switches[number] += 1; 
If(Switches[number] > 2){
	Switches[number] = 0; 
	}
HudMessage(s:"Switch ", s:SwitchNames[number], s:" now set to ", i:Switches[number]; Hudmsg_Plain | HUDMSG_LOG, number+1, SwitchColors[number], 0.5, 0.02*number, 6, 0.5, 10.0); 
ACS_Execute(Solution, 0); 
} 


script Solution (void) { 
If(Switches[0] == 0 && Switches[1] == 2 && Switches[2] == 1){ 
	Ceiling_Raisetonearest(29, 5); 
	Hudmessage(s:"Gate 1 Unlocked";HUDMSG_Plain, 4, CR_Red, 0.25, 0.50, 6, 0.05, 10.0);
	ResetSwitches();
	} 
If(Switches[0] == 1 && Switches[1] == 0 && Switches[2] == 2) { 
	Ceiling_Raisetonearest(30, 5); 
	Hudmessage(s:"Gate 2 Unlocked";HUDMSG_Plain, 5, CR_Red, 0.25, 0.52, 6, 0.05, 10.0);
	ResetSwitches();
	}
If(Switches[0] == 2 && Switches[1] == 1 && Switches[2] == 0) { 
	Ceiling_Raisetonearest(31, 5); 
	Hudmessage(s:"Gate 3 Unlocked";HUDMSG_Plain, 6, CR_Red, 0.25, 0.54, 6, 0.05, 10.0);
	ResetSwitches();
	} 
} 


Script PuzzleExit (void)
{
Acs_Terminate(HitSwitch, 0);
Acs_Terminate(Solution, 0);
Acs_Terminate(PuzzleOpener, 0);
HudMessage(s:"                                       "; Hudmsg_Typeon, 1, CR_Blue, 0.5, 0.0, 6, 0.5, 10.0 );
HudMessage(s:"                                       "; Hudmsg_Typeon, 2, CR_Blue, 0.5, 0.02, 6, 0.5, 10.0 );
HudMessage(s:"                                       "; Hudmsg_Typeon, 3, CR_Blue, 0.5, 0.04, 6, 0.5, 10.0 );
Hudmessage(s:"                            ";HUDMSG_Plain, 4, CR_Red, 0.25, 0.50, 6, 0.05, 10.0);
Hudmessage(s:"                            ";HUDMSG_Plain, 5, CR_Red, 0.25, 0.52, 6, 0.05, 10.0);
Hudmessage(s:"                            ";HUDMSG_Plain, 6, CR_Red, 0.25, 0.54, 6, 0.05, 10.0);
Delay(35*3);
Setfont("bigfont");
Hudmessage(s:"Congradulations!";HUDMSG_TYPEON, 0, CR_Red, 0.25, 0.50, 6, 0.05, 10.0);
Delay(35*3);
SetFont("ConFont");
hudmessageBold(s: "Now, take your reward."; HUDMSG_TYPEON, 0, CR_WHITE, 0.24, 0.52, 6, 0.05, 5.0);
SetMusic("D_TheDa2", 0, 35);
}