[Bad wads] Music Crash

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
Sparky
Posts: 233
Joined: Sat Jul 19, 2003 10:04 am
Location: Kitchener, Ontario, Canada

Post by Sparky »

ok then, ill upload them now
the links should be
http://sparky.suhost.com/heremus.zip
http://sparky.suhost.com/heremus3.zip
BTW this music is for heretic

EDIT: im uploading the files now, give it some time im uploading at 35KB a sec so i should be done soon
the sizes arent to bad, ones 39MB the other is 35MB
User avatar
Sparky
Posts: 233
Joined: Sat Jul 19, 2003 10:04 am
Location: Kitchener, Ontario, Canada

Post by Sparky »

ok, im all done
you can go download them now
User avatar
Kappes Buur
 
 
Posts: 4114
Joined: Thu Jul 17, 2003 12:19 am
Graphics Processor: nVidia (Legacy GZDoom)
Location: British Columbia, Canada
Contact:

Post by Kappes Buur »

.
Well, it appears to be a file size limit.

The original heremus.mp3 wouldn't load at all. Neither did it crash for me.
Then I cut it down from 33:39:24 mins to 15:00:00 mins and it loaded in ok.
.
User avatar
Enjay
 
 
Posts: 26517
Joined: Tue Jul 15, 2003 4:58 pm
Location: Scotland
Contact:

Post by Enjay »

When you cut it down, did you save the cut down version in exactly the same format as the original? The reason I ask is (as I mentioned before) a long time ago I came across an MP3 file that made Zdoom crash, but loading into GoldWave and saving with a slightly different format (I dunno, a different sample rate or something) allowed the file to work.

I don't know if I have ever used a file as long as 33 mins, but I have used some fairly long ones without problems.
User avatar
Sparky
Posts: 233
Joined: Sat Jul 19, 2003 10:04 am
Location: Kitchener, Ontario, Canada

Post by Sparky »

interesting
i really dont want to cut up my music :( but im thinking this is a limit in zdoom?
User avatar
randi
Site Admin
Posts: 7746
Joined: Wed Jul 09, 2003 10:30 pm
Contact:

Post by randi »

The problem with both your wads is the same: You have a lump called TITLE that contains music. TITLE is the title picture, not the music. The title music for Heretic is supposed to be in a lump called MUS_TITL.
User avatar
Kappes Buur
 
 
Posts: 4114
Joined: Thu Jul 17, 2003 12:19 am
Graphics Processor: nVidia (Legacy GZDoom)
Location: British Columbia, Canada
Contact:

Post by Kappes Buur »

Kappes Buur wrote: Well, it appears to be a file size limit.
Hmmm, at least that's what I thought. I had renamed both your music files to D_RUNNIN.WAD (one at a time, of course),
stuffed it into the skins folder, started up ZDoom and they would not play. That's when I reduced the size of the mp3 file,
and it would play, following the same method as before.

Now, after Randy's comment I tried it again with the fullsized file and lo and behold, the blasted music starts playing.
Even with the TITLE lump still present. So, it's not a file size limit.

@Enjay

all the mp3 files I work with are 44100 Hz and 16 bits
.
User avatar
Sparky
Posts: 233
Joined: Sat Jul 19, 2003 10:04 am
Location: Kitchener, Ontario, Canada

Post by Sparky »

ok, interesting
but whats the deal with a crash? it shouldnt crash if theres that lump there
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Post by Graf Zahl »

The problem is most likely that there is no certain way to identify a graphics lump as such. So it will try to display your TITLE MP3 and crash. The only solution to avoid such a crash is to put an exception handler in the patch drawing function.
User avatar
Sparky
Posts: 233
Joined: Sat Jul 19, 2003 10:04 am
Location: Kitchener, Ontario, Canada

Post by Sparky »

in english please :) i dont know all these wacky terms :)
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Post by Graf Zahl »

The game tries to display your music file as a picture and screws up. That's all!
User avatar
randomlag
Posts: 405
Joined: Thu Jul 17, 2003 10:10 pm

Post by randomlag »

Graf Zahl wrote:The problem is most likely that there is no certain way to identify a graphics lump as such. So it will try to display your TITLE MP3 and crash. The only solution to avoid such a crash is to put an exception handler in the patch drawing function.
As I've said many times before, you can identify a graphics lump with high certainty. That's from actually doing it, not an idle guess :)

So the solution is to put some better checking in there.
User avatar
Sparky
Posts: 233
Joined: Sat Jul 19, 2003 10:04 am
Location: Kitchener, Ontario, Canada

Post by Sparky »

ok ic, but that still shouldnt make zdoom crash
the music file just wouldnt be a music file
so there, no crash. ill post a bug about this then
User avatar
Ty Halderman
... in rememberance ...
Posts: 282
Joined: Thu Jul 17, 2003 9:53 pm
Location: New Orleans LA
Contact:

Post by Ty Halderman »

It's not a bug, it's an enhancement request. Granted it's nice when things don't crash when you abuse them, but right now it's your fault. Let's let Randy fix bugs for the moment. He has a deadline to meet :P
User avatar
Sparky
Posts: 233
Joined: Sat Jul 19, 2003 10:04 am
Location: Kitchener, Ontario, Canada

Post by Sparky »

well, i guess it is
i mean the crash its trying to load a music file as a graphic
that makes sence
but the fact that its crashing is a bug, instead of that it shouldnt do anything at all
Post Reply

Return to “Closed Bugs [GZDoom]”