4.13 This Music Track No Loger Works

[Gez]

Comment from the issue thread that I raised in GitHub:

Seems it might be due to mpeg_decoder_init explicitly setting the MPG123_NO_FRANKENSTEIN flag, making libmpg123 more strict with the bytestream and causing it to reject the files since they start with 0 data and junk. libmpg123 is otherwise capable of playing the files, but not through libsndfile, and that flag stands out as a possible reason.

That's basically what Chris said above; which makes sense when you know that kcat on Github is Chris on here.

[Enjay]

Yeah, that makes sense.

I knew Chris was involved; I didn't know they were kcat.

[Chris]

As a small update, it doesn't seem as though MPG123_NO_FRANKENSTEIN is the cause of the failure with libsndfile, though the disparity between older and newer GZDoom versions is likely as said. Older releases have a ZMusic build that uses libmpg123 directly itself, which works (and is why it works for me with libmpg123 available), while newer releases rely on libsndfile alone which is less forgiving with poorly constructed mp3s. Though I am curious, at least for me libsndfile relies on libmpg123 as a shared lib. Does the Windows libsndfile build static link libmpg123 to avoid the extra DLL?

[Graf Zahl]

Yes, it does.

[siealex]

Still the same in 4.15pre303, in my case the only way to make all tracks load correctly was to convert them to Ogg Vorbis.

[TheShadsy]

In this interest of combining bug reports: I wanted to cross-post this report I made a few months ago. The latest version of ZMusic also breaks support for .mptm files, which don't play correctly under libXMP. However, they do still play correctly with the old Dummy library. viewtopic.php?t=80249 This was also reported in another thread. viewtopic.php?t=79886

Even though these new libraries are technically upgrades, the switchover in 4.13 seems to have negatively impacted multiple audio formats. Although Graf has pointed out that it's possible to change what library is used to play specific songs in SNDINFO, this doesn't fix the problem for mods that have already been released when the default libraries still worked. I want to suggest defaulting to a previous libraries for both these formats until the new libraries fix their respective problems.