DSQUAKE.OGG has a click when it repeats

[Enjay]

A real minor one here. While playing, I noticed a "click" sound during a quake effect on a map. This was with the DSQUAKE.OGG in GZDoom.pk3, not the FLAC in game support.

I double checked in a sound editor (GoldWave) to make sure that it was the sound file and not GZDoom.


So, I just zooomed right in on the wave form and cut a fraction of a second off the start and end while the wave line was in a similar position (crossing the origin line in the same direction). It seems OK to me.



Attached if you want it, but I guess Goldwave doesn't save oggs as efficiently as whatever was used to make the original because this one is 0.8 of a kb bigger, despite being a fractionally shorter sound (by 0.005034 of a second if my reading of GoldWave is correct). Also, I think OGG is a lossy format, so it will have lost some quality by recompressing. At least it doesn't click.

[Rachael]

Thanks, added. The extra 8kb doesn't bother me, and yes you are right, resaving lossy formats several times reduces quality over time, but seeing as how this file gets very little modification and the click is indeed a problem, I've gone ahead and accepted the file as-is into the repo.

All audio should indeed start and stop at the neutral (0db) line for this very reason.