[0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

[mamaluigisbagel]

That sounds like I have signed/unsigned confusion somewhere that handles XP. Does it only happen with Hell Knights?

I'm not sure, I've been trying to reproduce that problem and it's been working fine so far. Guess its just another one of those inconsistent crashes I'm good at finding

[DarkkOne]

That sounds like I have signed/unsigned confusion somewhere that handles XP. Does it only happen with Hell Knights?

I'm not sure, I've been trying to reproduce that problem and it's been working fine so far. Guess its just another one of those inconsistent crashes I'm good at finding

Once, I had a weapon suddenly gain impossible high XP as well. I'm not sure what the circumstances were, at the time I just reloaded my save and it didn't happen, I'd kinda dismissed it as "maybe an interaction between the various mods I was using." I generally try not to report bugs I can't reproduce with just the one applicable mod, but I figure it's worth mentioning that I saw something like this happen to.

[Netheritor]

Now you may as well add 'Wolfenstein: Blade of Agony' in your incompatible mod. Got VM abort.

[Xim]

Just came here to say that I'm really enjoying this mod. I've been playing this with various mods, including my own.

I noticed that guns that shoot fast projectiles don't seem to be able to use the seeker upgrade very well, if at all.

Other than that, this mod is great and it's made me want to play a lot of different mods with it too. Excellent work!

[ToxicFrog]

Yeah, seeker is incompatible with FastProjectile and in the next version it'll avoid offering it on weapons that shoot FastProjectiles rather than normal projectiles. Hopefully that version will be this weekend.

Now you may as well add 'Wolfenstein: Blade of Agony' in your incompatible mod. Got VM abort.

Blefh. I'll take a look at it -- were you doing anything in particular when it happened?

[Xim]

Excellent! I noticed that bouncing doesn't work either. I guess pretty much any flag that does not work for fast projectiles wouldn't work here either. Maybe they could be treated more like hitscan weapons considering those problems.

It looks like you're making good progress on this. Keep it up!

[Netheritor]

Blefh. I'll take a look at it -- were you doing anything in particular when it happened?

Yes, Playing the game. That thing happened in the HQ, in the firing range tutorial.
In detail; your mod hud appeared in the menu, but not in the gameplay. I press your menu mod, it's VM abort. I press fire in the firing range, got VM abort.
Just additional information, BoA also purged most other mods options menu. Your mod options doesn't appear.

[DarkkOne]

Yes, Playing the game. That thing happened in the HQ, in the firing range tutorial.
In detail; your mod hud appeared in the menu, but not in the gameplay. I press your menu mod, it's VM abort. I press fire in the firing range, got VM abort.
Just additional information, BoA also purged most other mods options menu. Your mod options doesn't appear.

Does Blade of Agony work with vanilla gzdoom, or do you have to use their binary? I got the impression you're supposed to use their, but never found out what the specific differences were. While this mod is universal, I wouldn't necessarily expect it to extend to alternative binaries which may be built on specific gzdoom versions, or have breaking changes.

[Netheritor]

That's... nice deduction. Honestly, I only downloaded the ipk3 version.

[ToxicFrog]

Blade of Agony has an ipk3 that they expect to be playable in mainline gzDoom; the "with engine" download is, presumably, for people who don't already have gzDoom installed. So while all bets are off for things that use custom binaries (Gun Bonsai doesn't even load in Selaco, for example), it should, in principle, work with Blade of Agony.

I can take a look at it, but if the fix is nontrivial it'll probably have to wait for 0.9.2.

[ToxicFrog]

It looks like the problem with BoA is that it likes to take away your inventory; for example, you have a combat knife in the opening cutscene, but it takes that away when the cutscene finishes, and then when you enter the training course it empties your inventory again -- which also removes the proxy item Bonsai uses to keep track of your upgrades.

0.9.0 made some improvements to how the upgrades are stored, which means that even if this happens they are recoverable, but at present it doesn't try to recover them every frame, only on level entry. This is probably fixable without too much trouble, though.

Also, BoA looks really cool!

[ToxicFrog]

I have 0.9.1 working in BoA, and the improvements there should make it more robust in the face of anything that takes away the player's inventory -- and also possibly slightly improve performance.

Balance may be a bit odd; in particular blowing up a tank with a rocket launcher gets you ~8000 XP in one go because every part of the tank takes damage individually and you get credit for all of them. Also, offhand grenades (as expected) assign XP to whatever weapon you're wielding when they detonate. But it should be playable.

[DarkkOne]

I have 0.9.1 working in BoA, and the improvements there should make it more robust in the face of anything that takes away the player's inventory -- and also possibly slightly improve performance.

Balance may be a bit odd; in particular blowing up a tank with a rocket launcher gets you ~8000 XP in one go because every part of the tank takes damage individually and you get credit for all of them. Also, offhand grenades (as expected) assign XP to whatever weapon you're wielding when they detonate. But it should be playable.

It's always really impressive how quickly you fix things and improve things!

[stainedofmind]

So a few times now, in the middle of what I would describe as a "heated battle", I've gone to quickly upgrade my weapon and get right back into the fight, not realizing I'm also sitting on a player upgrade, and I'll inevitably accidentally click on a random upgrade, somewhat wasting my opportunity. Not sure if you want to leave this as a feature of "screw you, pay better attention!", swap things so that the player upgrade is offered first and the weapon upgrade second, or allow the player to select which order things are offered in. ... Or of course dealer's choice if you have a better idea.

[mamaluigisbagel]

So a few times now, in the middle of what I would describe as a "heated battle", I've gone to quickly upgrade my weapon and get right back into the fight, not realizing I'm also sitting on a player upgrade, and I'll inevitably accidentally click on a random upgrade, somewhat wasting my opportunity. Not sure if you want to leave this as a feature of "screw you, pay better attention!", swap things so that the player upgrade is offered first and the weapon upgrade second, or allow the player to select which order things are offered in. ... Or of course dealer's choice if you have a better idea.

I actually mentioned this before, and if I remember right an optional confirmation message for upgrades is planned for the next release.

EDIT: Quote regarding my suggestion for the confirmation message.

That's a good idea and I've added it to the slate for 0.9.x.