A_JumpIf condition not working correctly with ScaleX (4.8.2)

[kipo]

(With GZDoom g4.8.2)

Attached is a test file of a zombieman that should increase in size, fire, and shrink again.
In past versions this works fine, but in the latest release the zombieman just freezes without firing.

This was reported to me since it breaks some parts of my mod https://www.moddb.com/mods/dn3doom

[Player701]

Bug confirmed for 4.8.1 and 4.8.2 as well as the latest master (g4.9pre-85-ga4aca9bd9), missing in 4.7.0. Bisecting reveals this commit to be the cause of the issue, ref. PR #1632. The bug is likely not JIT-related: setting +vm_jit 0 does not affect the current behavior.

[Player701]

It appears that the fix was to change the scale values from doubles to floats again, but wasn't it the intent of PR #1632 to make them floats in the first place?...

[Graf Zahl]

This reverts them to doubles. Since all floating point math is done in doubles, there were imprecisions when comparing values with the reduced precision.

[Player701]

Ah, so that's what the problem was - precision issues. I see now, thanks for the explanation.