[ZScript] [ACS] Play dialogue when monster killed

[Laskow]

Like Duke Nukem, Caleb and Lo Wang, I'd like to make the player taunts when he kills monsters by the specified damage type.

There are no warnings or errors, but it doesn't work.

I've found a few topics similar to my topic here. Well, they use DECORATE. That is not a bad method though, it takes time to set it to each monster.
Does anyone know why?


Thanks in advance!

[Laskow]

2021-10-09 15.36.11 zdoom.org bdef1d01077b.png

Oh gosh, that was my misunderstanding...

Is it impossible to check damage types when an actor dies by using Zscript?

[Virathas]

You can alwyas do something "tricky" - use WorldThingDamged, and simply check if monster that was damaged has 0 or less health. Just remember to have plenty of failsafe's, that the one doing the damage must be a player.

[Laskow]

You can alwyas do something "tricky" - use WorldThingDamged, and simply check if monster that was damaged has 0 or less health. Just remember to have plenty of failsafe's, that the one doing the damage must be a player.

---

Code: Select all

Class VoiceHandler : EventHandler
{

    Override void WorldThingDamaged(WorldEvent e)
    {
		int TauntChance = random (0, 100);

		If (e.Thing is "PlayerPawn" || !(e.DamageSource is "PlayerPawn"))
		return;

		if (e.Thing.bISMONSTER && e.Thing.health <1 && TauntChance <15)
		{
			if (e.DamageType == "Fire")
			{ e.Thing.A_GiveToTarget ("KillDialogue1") ; }
		}

    }

}

Finally it works!! Still having a problem with the ACS code though I took a step forward. Thanks!

[Virathas]

Do you really need ACS for this? Can't you play the audio directly from the KillDialogue inventory item? Since it is ZScript, you can add your own variables for delay between "speeches". The only thing that would (probably) not be as easy to do is have the logged messager in "specific" location, but a message could still be easily sent (like the ones when picking up items)

If ACS is something that you really want to use, make sure that:
1) the ACS is called
2) the script Activator is set properly (make sure that the player is the activator, and not item or world or none)
3) the random in the script is giving only integers

(I don't have time at the moment to debug it )