bugs with ye old ds models and pbr textures on gzd 4.6

Omar09 · Post by **Omar09** » Wed Jun 09, 2021 9:35 am

i tried to use some 3d models packs for vr back when gzd 4.5 was released (viewtopic.php?f=4&t=64397 and viewtopic.php?f=37&t=56344) and they worked great, now when i use the same modelpacks on gzd 4.6 they have quite a bit of issues (https://cdn.discordapp.com/attachments/ ... nknown.png and https://cdn.discordapp.com/attachments/ ... nknown.png sorry for not putting actual screenshots in the thing just links to images) also another thing is that the pbr materials for classic doom (https://www.doomworld.com/forum/topic/1 ... -textures/) works great with gzd 4.5 but with gzd 4.6 it just doesnt work, so now im just wondering why these mods dont work properly or just dont work at all with the newest gzdoom, cheers!

Post by **_mental_** » Thu Jun 10, 2021 1:21 am

First of all, do not put unrelated reports into one topic. There is a high chance that some of issues will be missed.

The problem with models was introduced by this commit, merge of Dynamic number of models per actor PR. That's why I moved this topic to Bugs.
I didn't notice any differences between 4.5.0 and 4.6.0 with the provided PBR textures. Please post screenshot(s) where the difference is seen clearly.

Post by **Graf Zahl** » Thu Jun 10, 2021 1:30 am

That thing again? What did it do this time?

Post by **Marisa the Magician** » Thu Jun 10, 2021 2:14 am

It appears that the model definitions in those mods are... very incorrect. Models are split into several sub-models rather than using surface skins, but only the first model is ever assigned in most frames.

I would say you can blame GZDoom for being "more correct" now in handling what was clearly unintended behavior.

Post by **Graf Zahl** » Thu Jun 10, 2021 2:31 am

This depended on multiple definitions overwriting the same static data. Problem: The static arrays no longer exist.
Sorry, I'm not going to try fixing such inept definitions. It's a textbook case of "how to not do stuff..."

Post by **_mental_** » Thu Jun 10, 2021 2:35 am

If author of the mentioned PR initialized all variables, those models would still work. I'll push the fix soon.

Post by **Graf Zahl** » Thu Jun 10, 2021 2:40 am

Ok, good to know.

Cherno · Post by **Cherno** » Thu Jun 10, 2021 9:13 am

I believe the same thing was reported here:

viewtopic.php?f=2&t=71850&p=1185231#p1185231

and it's the same issue, mod developers plinly disregarding what the MODELDEF wiki article says.

ZDoom

bugs with ye old ds models and pbr textures on gzd 4.6

bugs with ye old ds models and pbr textures on gzd 4.6

Re: bugs with ye old ds models and pbr textures on gzd 4.6

Re: bugs with ye old ds models and pbr textures on gzd 4.6

Re: bugs with ye old ds models and pbr textures on gzd 4.6

Re: bugs with ye old ds models and pbr textures on gzd 4.6

Re: bugs with ye old ds models and pbr textures on gzd 4.6

Re: bugs with ye old ds models and pbr textures on gzd 4.6

Re: bugs with ye old ds models and pbr textures on gzd 4.6