Hexen: LFEDGE/RTEDGE drawn too high

[Yarn366]

In GZDoom, The Hexen status bar's LFEDGE and RTEDGE graphics (which are displayed on either side of the health chain) are displayed one pixel too high (before scaling, of course). This results in a thin black bar at the very bottom edge that moves with the health chain. This appears to happen regardless of render mode.

I have attached screenshots of the status bar, one from the DOS version (running in DOSBox) and another from GZDoom 4.5.0. Notice that the GZDoom one has a thin black bar across part of the bottom (especially on the right), while the one from DOS does not. Also notice that the two runes at the bottom are a bit higher in GZDoom than in DOS. (Only the Fighter's status bar is shown, but the other classes also have this problem.)

I tested this in release builds as far back as 3.0.0 as well as the gzdoom-x64-g4.6pre-245-g14ffe3537 development build; all of them exhibit this bug.

[Graf Zahl]

Actually, the entire status bar is drawn one pixel too high. It only gets noticed with these graphics because they are a bit bugged.
If I render them a pixel ower it will close the gap but the lines don't match up anymore.
Unfortunately that's not as easy to fix because I do not want to alter all coordinates and an offset feature does not exist right now.

[Yarn366]

Actually, the entire status bar is drawn one pixel too high.

Really? For me at least, both the DOS version and GZDoom place the status bar at the same position; only LFEDGE and RTEDGE are placed higher in GZDoom.

I have attached an animated GIF that better illustrates the issue. Notice how most of the status bar is in the same position in both versions, but the graphics at the bottom corners are a bit higher in GZDoom than in DOS. (And this time I reduced the viewing areas so that any differences in how the game world looks doesn't make the status bar seem to be higher or lower.)

[Rachael]

Well I applied the fix for the 4:3 aspect but unfortunately the widescreen assets were already made for the stone being shifted up 1 pixel. This would be an easy fix if the assets for it had not already been made. I am going to wait for Nash and Graf before I commit such a fix to the repo.

[Rachael]

If the widescreen graphics issue is reconciled, this pull request will fix this bug: https://github.com/coelckers/gzdoom/pull/1391

[Graf Zahl]

I'm going to wait with this until Nash responds. No need to do a release with incorrect assets.

[Nash]

Oh, no problem, I can fix it. Give me a moment.

[Nash]

Ok, done!

[Rachael]

Added.

[Graf Zahl]

Unfortunately this still doesn't look right. While the graphic has been fixed, the extended area of the main bar apparently has not - there's still a visible discontinuity to be observed.
As it stands I'll be holding off the release for the time being.

[Rachael]

Did you do git pull --recurse?

It does not look bad to me.

[Graf Zahl]

I did a 'git submodule update'. It looks like this was the only missing thing, though. I have all the rest of the new graphics.

[Rachael]

I just did a fresh checkout and then created an archive from it using the following commands:

Code: Select all

C:\Projects\gzdoom2>git submodule init
Submodule 'wadsrc_widescreen/static' (https://github.com/nashmuhandes/WidePix) registered for path 'wadsrc_widescreen/static'

C:\Projects\gzdoom2>git pull --recurse-submodules
Already up to date.
Cloning into 'C:/Projects/gzdoom2/wadsrc_widescreen/static'...
Submodule path 'wadsrc_widescreen/static': checked out 'd458411db4795dfd1420cf1c6456f6d2999b3bad'

C:\Projects\gzdoom2\wadsrc_widescreen\static>zip -r9 /users/Rachael/game_widescreen_gfx.pk3 .
updating: filter/doom.id.doom1.registered/graphics/titlepic.lmp (172 bytes security) (deflated 51%)
updating: filter/doom.id.doom1.shareware/graphics/titlepic.lmp (172 bytes security) (deflated 53%)
updating: filter/doom.id.doom1.ultimate/graphics/credit.lmp (172 bytes security) (deflated 48%)
updating: filter/doom.id.doom1.ultimate/graphics/titlepic.lmp (172 bytes security) (deflated 51%)
updating: filter/doom.id.doom1.ultimate/textures.txt (172 bytes security) (deflated 8%)
updating: filter/doom.id.doom1/graphics/credit.lmp (172 bytes security) (deflated 63%)
updating: filter/doom.id.doom1/graphics/help1.lmp (172 bytes security) (deflated 71%)
updating: filter/doom.id.doom1/graphics/help2.lmp (172 bytes security) (deflated 64%)
updating: filter/doom.id.doom2.plutonia/graphics/titlepic.lmp (172 bytes security) (deflated 48%)
updating: filter/doom.id.doom2.plutonia/textures.txt (172 bytes security) (deflated 39%)
updating: filter/doom.id.doom2.tnt/graphics/titlepic.lmp (172 bytes security) (deflated 66%)
updating: filter/doom.id.doom2.tnt/textures.txt (172 bytes security) (deflated 39%)
updating: filter/doom.id.doom2/graphics/credit.lmp (172 bytes security) (deflated 61%)
updating: filter/doom.id.doom2/graphics/help.lmp (172 bytes security) (deflated 67%)
updating: filter/doom.id.doom2/graphics/titlepic.lmp (172 bytes security) (deflated 57%)
updating: filter/doom.id/graphics/bossback.lmp (172 bytes security) (deflated 64%)
updating: filter/doom.id/graphics/credit.lmp (172 bytes security) (deflated 61%)
updating: filter/doom.id/graphics/endpic.lmp (172 bytes security) (deflated 63%)
updating: filter/doom.id/graphics/help.lmp (172 bytes security) (deflated 67%)
updating: filter/doom.id/graphics/inter_e4.lmp (172 bytes security) (deflated 62%)
updating: filter/doom.id/graphics/interpic.lmp (172 bytes security) (deflated 58%)
updating: filter/doom.id/graphics/pfub1.lmp (172 bytes security) (deflated 70%)
updating: filter/doom.id/graphics/pfub2.lmp (172 bytes security) (deflated 65%)
updating: filter/doom.id/graphics/pluboss.lmp (172 bytes security) (deflated 68%)
updating: filter/doom.id/graphics/pluinter.lmp (172 bytes security) (deflated 66%)
updating: filter/doom.id/graphics/tntboss.lmp (172 bytes security) (deflated 51%)
updating: filter/doom.id/graphics/tntinter.lmp (172 bytes security) (deflated 78%)
updating: filter/doom.id/graphics/victory2.lmp (172 bytes security) (deflated 66%)
updating: filter/doom.id/graphics/wia20000.lmp (172 bytes security) (deflated 45%)
updating: filter/doom.id/graphics/wia20001.lmp (172 bytes security) (deflated 43%)
updating: filter/doom.id/graphics/wia20002.lmp (172 bytes security) (deflated 45%)
updating: filter/doom.id/graphics/wia20400.lmp (172 bytes security) (deflated 35%)
updating: filter/doom.id/graphics/wia20401.lmp (172 bytes security) (deflated 34%)
updating: filter/doom.id/graphics/wia20402.lmp (172 bytes security) (deflated 34%)
updating: filter/doom.id/graphics/wia20500.lmp (172 bytes security) (deflated 54%)
updating: filter/doom.id/graphics/wia20501.lmp (172 bytes security) (deflated 54%)
updating: filter/doom.id/graphics/wia20502.lmp (172 bytes security) (deflated 54%)
updating: filter/doom.id/graphics/wimap0.lmp (172 bytes security) (deflated 50%)
updating: filter/doom.id/graphics/wimap1.lmp (172 bytes security) (deflated 49%)
updating: filter/doom.id/graphics/wimap2.lmp (172 bytes security) (deflated 37%)
updating: filter/doom.id/sprites/SHT2E0.lmp (172 bytes security) (deflated 46%)
updating: filter/heretic.shadow/graphics/title.lmp (172 bytes security) (deflated 57%)
updating: filter/heretic/graphics/barback.lmp (172 bytes security) (deflated 49%)
updating: filter/heretic/graphics/credit.lmp (172 bytes security) (deflated 79%)
updating: filter/heretic/graphics/e2end.png (172 bytes security) (deflated 1%)
updating: filter/heretic/graphics/final1.lmp (172 bytes security) (deflated 68%)
updating: filter/heretic/graphics/final2.lmp (172 bytes security) (deflated 66%)
updating: filter/heretic/graphics/help1.lmp (172 bytes security) (deflated 82%)
updating: filter/heretic/graphics/help2.lmp (172 bytes security) (deflated 81%)
updating: filter/heretic/graphics/ltfctop.lmp (172 bytes security) (deflated 39%)
updating: filter/heretic/graphics/mape1.lmp (172 bytes security) (deflated 70%)
updating: filter/heretic/graphics/mape2.lmp (172 bytes security) (deflated 68%)
updating: filter/heretic/graphics/mape3.lmp (172 bytes security) (deflated 70%)
updating: filter/heretic/graphics/rtfctop.lmp (172 bytes security) (deflated 40%)
updating: filter/heretic/graphics/title.lmp (172 bytes security) (deflated 79%)
updating: filter/heretic/sprites/STFFC0.lmp (172 bytes security) (deflated 58%)
updating: filter/heretic/sprites/STFFH0.lmp (172 bytes security) (deflated 55%)
updating: filter/hexen.deathkings/graphics/credit.lmp (172 bytes security) (deflated 62%)
updating: filter/hexen.deathkings/graphics/help1.lmp (172 bytes security) (deflated 62%)
updating: filter/hexen.deathkings/graphics/help2.lmp (172 bytes security) (deflated 63%)
updating: filter/hexen.deathkings/graphics/title.lmp (172 bytes security) (deflated 68%)
updating: filter/hexen/graphics/credit.lmp (172 bytes security) (deflated 63%)
updating: filter/hexen/graphics/finale1.lmp (172 bytes security) (deflated 75%)
updating: filter/hexen/graphics/finale2.lmp (172 bytes security) (deflated 78%)
updating: filter/hexen/graphics/finale3.lmp (172 bytes security) (deflated 68%)
updating: filter/hexen/graphics/h2bar.lmp (172 bytes security) (deflated 62%)
updating: filter/hexen/graphics/h2top.lmp (172 bytes security) (deflated 59%)
updating: filter/hexen/graphics/help1.lmp (172 bytes security) (deflated 62%)
updating: filter/hexen/graphics/help2.lmp (172 bytes security) (deflated 63%)
updating: filter/hexen/graphics/interpic.lmp (172 bytes security) (deflated 77%)
updating: filter/hexen/graphics/title.lmp (172 bytes security) (deflated 71%)
updating: filter/hexen/sprites/CFLME0.lmp (172 bytes security) (deflated 45%)
updating: filter/hexen/sprites/CFLMF0.lmp (172 bytes security) (deflated 45%)
updating: filter/hexen/sprites/CMCEB0.lmp (172 bytes security) (deflated 60%)
updating: filter/hexen/sprites/CMCEC0.lmp (172 bytes security) (deflated 57%)
updating: filter/hexen/sprites/CMCED0.lmp (172 bytes security) (deflated 50%)
updating: filter/hexen/sprites/CMCEE0.lmp (172 bytes security) (deflated 51%)
updating: filter/hexen/sprites/FAXEB0.lmp (172 bytes security) (deflated 47%)
updating: filter/hexen/sprites/FAXEC0.lmp (172 bytes security) (deflated 43%)
updating: filter/hexen/sprites/FAXEN0.lmp (172 bytes security) (deflated 47%)
updating: filter/hexen/sprites/FAXEO0.lmp (172 bytes security) (deflated 43%)
updating: filter/hexen/sprites/FHMRB0.lmp (172 bytes security) (deflated 49%)
updating: filter/hexen/sprites/FHMRC0.lmp (172 bytes security) (deflated 46%)
updating: filter/hexen/sprites/FPCHB0.lmp (172 bytes security) (deflated 60%)
updating: filter/hexen/sprites/FPCHC0.lmp (172 bytes security) (deflated 52%)
updating: filter/hexen/sprites/FPCHD0.lmp (172 bytes security) (deflated 52%)
updating: filter/hexen/sprites/FPCHE0.lmp (172 bytes security) (deflated 53%)
updating: filter/hexen/sprites/FSRDD0.lmp (172 bytes security) (deflated 38%)
updating: filter/hexen/sprites/FSRDE0.lmp (172 bytes security) (deflated 32%)
updating: filter/hexen/sprites/FSRDH0.lmp (172 bytes security) (deflated 33%)
updating: filter/hexen/sprites/FSRDI0.lmp (172 bytes security) (deflated 36%)
updating: filter/hexen/sprites/MLNGG0.lmp (172 bytes security) (deflated 45%)
updating: filter/hexen/sprites/MLNGH0.lmp (172 bytes security) (deflated 44%)
updating: filter/hexen/sprites/MLNGI0.lmp (172 bytes security) (deflated 48%)
updating: .gitignore (172 bytes security) (stored 0%)
updating: credits.txt (172 bytes security) (deflated 51%)
updating: license.md (172 bytes security) (deflated 37%)
  adding: filter/ (192 bytes security) (stored 0%)
  adding: filter/doom.id/ (192 bytes security) (stored 0%)
  adding: filter/doom.id/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id/sprites/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.registered/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.registered/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.shareware/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.shareware/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.ultimate/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom1.ultimate/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2.plutonia/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2.plutonia/graphics/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2.tnt/ (192 bytes security) (stored 0%)
  adding: filter/doom.id.doom2.tnt/graphics/ (192 bytes security) (stored 0%)
  adding: filter/heretic/ (192 bytes security) (stored 0%)
  adding: filter/heretic/graphics/ (192 bytes security) (stored 0%)
  adding: filter/heretic/sprites/ (192 bytes security) (stored 0%)
  adding: filter/heretic.shadow/ (192 bytes security) (stored 0%)
  adding: filter/heretic.shadow/graphics/ (192 bytes security) (stored 0%)
  adding: filter/hexen/ (192 bytes security) (stored 0%)
  adding: filter/hexen/graphics/ (192 bytes security) (stored 0%)
  adding: filter/hexen/sprites/ (192 bytes security) (stored 0%)
  adding: filter/hexen.deathkings/ (192 bytes security) (stored 0%)
  adding: filter/hexen.deathkings/graphics/ (192 bytes security) (stored 0%)

C:\Projects\gzdoom2\wadsrc_widescreen\static>

I tested that specific archive and it has the changes. Make sure you're doing a git pull --recurse-submodules to receive the changes.

Or you can download my copy of the archive here: https://cdn.discordapp.com/attachments/ ... en_gfx.pk3

[Graf Zahl]

Git stubbornly tells me it's up to date but the files simply are not there.I had to manually reset the branch to finally get them...

[Rachael]

Yeah Git has really user-unfriendly handling of submodules which is why some people are understandably averse to them. They are great if you know how they work and exactly what to do at exactly what point but the documentation on them really isn't great and it seems like it is way easier than it should be to actually screw things up. In fact I was worried that even having the update inside of a pull request would cause problems, but it does seem like the merge went smoothly.

I will still eventually try to migrate the internal libraries to submodules (at least the ones we didn't change), but today's confusion only foreshadows what will be bigger issues later on with them, I think.