[4.5.0] LOOP_BIDI seems to be non-functional

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Kinsie
Posts: 7402
Joined: Fri Oct 22, 2004 9:22 am
Graphics Processor: nVidia with Vulkan support
Location: MAP33
Contact:

[4.5.0] LOOP_BIDI seems to be non-functional

Post by Kinsie »

Quoting a teammate:
Quick check, does GZDoom no longer support bidirectional audio looping? LOOP_BIDI doesn't seem to work anymore and the LOOP_MIDI tag seems to be totally missing from the source code
TheShadsy
Posts: 81
Joined: Sun Apr 15, 2012 2:58 pm

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Post by TheShadsy »

Hi, I'm the teammate! (also that was a typo, that should've said LOOP_BIDI, not MIDI)

But yes, I've noticed that LOOP_BIDI doesn't seem to be working when using A_StartSound with CHANF_LOOP. LOOP_START and LOOP_END are still honored, though. I tried this with both .ogg and .flac files and didn't notice any difference.

I've attached a sample sound with a LOOP_BIDI tag. It should be obvious that playback is being reversed, but the sound just restarts. Have I missed something, or is this feature having issues?
Attachments
biditest.zip
(4.54 KiB) Downloaded 15 times
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49223
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Post by Graf Zahl »

Loop_BIDI was an FModEx feature - it got removed along with that backend.
Gez
 
 
Posts: 17938
Joined: Fri Jul 06, 2007 3:22 pm

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Post by Gez »

So it'd be up to chris to implement the functionality in OpenAL and then it could be restored?
User avatar
Chris
Posts: 2969
Joined: Thu Jul 17, 2003 12:07 am
Graphics Processor: ATI/AMD with Vulkan/Metal Support

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Post by Chris »

IIRC, it wasn't a particularly cared-about feature, either in general for an audio library or for ZDoom itself. It could also pose a problem for a future enhancement I might do with OpenAL, that being direct ADPCM support in the mixer (it's a block-based adaptive codec that's nearly 4x smaller than 16-bit samples with relatively little quality loss, where samples depend on the decoder state from previous decoded samples; needing to read samples in reverse would create an obvious complication). A sound author that wants it could bake the reversed section into the sound and set the loop point on the backward and forward section to get the same effect.
TheShadsy
Posts: 81
Joined: Sun Apr 15, 2012 2:58 pm

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Post by TheShadsy »

Chris wrote:IIRC, it wasn't a particularly cared-about feature, either in general for an audio library or for ZDoom itself. It could also pose a problem for a future enhancement I might do with OpenAL, that being direct ADPCM support in the mixer (it's a block-based adaptive codec that's nearly 4x smaller than 16-bit samples with relatively little quality loss, where samples depend on the decoder state from previous decoded samples; needing to read samples in reverse would create an obvious complication). A sound author that wants it could bake the reversed section into the sound and set the loop point on the backward and forward section to get the same effect.
Somehow that hadn't even occurred to me, for whatever reason. That'll work; thanks for the clarification everyone!

And Gez, thank you for updating the wiki! I was just about to ask about that.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49223
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Post by Graf Zahl »

Chris wrote:IIRC, it wasn't a particularly cared-about feature, either in general for an audio library or for ZDoom itself.
It obviously wasn't. It got removed along with FMod more than 3.5 years ago and this is the first time it ever came up.
Post Reply

Return to “Closed Bugs [GZDoom]”