Crash on loading ksutra map05 or map10

[idvver]

I could use some help with fixing gzdoom while loading the Kama Sutra PWAD, and progressing or warping into map 05, 10 or 27. Or, decrypting fileinfo.txt, rather.
Starting a debug build of build/gzdoom through gdb, then invoking 'run' and waiting at least 30 minutes, makes the engine/game just sit there.

Before I would make a pull request: where is Apply() in wadsrc/static/zscript/level_compatibility.zs called? It makes sense to print 'Name checksum' when starting gzdoom.

git revision:

Code: Select all

g4.4pre-325-g3f9b9314a

gzdoom stops with:

Code: Select all

src/common/utility/tarray.h:264: T& TArray<T, TT>::operator const [with T = FSection; TT = FSection; size_t = long unsigned int]: Assertion `index <= Count' failed.

Command line used to load/get to map 05/10/27:

Code: Select all

~/github/coelckers/gzdoom/build/gzdoom -iwad DOOM2.WAD -file ksutra.zip +map map05 +set developer 1 -hashfiles

PWAD download: https://www.quaddicted.com/files/idgame ... ksutra.zip

[Graf Zahl]

Fixed. There was a missing check for invalid data in the calling function, but in release builds this was a harmless occurence.

[idvver]

Yes, it is fixed. Thank you for looking into it.

Can you point me to the FAQ section where it explains how to add a level fix to wadsrc/static/zscript/level_compatibility.zs? I looked for a relevant section, to no avail: https://zdoom.org/w/index.php?search=le ... arch&go=Go
For example, when loading REQIUEM.WAD as described in this PR https://github.com/coelckers/gzdoom/pull/1050 I don't see the hash BA530202AF0BA0C6CBAE6A0C7076FB72 in fileinfo.txt

[Graf Zahl]

The Apply function is called right after loading a level but before spawning any actors. The hash is calculated from the original level data and does not need to be stored in some other file.
If you want to add a new entry you first need to get the checksum with the 'mapchecksum' CCMD and then, depending on what needs to be changed either add something to compatibility.txt or level_compatibility.zs